From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3BF34C43334 for ; Wed, 6 Jul 2022 02:51:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/uvpOZcqfXb6Ah4brhvgSq44ttBB6FpLrnTZNvxIVXI=; b=iv/8WS9cyMZnGG 0gQv1542NDX7IM4H/L0y7Vh1SWspWcSWsNhh0kj8FgZ/sKe7ux3OxPLXvBYwgM5wZn0+fZi7TQc4J +v48CX+48EbjMZHNm0j1Qlf++M0/wkiCI6KO+OpvnevgYrMl3NraKVQY+/W1MUohvIvj+Om6eeYfz IpJkSF7yteehcpsdzbjT4A455h1gVdl83vhzY7XWmw1V9LbB6C2eE7j1YttaewV0zcRE8sLn2hr3o zf4ybPfh4xUcquO31ye+smKGIJm0a6AcHmxQtkoxEhtKMMMrK5im36esyWzByG8WNcb6fsLr2NnGz ubmGbISoOivgVDn4UtLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8v6y-005Ol3-CE; Wed, 06 Jul 2022 02:49:56 +0000 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o8v6u-005Ojn-3y for linux-arm-kernel@lists.infradead.org; Wed, 06 Jul 2022 02:49:54 +0000 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=guanghuifeng@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VIW9-BM_1657075784; Received: from 30.225.28.170(mailfrom:guanghuifeng@linux.alibaba.com fp:SMTPD_---0VIW9-BM_1657075784) by smtp.aliyun-inc.com; Wed, 06 Jul 2022 10:49:45 +0800 Message-ID: <7bf7c5ea-16eb-b02f-8ef5-bb94c157236d@linux.alibaba.com> Date: Wed, 6 Jul 2022 10:49:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4] arm64: mm: fix linear mem mapping access performance degradation To: Mike Rapoport , Catalin Marinas Cc: Will Deacon , Ard Biesheuvel , baolin.wang@linux.alibaba.com, akpm@linux-foundation.org, david@redhat.com, jianyong.wu@arm.com, james.morse@arm.com, quic_qiancai@quicinc.com, christophe.leroy@csgroup.eu, jonathan@marek.ca, mark.rutland@arm.com, thunder.leizhen@huawei.com, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, geert+renesas@glider.be, linux-mm@kvack.org, yaohongbo@linux.alibaba.com, alikernel-developer@linux.alibaba.com References: <6977c692-78ca-5a67-773e-0389c85f2650@linux.alibaba.com> <20220704163815.GA32177@willie-the-truck> <20220705095231.GB552@willie-the-truck> <5d044fdd-a61a-d60f-d294-89e17de37712@linux.alibaba.com> <20220705121115.GB1012@willie-the-truck> From: "guanghui.fgh" In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220705_194952_367036_F70A9968 X-CRM114-Status: GOOD ( 17.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VGhhbmtzLgoK5ZyoIDIwMjIvNy82IDQ6NDUsIE1pa2UgUmFwb3BvcnQg5YaZ6YGTOgo+IE9uIFR1 ZSwgSnVsIDA1LCAyMDIyIGF0IDA2OjA1OjAxUE0gKzAxMDAsIENhdGFsaW4gTWFyaW5hcyB3cm90 ZToKPj4gT24gVHVlLCBKdWwgMDUsIDIwMjIgYXQgMDY6NTc6NTNQTSArMDMwMCwgTWlrZSBSYXBv cG9ydCB3cm90ZToKPj4+IE9uIFR1ZSwgSnVsIDA1LCAyMDIyIGF0IDA0OjM0OjA5UE0gKzAxMDAs IENhdGFsaW4gTWFyaW5hcyB3cm90ZToKPj4+PiBPbiBUdWUsIEp1bCAwNSwgMjAyMiBhdCAwNjow MjowMlBNICswMzAwLCBNaWtlIFJhcG9wb3J0IHdyb3RlOgo+Pj4+PiArdm9pZCBfX2luaXQgcmVt YXBfY3Jhc2hrZXJuZWwodm9pZCkKPj4+Pj4gK3sKPj4+Pj4gKyNpZmRlZiBDT05GSUdfS0VYRUNf Q09SRQo+Pj4+PiArCXBoeXNfYWRkcl90IHN0YXJ0LCBlbmQsIHNpemU7Cj4+Pj4+ICsJcGh5c19h ZGRyX3QgYWxpZ25lZF9zdGFydCwgYWxpZ25lZF9lbmQ7Cj4+Pj4+ICsKPj4+Pj4gKwlpZiAoY2Fu X3NldF9kaXJlY3RfbWFwKCkgfHwgSVNfRU5BQkxFRChDT05GSUdfS0ZFTkNFKSkKPj4+Pj4gKwkg ICAgcmV0dXJuOwo+Pj4+PiArCj4+Pj4+ICsJaWYgKCFjcmFzaGtfcmVzLmVuZCkKPj4+Pj4gKwkg ICAgcmV0dXJuOwo+Pj4+PiArCj4+Pj4+ICsJc3RhcnQgPSBjcmFzaGtfcmVzLnN0YXJ0ICYgUEFH RV9NQVNLOwo+Pj4+PiArCWVuZCA9IFBBR0VfQUxJR04oY3Jhc2hrX3Jlcy5lbmQpOwo+Pj4+PiAr Cj4+Pj4+ICsJYWxpZ25lZF9zdGFydCA9IEFMSUdOX0RPV04oY3Jhc2hrX3Jlcy5zdGFydCwgUFVE X1NJWkUpOwo+Pj4+PiArCWFsaWduZWRfZW5kID0gQUxJR04oZW5kLCBQVURfU0laRSk7Cj4+Pj4+ ICsKPj4+Pj4gKwkvKiBDbGVhciBQVURzIGNvbnRhaW5pbmcgY3Jhc2gga2VybmVsIG1lbW9yeSAq Lwo+Pj4+PiArCXVubWFwX2hvdHBsdWdfcmFuZ2UoX19waHlzX3RvX3ZpcnQoYWxpZ25lZF9zdGFy dCksCj4+Pj4+ICsJCQkgICAgX19waHlzX3RvX3ZpcnQoYWxpZ25lZF9lbmQpLCBmYWxzZSwgTlVM TCk7Cj4+Pj4KPj4+PiBXaGF0IEkgZG9uJ3QgdW5kZXJzdGFuZCBpcyB3aGF0IGhhcHBlbnMgaWYg dGhlcmUncyB2YWxpZCBrZXJuZWwgZGF0YQo+Pj4+IGJldHdlZW4gYWxpZ25lZF9zdGFydCBhbmQg Y3Jhc2hrX3Jlcy5zdGFydCAob3IgdGhlIG90aGVyIGVuZCBvZiB0aGUKPj4+PiByYW5nZSkuCj4+ Pgo+Pj4gRGF0YSBzaG91bGRuJ3QgZ28gYW55d2hlcmUgOikKPj4+Cj4+PiBUaGVyZSBpcwo+Pj4K Pj4+ICsJLyogbWFwIGFyZWEgZnJvbSBQVUQgc3RhcnQgdG8gc3RhcnQgb2YgY3Jhc2gga2VybmVs IHdpdGggbGFyZ2UgcGFnZXMgKi8KPj4+ICsJc2l6ZSA9IHN0YXJ0IC0gYWxpZ25lZF9zdGFydDsK Pj4+ICsJX19jcmVhdGVfcGdkX21hcHBpbmcoc3dhcHBlcl9wZ19kaXIsIGFsaWduZWRfc3RhcnQs Cj4+PiArCQkJICAgICBfX3BoeXNfdG9fdmlydChhbGlnbmVkX3N0YXJ0KSwKPj4+ICsJCQkgICAg IHNpemUsIFBBR0VfS0VSTkVMLCBlYXJseV9wZ3RhYmxlX2FsbG9jLCAwKTsKPj4+Cj4+PiBhbmQK Pj4+Cj4+PiArCS8qIG1hcCBhcmVhIGZyb20gZW5kIG9mIGNyYXNoIGtlcm5lbCB0byBQVUQgZW5k IHdpdGggbGFyZ2UgcGFnZXMgKi8KPj4+ICsJc2l6ZSA9IGFsaWduZWRfZW5kIC0gZW5kOwo+Pj4g KwlfX2NyZWF0ZV9wZ2RfbWFwcGluZyhzd2FwcGVyX3BnX2RpciwgZW5kLCBfX3BoeXNfdG9fdmly dChlbmQpLAo+Pj4gKwkJCSAgICAgc2l6ZSwgUEFHRV9LRVJORUwsIGVhcmx5X3BndGFibGVfYWxs b2MsIDApOwo+Pj4KPj4+IGFmdGVyIHRoZSB1bm1hcCwgc28gYWZ0ZXIgd2UgdGVhciBkb3duIGEg cGFydCBvZiBhIGxpbmVhciBtYXAgd2UKPj4+IGltbWVkaWF0ZWx5IHJlY3JlYXRlIGl0LCBqdXN0 IHdpdGggYSBkaWZmZXJlbnQgcGFnZSBzaXplLgo+Pj4KPj4+IFRoaXMgYWxsIGhhcHBlbnMgYmVm b3JlIFNNUCwgc28gdGhlcmUgaXMgbm8gY29uY3VycmVuY3kgYXQgdGhhdCBwb2ludC4KPj4KPj4g VGhhdCBicmllZiBwZXJpb2Qgb2YgdW5tYXAgd29ycmllcyBtZS4gVGhlIGtlcm5lbCB0ZXh0LCBk YXRhIGFuZCBzdGFjawo+PiBhcmUgYWxsIGluIHRoZSB2bWFsbG9jIHNwYWNlIGJ1dCBhbnkgb3Ro ZXIgKG1lbWJsb2NrKSBhbGxvY2F0aW9uIHRvIHRoaXMKPj4gcG9pbnQgbWF5IGJlIGluIHRoZSB1 bm1hcHBlZCByYW5nZSBiZWZvcmUgYW5kIGFmdGVyIHRoZSBjcmFzaGtlcm5lbAo+PiByZXNlcnZh dGlvbi4gVGhlIGludGVycnVwdHMgYXJlIG9mZiwgc28gSSB0aGluayB0aGUgb25seSBhbGxvY2F0 aW9uIGFuZAo+PiBwb3RlbnRpYWwgYWNjZXNzIHRoYXQgbWF5IGdvIGluIHRoaXMgcmFuZ2UgaXMg dGhlIHBhZ2UgdGFibGUgaXRzZWxmLiBCdXQKPj4gaXQgbG9va3MgZnJhZ2lsZSB0byBtZS4KPiAK PiBJIGFncmVlIHRoZXJlIGFyZSBjaGFuY2VzIHRoZXJlIHdpbGwgYmUgYW4gYWxsb2NhdGlvbiBm cm9tIHRoZSB1bm1hcHBlZAo+IHJhbmdlLgo+IAo+IFdlIGNhbiBtYWtlIHN1cmUgdGhpcyB3b24n dCBoYXBwZW4sIHRob3VnaC4gV2UgY2FuIGNhcCB0aGUgbWVtYmxvY2sKPiBhbGxvY2F0aW9ucyB3 aXRoIG1lbWJsb2NrX3NldF9jdXJyZW50X2xpbWl0KGFsaWduZWRfZW5kKSBvcgo+IG1lbWJsb2Nr X3Jlc2VydmUoYWxnaW5lZF9zdGFydCwgYWxpZ25lZF9lbmQpIHVudGlsIHRoZSBtYXBwaW5ncyBh cmUKPiByZXN0b3JlZC4KPiAgIAo+PiAtLSAKPj4gQ2F0YWxpbgo+IApJIHRoaW5rIHRoZXJlIGlz IG5vIG5lZWQgdG8gd29ycnkgYWJvdXQgdm1hbGxvYyBtZW0uCgoxLkFzIG1lbnRpb25lZCBhYm92 ZSwKV2hlbiByZXNlcnZpbmcgY3Jhc2hrZXJuZWwgYW5kIHJlbWFwcGluZyBsaW5lYXIgbWVtIG1h cHBpbmcsIHRoZXJlIGlzIApvbmx5IG9uZSBib290IGNwdSBydW5uaW5nLiBUaGVyZSBpcyBubyBv dGhlciBjcHUvdGhyZWFkIHJ1bm5pbmcgYXQgdGhlIApzYW1lIHRpbWUuCgoyLkFsdGhvdWdoIHZt YWxsb2MgbWF5IGFsbG9jIG1lbSBmcm9tIHRoZSB1bW1hcGVkIGFyZWEsIGJ1dCB3ZSB3aWxsIApy ZWJ1aWQgcmVtYXBwaW5nIHVzaW5nIHB0ZSBsZXZlbCBtYXBwaW5nIHdoaWNoIGtlZXBzIHZpcnR1 YWwgYWRkcmVzcyB0byAKdGhlIHNhbWUgcGh5c2ljYWwgYWRkcmVzcwooQXQgdGhlIHNhbWUgdGlt ZSwgbm8gb3RoZXIgY3B1L3RocmVhZCBpcyBhY2Nlc3Mgdm1hbGxvYyBtZW0pLgoKQXMgYSByZXN1 bHQsIGl0IGhhcyBubyBlZmZlY3QgdG8gdm1hbGxvYyBtZW0uCgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6287CC43334 for ; Wed, 6 Jul 2022 02:49:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EC0858E0002; Tue, 5 Jul 2022 22:49:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E70298E0001; Tue, 5 Jul 2022 22:49:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D5F138E0002; Tue, 5 Jul 2022 22:49:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C75E48E0001 for ; Tue, 5 Jul 2022 22:49:52 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 99AC3205BF for ; Wed, 6 Jul 2022 02:49:52 +0000 (UTC) X-FDA: 79655145024.14.38D1521 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by imf28.hostedemail.com (Postfix) with ESMTP id 0B34AC0003 for ; Wed, 6 Jul 2022 02:49:49 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=guanghuifeng@linux.alibaba.com;NM=1;PH=DS;RN=21;SR=0;TI=SMTPD_---0VIW9-BM_1657075784; Received: from 30.225.28.170(mailfrom:guanghuifeng@linux.alibaba.com fp:SMTPD_---0VIW9-BM_1657075784) by smtp.aliyun-inc.com; Wed, 06 Jul 2022 10:49:45 +0800 Message-ID: <7bf7c5ea-16eb-b02f-8ef5-bb94c157236d@linux.alibaba.com> Date: Wed, 6 Jul 2022 10:49:43 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v4] arm64: mm: fix linear mem mapping access performance degradation To: Mike Rapoport , Catalin Marinas Cc: Will Deacon , Ard Biesheuvel , baolin.wang@linux.alibaba.com, akpm@linux-foundation.org, david@redhat.com, jianyong.wu@arm.com, james.morse@arm.com, quic_qiancai@quicinc.com, christophe.leroy@csgroup.eu, jonathan@marek.ca, mark.rutland@arm.com, thunder.leizhen@huawei.com, anshuman.khandual@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, geert+renesas@glider.be, linux-mm@kvack.org, yaohongbo@linux.alibaba.com, alikernel-developer@linux.alibaba.com References: <6977c692-78ca-5a67-773e-0389c85f2650@linux.alibaba.com> <20220704163815.GA32177@willie-the-truck> <20220705095231.GB552@willie-the-truck> <5d044fdd-a61a-d60f-d294-89e17de37712@linux.alibaba.com> <20220705121115.GB1012@willie-the-truck> From: "guanghui.fgh" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1657075792; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J3Qn9WjogyvZdL6eValRsykdo4ZX+t9etfargLEKbGc=; b=JpOgntJzyvYkNohlI3tlbne5Xi3AFEbmOH4we2Yz+irM4j8D0H0gbxajlVR6IUaRjKAJNx D5rOa9Ogt0r4nZBa4oYy6gzKA0yOIX/RVBplq1Rj1pR0+txaYSjYDFO1XI2T6s9Zxqy56Q 3OOsFceUYzO1M/Q2kH+Oyvf/BXnUrSU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1657075792; a=rsa-sha256; cv=none; b=ij+e68wa9DSOi+qdI+Mka1KgisCM8barwjH1wgNwi5j8IsCGhC/dAn4FjMvGiFF5wPdwNQ nxA/4omrFkEe1/CMHbCSkc31synpWlZip+AqTpkvhlc1qFlq5SobM68nOmQlK4HTSLjBAs npUc6q4ZFvMEHNjrvSsAAJmG8n8w53k= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of guanghuifeng@linux.alibaba.com designates 115.124.30.44 as permitted sender) smtp.mailfrom=guanghuifeng@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspam-User: Authentication-Results: imf28.hostedemail.com; dkim=none; spf=pass (imf28.hostedemail.com: domain of guanghuifeng@linux.alibaba.com designates 115.124.30.44 as permitted sender) smtp.mailfrom=guanghuifeng@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0B34AC0003 X-Stat-Signature: 6nomyz4rxu8f6kmh3mg3y1ugt49r88q8 X-HE-Tag: 1657075789-776941 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Thanks. 在 2022/7/6 4:45, Mike Rapoport 写道: > On Tue, Jul 05, 2022 at 06:05:01PM +0100, Catalin Marinas wrote: >> On Tue, Jul 05, 2022 at 06:57:53PM +0300, Mike Rapoport wrote: >>> On Tue, Jul 05, 2022 at 04:34:09PM +0100, Catalin Marinas wrote: >>>> On Tue, Jul 05, 2022 at 06:02:02PM +0300, Mike Rapoport wrote: >>>>> +void __init remap_crashkernel(void) >>>>> +{ >>>>> +#ifdef CONFIG_KEXEC_CORE >>>>> + phys_addr_t start, end, size; >>>>> + phys_addr_t aligned_start, aligned_end; >>>>> + >>>>> + if (can_set_direct_map() || IS_ENABLED(CONFIG_KFENCE)) >>>>> + return; >>>>> + >>>>> + if (!crashk_res.end) >>>>> + return; >>>>> + >>>>> + start = crashk_res.start & PAGE_MASK; >>>>> + end = PAGE_ALIGN(crashk_res.end); >>>>> + >>>>> + aligned_start = ALIGN_DOWN(crashk_res.start, PUD_SIZE); >>>>> + aligned_end = ALIGN(end, PUD_SIZE); >>>>> + >>>>> + /* Clear PUDs containing crash kernel memory */ >>>>> + unmap_hotplug_range(__phys_to_virt(aligned_start), >>>>> + __phys_to_virt(aligned_end), false, NULL); >>>> >>>> What I don't understand is what happens if there's valid kernel data >>>> between aligned_start and crashk_res.start (or the other end of the >>>> range). >>> >>> Data shouldn't go anywhere :) >>> >>> There is >>> >>> + /* map area from PUD start to start of crash kernel with large pages */ >>> + size = start - aligned_start; >>> + __create_pgd_mapping(swapper_pg_dir, aligned_start, >>> + __phys_to_virt(aligned_start), >>> + size, PAGE_KERNEL, early_pgtable_alloc, 0); >>> >>> and >>> >>> + /* map area from end of crash kernel to PUD end with large pages */ >>> + size = aligned_end - end; >>> + __create_pgd_mapping(swapper_pg_dir, end, __phys_to_virt(end), >>> + size, PAGE_KERNEL, early_pgtable_alloc, 0); >>> >>> after the unmap, so after we tear down a part of a linear map we >>> immediately recreate it, just with a different page size. >>> >>> This all happens before SMP, so there is no concurrency at that point. >> >> That brief period of unmap worries me. The kernel text, data and stack >> are all in the vmalloc space but any other (memblock) allocation to this >> point may be in the unmapped range before and after the crashkernel >> reservation. The interrupts are off, so I think the only allocation and >> potential access that may go in this range is the page table itself. But >> it looks fragile to me. > > I agree there are chances there will be an allocation from the unmapped > range. > > We can make sure this won't happen, though. We can cap the memblock > allocations with memblock_set_current_limit(aligned_end) or > memblock_reserve(algined_start, aligned_end) until the mappings are > restored. > >> -- >> Catalin > I think there is no need to worry about vmalloc mem. 1.As mentioned above, When reserving crashkernel and remapping linear mem mapping, there is only one boot cpu running. There is no other cpu/thread running at the same time. 2.Although vmalloc may alloc mem from the ummaped area, but we will rebuid remapping using pte level mapping which keeps virtual address to the same physical address (At the same time, no other cpu/thread is access vmalloc mem). As a result, it has no effect to vmalloc mem.