From: Jens Axboe <axboe@kernel.dk>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-block@vger.kernel.org
Cc: Christoph Hellwig <hch@lst.de>, Damien Le Moal <Damien.LeMoal@wdc.com>
Subject: Re: [PATCH v2] block: Fix partition support for host aware zoned block devices
Date: Thu, 12 Mar 2020 07:54:58 -0600 [thread overview]
Message-ID: <7bfa45fd-2ad5-be7d-b486-e778d44b3209@kernel.dk> (raw)
In-Reply-To: <20200221013708.911698-1-shinichiro.kawasaki@wdc.com>
On 2/20/20 6:37 PM, Shin'ichiro Kawasaki wrote:
> Commit b72053072c0b ("block: allow partitions on host aware zone
> devices") introduced the helper function disk_has_partitions() to check
> if a given disk has valid partitions. However, since this function result
> directly depends on the disk partition table length rather than the
> actual existence of valid partitions in the table, it returns true even
> after all partitions are removed from the disk. For host aware zoned
> block devices, this results in zone management support to be kept
> disabled even after removing all partitions.
>
> Fix this by changing disk_has_partitions() to walk through the partition
> table entries and return true if and only if a valid non-zero size
> partition is found.
Applied for 5.6, thanks.
--
Jens Axboe
prev parent reply other threads:[~2020-03-12 13:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-21 1:37 [PATCH v2] block: Fix partition support for host aware zoned block devices Shin'ichiro Kawasaki
2020-02-21 2:02 ` Damien Le Moal
2020-02-21 9:18 ` Johannes Thumshirn
2020-02-21 14:12 ` Christoph Hellwig
2020-03-06 6:47 ` Shinichiro Kawasaki
2020-03-12 13:54 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7bfa45fd-2ad5-be7d-b486-e778d44b3209@kernel.dk \
--to=axboe@kernel.dk \
--cc=Damien.LeMoal@wdc.com \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.