From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pz2-f12.google.com (mail-pz2-f12.google.com [74.125.228.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3DCE93ADBB4 for ; Thu, 10 Sep 2026 11:09:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.228.12 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789038590; cv=none; b=VLOQViU1756JyBJWJEXtI0fNgNPFaY0SRacA233gvmohin6aWBTLDVp0NOAJQQJfnzLlr4dSo6uAqfgL2n73pok3xCXR2YrSdTpxzm89/wxY66DVHQ4rneJWlgFstjY+68e/66W5W/mA/pxgGPpKjytI8/JvBWuyxLfd0ii1gjg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789038590; c=relaxed/simple; bh=Eo81uOdJ+VH0txQFT7CDWDmJC3Wu6IIZvi7ALvkgXzU=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=H2UtLSaeVCjUFyf6wyeLPWwhXLjGisMWWqQIxPf2VJ4wwi/P+W0Aas9RSxTbyRTeG3pahZgx7eTzE8plJQ+9lZnHlojLZ7So2FNzG2xztzI7/tdlGIN40HUo2+hSq5TIwXCkdiC5tcqPIomP+bnA7C1K6ULfDNbpom3d/M1mfa4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nkJD0N/p; arc=none smtp.client-ip=74.125.228.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nkJD0N/p" Received: by mail-pz2-f12.google.com with SMTP id 41be03b00d2f7-cc4bdf8acd6so245421a12.1 for ; Thu, 10 Sep 2026 04:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789038588; x=1789643388; darn=lists.linux.dev; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=8QbTTWk563brFKzUulM5hzJdIlUHhbe3RJ1vb+Th/iE=; b=nkJD0N/p/HH7QeqkklYrLD4QRtpTZHh3GjZF6nPNbjktZ6dcDhH4K9RP62MI6NUlbg GOOimYMpHD4KKrVmil1NrTVIeQr3NqYhIdNsdojtR5Y7uaiJFyefV3Y9IkuQAyxahHNO N21RLC2bSA9tCgZ0tLGjTUXP8F9/diD5RGNBVzAJ2dgGez5rATqk2GTN3YsE/+H94HF6 2Nkt/angchDyfYkCqqeOxG//VsRcK2+8jqCYb/916a3+LWlCu7taiOUwOA6Yjp9+weys TZCj0vv/6Bzw62+IXQTvUSrVF4+nAdWy16bllT18H1SOlCJYOgColCBVEzXwxIU+hVYy c6Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789038588; x=1789643388; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8QbTTWk563brFKzUulM5hzJdIlUHhbe3RJ1vb+Th/iE=; b=Sz66qqNXtSZ8GJ1EYmvCsXaSOliXqkZxuUQGQnVizyJKpgByjs8WrDbp7Ogr1vTpnK /1I71uAr28yNvAM8dMY+4zxDbVxT1eOkXWvzoUlZYwrM2quT5kpbnjUbkQ3OtYA5UaKw 3BBdIs/EwhNH3Ndq7SC+KWmcsNBwQj7SF5X+Dny4lEaYwktOXsWVb1Qw2Q3893FE24OJ f7c/OnAlot0oJ0AZxxsXsitoqAJ1jmgZCbodyvVx4j5SaHJGSJjQUJ+wfY+bRQ2IbKEc ZtBk2VTemkn85bWbuGLl8RXKT3EZLPSawIFzFAOZJwLXRU/SgamvNFKBerxFnXwkYHeZ aFOw== X-Forwarded-Encrypted: i=1; AKwUvBzqHuVblyXj15SErJbipJ/KkoB/2j7s3AU6OqAaEwGel8fsa4UWkSOTzWWPn+FtAdH0aCS4ZQNOx6Y=@lists.linux.dev X-Gm-Message-State: AFuF++n50N3LJovg/N5Lsfq1NDY9O/R3e5ShDccROPCvwsCHknkfRMIP +Smotf5kpe8ZQWGMnPn/ZjZI13toN/m2RLvkKydIu52haXfmfuhVm4a0 X-Gm-Gg: AYBFou3L5g5iYy5qQm19B7Wonh3qxOAWrsC69iBEL3KFtIRl03FfYG29OgKuHSkDsWF JtMqSQlLmQpvlMOJOfMU2K5wphsuT3yFsx4l/DlRTUh67Cvi58pcj+NzS+RjAhVPS7GKyMBZtHd RBNNzavyxYqqSQvwflakbONfIvY7pkTjY712A2oWTjpmhSElUeVWAI4sJFqJUtvHe2oCto4U945 MZMyBGMOst96dlc/S+sazonZaZRkWxJJFGN3HH1GS74piJB6d2A7gcrZMHJNMb983fF71xEAxHR QOdK7icAbPWbc5sx7mYaFDfqtlJVXR3Y0oIVLJi/yU9knQRyme3mL5celXL0T2if/VsXLdQNEtd GekKVVVt1JfECujQKyjQayheQlZ1CoexflUU0Cw41n36XmM/sZmzCh8eivrd9PBirzuTYEWxPDW +GDJDMORMif9xnu8/ih+HrgyLwlxMvLkh9MP+mseXh45MhvupQu9vApB/4bJWMA03GCscW0X5J/ 5zaNg7Tt+Ftecpo1bWnGGXD16F6ROsJWOQNEaE/JH6+E0ZVtNK8hBw= X-Received: by 2002:a17:90a:ec8b:b0:399:1b64:e0d7 with SMTP id 98e67ed59e1d1-39d70bb1bd0mr11082578a91.19.1789038588475; Thu, 10 Sep 2026 04:09:48 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1432424d27asm68881202c88.2.2026.09.10.04.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 04:09:47 -0700 (PDT) From: Ritesh Harjani (IBM) To: Sean Christopherson , Marc Zyngier , Oliver Upton , Sean Christopherson , Paolo Bonzini , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Atish Patra , Alexandre Ghiti , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Itaru Kitayama , Nicholas Piggin Subject: Re: [PATCH v2 11/20] KVM: selftests: Initialize vm->memslots[] with invalid memslots during creation In-Reply-To: <20260902164123.2546762-12-seanjc@google.com> Date: Thu, 10 Sep 2026 16:39:02 +0530 Message-ID: <7bkt1hyp.ritesh.list@gmail.com> References: <20260902164123.2546762-1-seanjc@google.com> <20260902164123.2546762-12-seanjc@google.com> Precedence: bulk X-Mailing-List: loongarch@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Sean Christopherson writes: > Initialize vm->memslots[] with an invalid memslots value during very > initial VM creation so that failure to configure the core memory regions > generates an immediate assert instead of potential weirdness, e.g. if slot0 > is coincidentally valid. This will also allow hardening the region APIs to > guard overriding a region's memslot multiple times. > Sure. Looks good overall. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 694FDC79F9F for ; Thu, 10 Sep 2026 11:10:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:Message-ID:Date: In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+QWi13AbGFS8RdWoq4Mph/Ep/qkvasDnMx+p4mHZl9E=; b=lCNAAGSu59BoxN k3Lq5xQggBoZEvVt6mH6X0wDIbYjqifpHhivLA5I04oOHfw9ayUAWHmw1Hu9FsKm/4B8UxkO6AIK4 ABQi6fTAB1rP4Myu1fb/+rdUe9BMlUEJS7Ot3yXd4vCgVSUdctPpRhZ9yuZJSitnKP9a33HOl+ogo ZgnwS2+Le/41N0fqgFUTLh0WbRRjTgAMQGQcdihZ1QHBY1B5XGxcUHngvCusC/AaT2/ws+9mo13/d P414eeibrzxttgqL9A6NpqbbS2AHV6thTTIjTvuDPD9hxYekx7pTGIuhQJBklw8NRNMlrCPfKfGsf vTLbDxVuWA8uGWiMbrpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4cfA-0000000EAVJ-0N24; Thu, 10 Sep 2026 11:09:52 +0000 Received: from mail-pz2-x10.google.com ([2607:f8b0:4864:3b::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4cf7-0000000EAUN-1ces for linux-riscv@lists.infradead.org; Thu, 10 Sep 2026 11:09:50 +0000 Received: by mail-pz2-x10.google.com with SMTP id 41be03b00d2f7-cc1cea4bfb6so640466a12.3 for ; Thu, 10 Sep 2026 04:09:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789038588; x=1789643388; darn=lists.infradead.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=8QbTTWk563brFKzUulM5hzJdIlUHhbe3RJ1vb+Th/iE=; b=B9mcoRAQhWIwRX7RI9CgEp10CcFbvJDMX9yeGOC0wYT8WxLGuhuofJa8uxKwD14xuI ZL/M6QBpeqFuVrj/RFUngEz9sV2xP2vFoII7XMjfXS2pnr0I6+xXgQkKynXoJZBP6f2P n4V79XYAllh4LoPPOJxcKQA3Pbr4u3pe4zL+7ComYBlUbpn+9GrLfHxnh4AZkWqbZN1S O5FLfo1hJ3jUgK4BYpf6U0YtsN9Gt7aie8VgeWR4LDg/kUGdaA9TjhUpXIz4m4aZ53al Qa1lKWVIY9xRkHtVZCK1MlhuZOeXXiodvv9tEvCLQ3PZBSJMhi0GRqh6vAVU2W2oQWii d94w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789038588; x=1789643388; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8QbTTWk563brFKzUulM5hzJdIlUHhbe3RJ1vb+Th/iE=; b=p6yQ8GtDyHhHtrzpuZsQwSSeUJQStruAIy5vgXHBURD+kYPcXLey9NJhotctbe4UUF eXtn7GL1DC0QsEjZI3glFInn8MHjw9rLnZv1GNNEepSQEEwEi7vsKoEiM3j0W+Xvxozl ZVJA+JQw164WA0aYaQoB7nYwms3wTkzpLkLnuwH7xguFS9f7A3pUYQgfzqz1d3JI1UII mwIChxG8sFPEA7jx6eLKXAaJyZqi/NowSMTE4YDEb7Jh7k7sYNLGRpcFCR0JZTmHDBLo xZr191dKMN5lIm33xpsba5HVf1cVbMRvGBBe03nOKdWvOyo9CFdMoiq20ng92Qh+/YAR OHoQ== X-Forwarded-Encrypted: i=1; AKwUvBy6piRn2qGu5OkzDAjg6xo6nOpBm5xNeWlgi74N53X/ZcpknYHkhUN4gw6dlChgAQE7xfbkaYwH/H9CmA==@lists.infradead.org X-Gm-Message-State: AFuF++mIprl9Rlb+P7W9p3uGQYjrQPhZWkMJHXxAgI0Kwai6nPq0smrZ D/PWOkrRYOeFzttAUIEtOBH+eSpm71eQtpcvYUFLx05vst1dk3C9z+yV X-Gm-Gg: AYBFou17q0PWl8WK95AYQSvvA9VLU0At6KEvBroX24yESqzmXyOjh5HOm/owlIsOonF 9FshvxgjN0v5mQ1u3iQtv1h9Vzt8Ik9LaJUyJTc8DaET3cPn7cekn6Uzbnk3y/6jg2vf9oacI0L 3ASfh5iZuy5MFohFIXypaRv2Z+vCY7rf943QDQJOzCYBc8jhHmdMfIqoDMU9H/hxDuGloiFlIcI 91OHq3fdCWQPIhwDea1SCW2KMxXP1ljzEfo84jHGwCWwdqNLp0PzN7tNVlZ1b7s4HW4MR/HWBXO FukjdQ79mjZzNx04Owzbk2TPrhXpqruAq9N17hPTthnl+iocbxcDoV+nXZ6xDsonGb2r107d29i zc617P/CNYcn3BO6OEnBbDwfDcIluEGvy6uV0oJ3ipRGSKoN8v0+T2szMe8jVSjYTojyzBLCxDw qY0AbM6rNTIe0rua892451uO2SofIPBXyPl18C+z/Z7McNz5qIkRWJ7yayBTg+Mm/z9Ve7hCDrG fYCkaglYcvYIhruK/ZlTRTvVCM2w1Qvfvl+HETNCSbJFI8H7rcofnM= X-Received: by 2002:a17:90a:ec8b:b0:399:1b64:e0d7 with SMTP id 98e67ed59e1d1-39d70bb1bd0mr11082578a91.19.1789038588475; Thu, 10 Sep 2026 04:09:48 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1432424d27asm68881202c88.2.2026.09.10.04.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 04:09:47 -0700 (PDT) From: Ritesh Harjani (IBM) To: Sean Christopherson , Marc Zyngier , Oliver Upton , Sean Christopherson , Paolo Bonzini , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Atish Patra , Alexandre Ghiti , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Itaru Kitayama , Nicholas Piggin Subject: Re: [PATCH v2 11/20] KVM: selftests: Initialize vm->memslots[] with invalid memslots during creation In-Reply-To: <20260902164123.2546762-12-seanjc@google.com> Date: Thu, 10 Sep 2026 16:39:02 +0530 Message-ID: <7bkt1hyp.ritesh.list@gmail.com> References: <20260902164123.2546762-1-seanjc@google.com> <20260902164123.2546762-12-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260910_040949_425423_5484CBD6 X-CRM114-Status: UNSURE ( 5.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Sean Christopherson writes: > Initialize vm->memslots[] with an invalid memslots value during very > initial VM creation so that failure to configure the core memory regions > generates an immediate assert instead of potential weirdness, e.g. if slot0 > is coincidentally valid. This will also allow hardening the region APIs to > guard overriding a region's memslot multiple times. > Sure. Looks good overall. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9722BC79FB9 for ; Thu, 10 Sep 2026 11:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:Message-ID:Date: In-Reply-To:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ci2I9HNvUaju3LIK9wN2fOjcmHuFzCaAoXGrwtDR/yo=; b=xUnyHO5WhzAvca dBmsNFb7a9R9p0tyY/hIs4T1QL4s9M1ZSSSYnBuHL/gFDFaNhlE0U7l2UwXcVTHm0i0IqfGyvWdBs Ijtud7LQIQi5drVe8Eyo0AhKI98sClFYRVjXxrVULMkCNR+5CXOOSzo+6o1i55uo8qzPTJENf+VxW tTa7XH8a/swuYHFCP2Grem+m31xNVwi1ifloGOnPiWVAbTH6oFkUylPeMpzhCu6m5n2fjGcMFmA6Z xa3JHpC05KBQMY+0z/H7CQ7vLW6UWHmAmjhfOSQFX4pxx3eNTwJdwicYq2BVjMBJp5uhDGPqWQYby Zvo7sPhrYHwayD/2Fdfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4cfD-0000000EAXJ-1JoK; Thu, 10 Sep 2026 11:09:55 +0000 Received: from mail-pz2-x10.google.com ([2607:f8b0:4864:3b::10]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x4cfB-0000000EAWC-3SEg for kvm-riscv@lists.infradead.org; Thu, 10 Sep 2026 11:09:54 +0000 Received: by mail-pz2-x10.google.com with SMTP id 41be03b00d2f7-cc1cea4bfb6so640509a12.3 for ; Thu, 10 Sep 2026 04:09:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789038593; x=1789643393; darn=lists.infradead.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=8QbTTWk563brFKzUulM5hzJdIlUHhbe3RJ1vb+Th/iE=; b=bALyQVsBq5fFcFh98px3Szyliy0W9ZlTcLUdjuf0+paa/qObkTKJ38dvdupgtZR0L7 srZxMiwlhvz3Qhth6pVQTDgYlqq1xww3lqFHjns+6zNxilWaFlPoxm8QepGhz76aitKF qQUb6Fi5twbsPhV23WiRCLgrx0W0NyHQ1tEs8SLIMEYYeSz1mgus2dDm3z26z3xpqsrj XqoGrrh4Dci0jSKOrRrt2K52MoS2bGoOETeRLKD9uCErWznvDZy4t3RSyqMjHavF3lz3 621Oxvw11xm2N71hJZnEFuULNqJbavLlEuf6TBP9jx6HaEBps9nNw9hCaSxxPKkVICV1 fmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1789038593; x=1789643393; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=8QbTTWk563brFKzUulM5hzJdIlUHhbe3RJ1vb+Th/iE=; b=n9j5mZkIUffM/YV8c1KoAkcmpECDpSKohwUowZVaT7KO/V1WISeGp9bffJCGLbTMwU dOQJS6QdsYu9e9pYPgnVOxNLXNx+7Sx+5ZB9o+x1Zmg30GTpl84au0h5WJaxZKTTSbQ5 m3IJxowEDwwhqU2ktVBotKdlMA8zpPWZVqLfPBl6HZhFzL6KT+4jSe05eWAA2gNZ3yty q+VnoI4t8bdjaPeQV3pk+ETIog/dMXp29yxXMEopUGRoDVNPVHdjZL5isudXV2wp6RCd Xb2vgTMHI667/ftWS0SeMWH/r1OR8KTWltjjxqJnsejnkVMC5v4wWQD8U4pPSG6qHJW3 O/PQ== X-Forwarded-Encrypted: i=1; AKwUvBzAmUBP7sCZMJVvfM3ISoRbIOiKujcfRcp/9cntVsw5UD+Aoohfuar+zxsrNtd//zD0BGv97BPOZqQ=@lists.infradead.org X-Gm-Message-State: AFuF++mmpzAOJjsGt9q6Xnqi8/3b5OyQ99Vobb9sItIxkHfc91PlVMeU WCuuO9nw1VhFjgCt1cRA6ZmxSm6YUCwhDKwiTx9ciBgWvwNWA8opc/Ku X-Gm-Gg: AYBFou0dO5xz4Vlgcw0l6ZodZfl+7jQN1/vjxCpaFvfl7LPvxL6s9kbh4PzbpneB+c/ bTiSNI/RYYZD8WkJT/zzluf6AfT1OUHpBEDWSwnVbZmhhOvHogo9ybxJrFFcq6i3jGMcZyiVn2P /pKxYY2jwtcfkwMAYShVdLUYrkmqy4+syUhJ1liM4glH1jmY8IdrvcZ+BvcZhNweG0IUlrG+fXZ VQ4oDcj/Ekz/sZ1nAHqEMGK0SliNNppIACCP9HkgJHQj5s177csGVHDQb72axo7+usDdmH/lye5 m0fFSVGsRcxZw4OPcq1ar9QXZcwQnYDdZSZXB08IzkGJSnEGKtHqtDKjnXIdN99hZCkOAckxuQW U9iw05HH5wGc+gTe6v5MegVCOhtNkg2lQeTjWamhbTw73lgSIttVTHoTR/T+2NtfYBBKOYJiZa0 71ox8fvExmUEpogTtUjPWdoCRaMFctrWJyRiZFO0SZolOxFBaOjxJTzlrRgWXME414RtTt2Qg64 Pkvkl/2SzNqT6hHqyWH5p5irWVLUedxisyWfGIbfJXNQXnJVlaw1qY= X-Received: by 2002:a17:90a:ec8b:b0:399:1b64:e0d7 with SMTP id 98e67ed59e1d1-39d70bb1bd0mr11082578a91.19.1789038588475; Thu, 10 Sep 2026 04:09:48 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1432424d27asm68881202c88.2.2026.09.10.04.09.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Sep 2026 04:09:47 -0700 (PDT) From: Ritesh Harjani (IBM) To: Sean Christopherson , Marc Zyngier , Oliver Upton , Sean Christopherson , Paolo Bonzini , Tianrui Zhao , Bibo Mao , Huacai Chen , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: Fuad Tabba , Joey Gouly , Steffen Eiden , Suzuki K Poulose , Zenghui Yu , Atish Patra , Alexandre Ghiti , David Hildenbrand , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kvm@vger.kernel.org, loongarch@lists.linux.dev, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, Itaru Kitayama , Nicholas Piggin Subject: Re: [PATCH v2 11/20] KVM: selftests: Initialize vm->memslots[] with invalid memslots during creation In-Reply-To: <20260902164123.2546762-12-seanjc@google.com> Date: Thu, 10 Sep 2026 16:39:02 +0530 Message-ID: <7bkt1hyp.ritesh.list@gmail.com> References: <20260902164123.2546762-1-seanjc@google.com> <20260902164123.2546762-12-seanjc@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260910_040953_854289_62E4DBB3 X-CRM114-Status: UNSURE ( 5.12 ) X-CRM114-Notice: Please train this message. X-BeenThere: kvm-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kvm-riscv" Errors-To: kvm-riscv-bounces+kvm-riscv=archiver.kernel.org@lists.infradead.org Sean Christopherson writes: > Initialize vm->memslots[] with an invalid memslots value during very > initial VM creation so that failure to configure the core memory regions > generates an immediate assert instead of potential weirdness, e.g. if slot0 > is coincidentally valid. This will also allow hardening the region APIs to > guard overriding a region's memslot multiple times. > Sure. Looks good overall. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM) -- kvm-riscv mailing list kvm-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kvm-riscv