From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C133B44237C for ; Fri, 7 Aug 2026 12:15:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786104946; cv=none; b=nJY08fLTmiDygLRoWomQjZqR5F7Cnb5TsczWnkATNbUhfnkKM3DhLcRAZuaf4HYmaiXTF15w+qVBgYRdIJCm8L24B/UwLp5T9bM/gYa3GHIdIeLhvSFWXWwJJMzWkqIEvdEkx+HiO1zBpVlV7mYvuLKmHEH+b0UWGAgsugJhS1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786104946; c=relaxed/simple; bh=Axb9P7ZeqXIDv/YIhN5h9W5JoZulVHyBXtBYYWbUvvs=; h=From:To:Cc:Subject:In-Reply-To:Date:Message-ID:References; b=Qubb2HQADsB+eR2dAmtCvMypuGGsoWiK9SvzMeO2+9uNF3hIiHJwJGsuugsiZAiw/u+0xUtPqCgrZfXhB+NIECOsvcD9OUDerdWwrziFl9OTdDKCETx1k3g6dhXiP8JU2GmT/mQ0CFbZ2anCyIHoxjO1ij3C2UgYcMT0TLuT+0k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K2zGDs8j; arc=none smtp.client-ip=209.85.215.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K2zGDs8j" Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-c9ef3e1337fso2465936a12.2 for ; Fri, 07 Aug 2026 05:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786104903; x=1786709703; darn=vger.kernel.org; h=references:message-id:date:in-reply-to:subject:cc:to:from:from:to :cc:subject:date:message-id:reply-to:content-type; bh=c0uexmqzAqMMSI/hDk3D+mxEC3THwEZ/LbKJuycr+4g=; b=K2zGDs8jnFRVhM2XseS2Ng0eDrRZDjctENSF8MHj69AttBphoT32wybOOxOwCWJJ59 cvE83dKnlhO8p2Sw+vbYRR4R4D28b8doe5siJk33/ymw3ZOMPiyLtyorIRTQK16LHFa9 4w5pk1dazr+HAMUU1GpfVa2XP/CfVzKwVJk70/kCV6G78/R90nl6qJifkbqdbNtSGQ6g ZoKypfAmeRTk2l4dNTeVsuLTYZIRTzuWRi1+X5IUY78ztngySgCIZsNT/YA01dU+058o 2lVsDd7MhBCXZuRNl1COkYgX/Zd6Bts0+8oAT/Dkxq/mhd7J5Kz/nkZ8rUQ27JofiA8n RU8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786104903; x=1786709703; h=references:message-id:date:in-reply-to:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=c0uexmqzAqMMSI/hDk3D+mxEC3THwEZ/LbKJuycr+4g=; b=r8mnHexo5e2/+pHrCLIFiK9lRZrGux6ofQPZBJav4bfF3lb5sji9Ire4/4dUdJLn4t bJYL0GkWkzOyCoIJZl2XW3VgFRp9ZUfpt+ZmWE6zf3X83bNUTUBRDXQtYfEAb/K3smRg XIxCxiGdHpQKhRsngJDVK5M2pXokKI8uSAUKWoldoqZyQDvny5N+FLUuMzqz4d9qblvv oBqYrODIXl1gS7c5VWGONvt1XqUEx6znVsWpSpZ1oKhXW9tjdsSec0isKzkvX0Lz3ahN JGTNLg6eSnY6MeCIENz41lsuoDR/P59nlIUl8snnfdE2VJU3qNMfVZB8i0iezfuAeCr/ 4x5g== X-Forwarded-Encrypted: i=1; AHgh+Ro4PtIJahLuByjmj+FDU1leZL24qtjfYDp30lyTCDuMc7SYu/AS9SkAdjXq8o9+ZdQmTm8=@vger.kernel.org X-Gm-Message-State: AOJu0YznpsJxalbhezi31DchC06shtWnH/Gb11cmZ/2NFpfEwuo0KOGz ZqIjIcHCuNd8DJ6I1LUPd6VjrDgX0WdCxsiuOIEAgP48ftQCvMAg65JN X-Gm-Gg: AR+sD13+ZOrycXyMVBYZpfpRdnaA/0thVf98+IBvysOTF63GykCku/rB/I2q4PJEdzA Npdo0rwfF2UabXP3oFEJ9PKAW4xO+nMuG6gD2U2H+inh7Ej87aA7E6J7EalPkeiYtjtTGtY7cm0 M7AKN8YsumUCLK/4IYg62T9qpe3uSuzXyzHslLQrLnv5H3Q5lPuOIPStW9j9iB/FZg2KgXwmcaM CvvNLBScYjBsoyP+N0NKnZyB6asFYxtZxxqWWa/TGp5f5qQERns7DjsXN7mAu3sN5c3YlMh4PY1 2ZdtZmyEiBdbARzgDBjd+I/YoUPfZUcHJzIqnEhitztBA6Db3tjsub+3joFjeZOPg3+lgNgGWse 5K2KA0R2p2qjKQXALnQTS5+rzJugvdHhzH8w7WQv/vIjbLkhM9yVgoJOVJYDqryvAXzxqy3MT0Y Jj8IIJhvQIDoA37CCgzTkqtdYE3Ukvpt36um9OU0FA0FuWf6vbHwsc8k2cdhA= X-Received: by 2002:a05:6a20:2450:b0:3c3:89cf:f43 with SMTP id adf61e73a8af0-3cb85eb92a7mr21944976637.30.1786104903263; Fri, 07 Aug 2026 05:15:03 -0700 (PDT) Received: from pve-server ([49.205.216.49]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315be86d3fcsm7231096eec.4.2026.08.07.05.14.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Aug 2026 05:15:02 -0700 (PDT) From: Ritesh Harjani (IBM) To: Amit Machhiwal Cc: Amit Machhiwal , linuxppc-dev@lists.ozlabs.org, Madhavan Srinivasan , Vaibhav Jain , Anushree Mathur , Paolo Bonzini , Nicholas Piggin , Michael Ellerman , "Christophe Leroy (CS GROUP)" , Jonathan Corbet , Shuah Khan , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Gautam Menghani Subject: Re: [PATCH v7 3/4] KVM: PPC: Book3S HV: Add support for compat CPU capabilities for KVM on PowerNV In-Reply-To: <20260807170704.3280f54c-e2-amachhiw@linux.ibm.com> Date: Fri, 07 Aug 2026 17:43:07 +0530 Message-ID: <7bm2ku24.ritesh.list@gmail.com> References: <20260806170645.11892-1-amachhiw@linux.ibm.com> <20260806170645.11892-4-amachhiw@linux.ibm.com> <20260807170704.3280f54c-e2-amachhiw@linux.ibm.com> Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Amit Machhiwal writes: > On 2026/08/07 10:24 AM, Ritesh Harjani wrote: >> Amit Machhiwal writes: > > > >> > >> > static int kvmppc_get_compat_caps(struct kvm_ppc_compat_caps *host_caps) >> > { >> > + struct device_node *np; >> > unsigned long capabilities = 0; >> > long rc = -EINVAL; >> > + u32 cpu_version = 0; >> > >> > if (kvmhv_on_pseries()) { >> > if (kvmhv_is_nestedv2()) { >> > WARN_ON_ONCE(!nested_capabilities); >> > capabilities = nested_capabilities; >> > rc = 0; >> > + } else { >> > + for_each_node_by_type(np, "cpu") { >> > + if (!of_property_read_u32(np, "cpu-version", >> > + &cpu_version)) { >> > + of_node_put(np); >> > + break; >> > + } >> > + } >> >> What happens when we don't have "cpu-version" DT property? >> Check this commit >> 5a61ef74f269f2 ("powerpc/64s: Support new device tree binding for discovering CPU features") >> >> And also why do we need to parse the DT properties again? >> Shouldn't we check something like this? >> >> if (cpu_has_feature(CPU_FTR_P11_PVR)) >> capabilities |= KVM_PPC_COMPAT_CAP_POWER11; >> if (cpu_has_feature(CPU_FTR_ARCH_31)) >> capabilities |= KVM_PPC_COMPAT_CAP_POWER10; >> if (cpu_has_feature(CPU_FTR_ARCH_300)) >> capabilities |= KVM_PPC_COMPAT_CAP_POWER9; >> > > Thanks for the suggestion, Ritesh! After closer analysis, cpu_has_feature() > would give the same result on pseries, but I believe that using 'cpu-version' > directly is both more correct and more explicit for this context. > > Here's why: > > 1. 'ibm,powerpc-cpu-features' / dt-cpu-ftrs is baremetal (powernv/OPAL) only. Arghh. That make sense. Thanks for checking. The design with "cpu-version" sounds good in that case. Please feel free to add: Reviewed-by: Ritesh Harjani (IBM)