From: Martin KaFai Lau <martin.lau@linux.dev>
To: Peilin Ye <yepeilin.cs@gmail.com>
Cc: Peilin Ye <peilin.ye@bytedance.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Song Liu <song@kernel.org>,
Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpf/btf: Use btf_type_str() whenever possible
Date: Fri, 16 Sep 2022 11:37:46 -0700 [thread overview]
Message-ID: <7c01a2b8-bfb7-df72-faae-0b940ea0f149@linux.dev> (raw)
In-Reply-To: <20220914021328.17039-1-yepeilin.cs@gmail.com>
On 9/13/22 7:13 PM, Peilin Ye wrote:
> From: Peilin Ye <peilin.ye@bytedance.com>
>
> We have btf_type_str(). Use it whenever possible in btf.c, instead of
> "btf_kind_str[BTF_INFO_KIND(t->info)]".
>
> Signed-off-by: Peilin Ye <peilin.ye@bytedance.com>
> ---
> kernel/bpf/btf.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/kernel/bpf/btf.c b/kernel/bpf/btf.c
> index cad4657ba2ce..81dc7423d723 100644
This clean up makes sense. The patch cannot be applied though [0], so
it is marked as 'Changes Requested'. Also, where is the cad4657ba2ce
coming from? It can't be found in the bpf-next tree. Please rebase on
the bpf-next and resend.
[0]:
https://patchwork.kernel.org/project/netdevbpf/patch/20220914021328.17039-1-yepeilin.cs@gmail.com/
next prev parent reply other threads:[~2022-09-16 18:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-14 2:13 [PATCH bpf-next] bpf/btf: Use btf_type_str() whenever possible Peilin Ye
2022-09-16 18:37 ` Martin KaFai Lau [this message]
2022-09-16 20:26 ` Peilin Ye
2022-09-16 20:28 ` [PATCH bpf-next v2] " Peilin Ye
2022-09-17 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c01a2b8-bfb7-df72-faae-0b940ea0f149@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peilin.ye@bytedance.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yepeilin.cs@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.