From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: <intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH v7 01/13] drm/i915/guc: Update GuC ADS size for error capture lists
Date: Sat, 26 Feb 2022 12:22:48 -0800 [thread overview]
Message-ID: <7c19fb65-f134-73f3-b984-cecf6ee640ca@intel.com> (raw)
In-Reply-To: <20220226095541.1010534-2-alan.previn.teres.alexis@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
On 2/26/2022 1:55 AM, Alan Previn wrote:
> -static void guc_capture_list_init(struct intel_guc *guc)
> +static int
> +guc_capture_prep_lists(struct intel_guc *guc)
> {
...
> - /* FIXME: Populate a proper capture list */
> + /* first, set aside the first page for a capture_list with zero descriptors */
> + total_size = PAGE_SIZE;
> + if (!iosys_map_is_null(&guc->ads_map)) {
> + file = shmem_create_from_data("guc-err-cap", null_header, sizeof(null_header));
Alan: CI caught a bug - above line was triggering memory allocation
i completely forgot ... will fix to match the other ADS err-capture lists
in this function - i.e. intel_guc_capture will allocate on first boot
and cache it.
> + if (!IS_ERR(file)) {
> + shmem_read_to_iosys_map(file, 0, &guc->ads_map,
> + ggtt, sizeof(null_header));
> + fput(file);
> + } else {
> + drm_dbg(&i915->drm, "GuC-capture: failed shmem for nulllist = 0x%016lx",
> + PTR_ERR(file));
> + }
> + null_ggtt = ggtt;
> + ggtt += PAGE_SIZE;
> + }
[-- Attachment #2: Type: text/html, Size: 1726 bytes --]
next prev parent reply other threads:[~2022-02-26 20:22 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-26 9:55 [Intel-gfx] [PATCH v7 00/13] Add GuC Error Capture Support Alan Previn
2022-02-26 9:55 ` Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 01/13] drm/i915/guc: Update GuC ADS size for error capture lists Alan Previn
2022-02-26 20:22 ` Teres Alexis, Alan Previn [this message]
2022-02-27 21:02 ` kernel test robot
2022-03-10 5:30 ` Matthew Brost
2022-03-11 9:59 ` Teres Alexis, Alan Previn
2022-03-11 10:18 ` Teres Alexis, Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 02/13] drm/i915/guc: Add XE_LP static registers for GuC error capture Alan Previn
2022-03-10 0:05 ` Umesh Nerlige Ramappa
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 03/13] drm/i915/guc: Add XE_LP steered register lists support Alan Previn
2022-03-10 0:56 ` Umesh Nerlige Ramappa
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 04/13] drm/i915/guc: Add DG2 registers for GuC error state capture Alan Previn
2022-03-10 1:53 ` Umesh Nerlige Ramappa
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 05/13] drm/i915/guc: Add Gen9 " Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 06/13] drm/i915/guc: Add GuC's error state capture output structures Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 07/13] drm/i915/guc: Update GuC-log relay function names Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 08/13] drm/i915/guc: Add capture region into intel_guc_log Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 09/13] drm/i915/guc: Check sizing of guc_capture output Alan Previn
2022-02-28 22:32 ` kernel test robot
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 10/13] drm/i915/guc: Extract GuC error capture lists on G2H notification Alan Previn
2022-03-11 18:16 ` Umesh Nerlige Ramappa
2022-03-11 22:27 ` Teres Alexis, Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 11/13] drm/i915/guc: Pre-allocate output nodes for extraction Alan Previn
2022-03-11 19:40 ` Umesh Nerlige Ramappa
2022-03-11 19:46 ` Teres Alexis, Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 12/13] drm/i915/guc: Plumb GuC-capture into gpu_coredump Alan Previn
2022-02-26 9:55 ` [Intel-gfx] [PATCH v7 13/13] drm/i915/guc: Print the GuC error capture output register list Alan Previn
2022-03-11 5:26 ` Umesh Nerlige Ramappa
2022-02-26 10:11 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add GuC Error Capture Support (rev7) Patchwork
2022-02-26 10:12 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2022-02-26 10:43 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c19fb65-f134-73f3-b984-cecf6ee640ca@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.