From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6467C678DC for ; Wed, 11 Jun 2025 14:16:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD2146B00A3; Wed, 11 Jun 2025 10:16:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BA9806B00A5; Wed, 11 Jun 2025 10:16:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ABED06B00A7; Wed, 11 Jun 2025 10:16:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8C24A6B00A3 for ; Wed, 11 Jun 2025 10:16:12 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 28E411D7049 for ; Wed, 11 Jun 2025 14:16:12 +0000 (UTC) X-FDA: 83543319384.30.0FF6F96 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by imf15.hostedemail.com (Postfix) with ESMTP id CA92FA0013 for ; Wed, 11 Jun 2025 14:16:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gUk6ydIQ; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749651370; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=R4FBxlGIY+3qm5BqSoRwfpFfJEei4wCunzbIsxtl8GA=; b=gAq39xctwJ2L1NMUAz1oUHixSFUHN++8UU2s6xhnDSMn9txqWwV+O/6IyxUE5QB0HMj5rW S5W/AsO2fzyXHOpxwnDNPmciZOE8ZOG8c6Uaa8V0kon/OlMBmjHVk3Bmi8MQX9NJTsmX+l tRgwigAtYT9QKxcGVLAitOPYtvwGRR0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749651370; a=rsa-sha256; cv=none; b=4HpbUpt80DF9r2qwwPua74IOD43M2IForiS8M6iwhPA4x6Mx6qL/LNMwaoUE/QnzFuduZ+ 6xPnsq00tHvYaodlrHkScv/Nn9WfjZymJFiCD8cLdh9uQT3vr46dpimRzk/75pROSlznSX /KuBX4V8eSVBL/rIjwWpEYeesefxnOk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=gUk6ydIQ; spf=pass (imf15.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.9 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1749651369; x=1781187369; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=R4FBxlGIY+3qm5BqSoRwfpFfJEei4wCunzbIsxtl8GA=; b=gUk6ydIQHPrq68BpxFkjcRAC2/ibx+5g3fahifZ8cfJZYqN7MqE6VSJ6 MerTJyub5P9y8+kwnb78RUiGO0/CA9sVPb/aD/RDM5fJhKhXOtUAC1mZy E8Tzw/TGWCVnoOKbK2aap5AH1hgE9pvLPCAuEjp0hAlOywKtcIP5aXXSO 1/rAN0Dr7BiXKQteILdCfXY5K5AwuV34NA3nmS2Yc4IImNniaFpgARMo/ 0TxwlW2wNx9A1S4rJrieCXqVysJijm9tetQc7lpTJY4ePKdI+X3iBi/kA Y64+qxI6do3LZWSfIPV13GbDd70mJIx9S0ysPeeNF5UePmD/cb2N2dXwD A==; X-CSE-ConnectionGUID: EW8+gKcjRpqq65Y2yh5SWA== X-CSE-MsgGUID: wpl/JrIrSvCd4bsBKeJD8A== X-IronPort-AV: E=McAfee;i="6800,10657,11461"; a="74332312" X-IronPort-AV: E=Sophos;i="6.16,228,1744095600"; d="scan'208";a="74332312" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2025 07:16:07 -0700 X-CSE-ConnectionGUID: e1+f1iNzQ4qzNeMoUT4bBg== X-CSE-MsgGUID: ntMwlJ5DTBqGLSkqlSQvOg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,228,1744095600"; d="scan'208";a="151989773" Received: from msatwood-mobl.amr.corp.intel.com (HELO [10.125.111.151]) ([10.125.111.151]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2025 07:16:07 -0700 Message-ID: <7c204a40-532d-4afe-94f9-e685fb9be454@intel.com> Date: Wed, 11 Jun 2025 07:16:06 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/2] x86/mm: Handle alloc failure in phys_*_init() To: Em Sharnoff , linux-kernel@vger.kernel.org, x86@kernel.org, linux-mm@kvack.org Cc: Ingo Molnar , "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Borislav Petkov , "Edgecombe, Rick P" , Oleg Vasilev , Arthur Petukhovsky , Stefan Radig , Misha Sakhnov References: <22cd0fa8-d14d-4d37-a6a1-5e6827d6182b@intel.com> <2080ec7c-8dc8-4f03-bd96-78ba47e55a97@neon.tech> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <2080ec7c-8dc8-4f03-bd96-78ba47e55a97@neon.tech> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: CA92FA0013 X-Stat-Signature: ixaao3qijias5ftygpmwubxks3rk17je X-HE-Tag: 1749651368-329988 X-HE-Meta: U2FsdGVkX19epC7RdIzxjPLvZhdTfohiof1FRyUw/nPKGfy+kTMhOHO0QBogC2sO1Fgj28AwUwiHwVF+TUo8+FNo4OZWqde/loJBp0mRds1x2q0yIiNeBNt2QWnzHUTyWuUV+grEZONavlOY+nhpPepU2R3UAZKu0JtsWxVsf2uItNv4tjzT5/x/spfnn3SAP8pZpdIlBcMsyvRU4nY8E3UUU+CfyqXKiHMgkBPsEPIKEId0gMITuKAmm+w4Hg9Oz025OeEJjbid50+PTrkuhdJ4zLx5dLjUk5hqs27OnIpI+jwySL1qDl7LvmG2H8oO5szGLkaQ88n6Pra29AwpsQYJrinI+iBkYLTwsNSnWt+9m7joYu0yhks/BuU4wX0f4cpGXuAPVU+p9bZZTfp7t1HEae0HGM0veSUOxfdUpmagNsacPbM50k0tW8S3IIJcITbrYwfO+R2z1sIA2p+cUQwBbRkw+jd5Fs9e4d+2uQmhIL8OOGEPm4WshOMnkxN4RfjIxNTCCbH6bTV6Osf8EpjbXAhjYRvtARtEQQrbWQxx0p6Ma0SSDmPJbDUIDOwdNn6YL6wBt5LDjglba7N2v1mxtQaCfMMa6VGGMf9cdCSfUZNp3568nk4/KS6CbP7GMJ31pRRd1HUoL/5MPJKeVtIs75tN4i0m1u1Hg+UkR72YxwhiO7OwPFlA4sQv2RSCmQeiPf4hQm7rWNR8n2Yi/qdSSncGItpJQPvypEXg3Z3qQBXa+kb57H79Y9vAJOAu/rP28IrzJDNdXD8rIvgUtSNRFHveAPEU/CODB+xgG1a+5ukb7pItVFbfwEvXTVII8gzPImp1HPdO1wgPv8WRV5jdVsNO9Ysvhh0z7/7Ranu/R1o7wv/w8regvkxqsOD3dyMJam0L5d7WJlPCHCKtt7VqZKscIsJJce4X+Qbi8NfRfuKqdEYGongl+/fr9XvvbF3G/EUneEf4JSc+w1C Brs3QEfJ QMMSa0bZtQxkDnwM/iKt0onsY1p8OKCud5SDtuhoOtBBsfzDsg/cnsUdkc9wNBZrpBT6NnOKecdEH/ifp7QKcVzgH2RC30dVXOAt3m0jOLhK5idM/Ld+tZGdTxG6UpQQdoXGhsOt7j8AzW5AKpQHmR9/ABW/95ju7tvBCd6zsw2RRhICGV5K+OfDfqCVO2yN5yua3KsL6rRdpCERh2fvD/CqjXOR13EpWgc/ibOHgiM7QdL828mmegbsPo9BHIPF0BuuJ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 6/11/25 01:38, Em Sharnoff wrote: >> Could you please find a way to reduce the number of casts? > What do you think about changing the return for these functions to just 'int' > for errors? > It's a larger change (especially if all callers should be updated to check the > return value), but I think much cleaner in the end. Fine with me. No reason to cram errno's into a physical address that's never used as a physical address.