From: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
To: Lorenzo Colitti <lorenzo@google.com>
Cc: netdev@vger.kernel.org,
Stephen Hemminger <stephen@networkplumber.org>,
David Ahern <dsahern@gmail.com>,
Steffen Klassert <steffen.klassert@secunet.com>
Subject: Re: [PATCH iproute2-next] ip-xfrm: Add support for OUTPUT_MARK
Date: Tue, 12 Jun 2018 12:51:37 -0600 [thread overview]
Message-ID: <7c486bcbac7302616f1bd651b4d2baad@codeaurora.org> (raw)
In-Reply-To: <CAKD1Yr0Z8ZgyE=b2MXtGOaJSRm0Y8spnU2pDxuWLd5FFgfx=eQ@mail.gmail.com>
> Have you considered putting this earlier up in the output, where the
> mark is printed as well?
>
>> + if (tb[XFRMA_OUTPUT_MARK]) {
>> + __u32 output_mark =
>> rta_getattr_u32(tb[XFRMA_OUTPUT_MARK]);
>> +
>> + fprintf(fp, "\toutput-mark 0x%x %s", output_mark,
>> _SL_);
>> + }
>> }
>
> If you wanted to implement the suggestion above, I think you could do
> that by moving this code into xfrm_xfrma_print.
>
Hi Lorenzo
I have updated it now in v2.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-06-12 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-12 2:11 [PATCH iproute2-next] ip-xfrm: Add support for OUTPUT_MARK Subash Abhinov Kasiviswanathan
2018-06-12 2:33 ` Lorenzo Colitti
2018-06-12 8:08 ` Steffen Klassert
2018-06-12 18:51 ` Subash Abhinov Kasiviswanathan [this message]
2018-06-12 3:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c486bcbac7302616f1bd651b4d2baad@codeaurora.org \
--to=subashab@codeaurora.org \
--cc=dsahern@gmail.com \
--cc=lorenzo@google.com \
--cc=netdev@vger.kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.