All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: Damien Le Moal <dlemoal@kernel.org>,
	Bart Van Assche <bvanassche@acm.org>,
	Christoph Hellwig <hch@lst.de>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: Zoned storage and BLK_STS_RESOURCE
Date: Tue, 17 Dec 2024 14:25:10 -0700	[thread overview]
Message-ID: <7c65513d-740d-4cfd-a02f-ddbd840ebb3d@kernel.dk> (raw)
In-Reply-To: <9e8e2410-53b5-4dad-8b54-b7e72647703b@kernel.org>

On 12/17/24 1:59 PM, Damien Le Moal wrote:
> On 2024/12/17 11:58, Jens Axboe wrote:
>> On 12/17/24 12:54 PM, Jens Axboe wrote:
>>> io_uring does support ordering writes - not because of zoning, but to
>>> avoid buffered writes being spread over a bunch of threads and hence
>>> just hammering the inode mutex rather than doing actual useful work. You
>>> could potentially use that. Then all pending writes for that inode would
>>> be ordered, even if punted to io-wq.
>>
>> See io_uring/io_uring.c:io_prep_async_work(), which is called when an IO
>> is added for io-wq execution, io_wq_hash_work() makes sure it'll be
>> ordered. However, this will still not work if you're driving beyond the
>> limit of the device queue depth, or if you're doing IOs that may trigger
>> -EAGAIN spuriously for -EAGAIN as you can still have two issuers - the
>> task itself submitting IO, and the one io-wq worker tasked with doing
>> blocking writes on this zoned device.
> 
> Thanks for the pointer. Will have a look. It may be as simple as
> always using the io-wq worker for zone writes and have these ordered
> (__WQ_ORDERED). Maybe.

Right, that should work if you force everything to be served by io-wq
and ensure it's hashed.

-- 
Jens Axboe

  reply	other threads:[~2024-12-17 21:25 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 19:24 Zoned storage and BLK_STS_RESOURCE Bart Van Assche
2024-12-16 20:23 ` Damien Le Moal
2024-12-16 20:42   ` Bart Van Assche
2024-12-16 20:54     ` Damien Le Moal
2024-12-16 21:22       ` Bart Van Assche
2024-12-16 22:49         ` Damien Le Moal
2024-12-17 14:56         ` Damien Le Moal
2024-12-19  5:55           ` Christoph Hellwig
2024-12-19 17:07             ` Bart Van Assche
2024-12-17  4:15 ` Christoph Hellwig
2024-12-17 15:04   ` Damien Le Moal
2024-12-17 18:38     ` Bart Van Assche
2024-12-17 18:46     ` Jens Axboe
2024-12-17 18:51       ` Damien Le Moal
2024-12-17 19:07         ` Jens Axboe
2024-12-17 19:20           ` Damien Le Moal
2024-12-17 19:25             ` Bart Van Assche
2024-12-17 19:28               ` Damien Le Moal
2024-12-17 19:33                 ` Jens Axboe
2024-12-17 19:37                   ` Damien Le Moal
2024-12-17 19:41                     ` Jens Axboe
2024-12-17 19:48                       ` Damien Le Moal
2024-12-17 19:54                         ` Jens Axboe
2024-12-17 19:58                           ` Jens Axboe
2024-12-17 20:59                             ` Damien Le Moal
2024-12-17 21:25                               ` Jens Axboe [this message]
2024-12-18  6:58                               ` Christoph Hellwig
2024-12-19 18:04                                 ` Bart Van Assche
2024-12-21  8:10                                   ` Christoph Hellwig
2025-01-06 18:54                                     ` Bart Van Assche
2024-12-19  6:00                       ` Christoph Hellwig
2024-12-19 14:50                         ` Jens Axboe
2024-12-19 17:12                         ` Bart Van Assche
2024-12-19 23:10                           ` Damien Le Moal
2025-01-06 20:14                             ` Bart Van Assche
2024-12-21  8:13                           ` Christoph Hellwig
2024-12-17 19:32             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c65513d-740d-4cfd-a02f-ddbd840ebb3d@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=dlemoal@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.