Re: [PATCH v2 1/1] system/physmem: Improve guest memory allocation failure error message

["Philippe Mathieu-Daudé" <philmd@oss.qualcomm.com>]

On 22/8/26 14:27, Bin Meng wrote:
> From: Philippe Mathieu-Daudé <philmd@redhat.com>
> 
> When Linux refuses to overcommit a seriously wild allocation we get:
> 
>    $ qemu-system-i386 -m 40000000
>    qemu-system-i386: cannot set up guest memory 'pc.ram':
>    Cannot allocate memory
> 
> Slightly improve the error message, displaying the memory size
> requested (in case the user didn't expect unspecified memory size
> unit is in MiB):
> 
>    $ qemu-system-i386 -m 40000000
>    qemu-system-i386: Cannot set up 38.1 TiB of guest memory 'pc.ram':
>    Cannot allocate memory
> 
> Reported-by: Bin Meng <bmeng.cn@gmail.com>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Peter Xu <peterx@redhat.com>
> Tested-by: Bin Meng <bmeng.cn@gmail.com>
> Signed-off-by: Bin Meng <bin.meng@processmission.com>
> 
> ---
> 
> Changes in v2:
> - Rebase onto current master
> - Update the source path from softmmu/physmem.c to system/physmem.c
> - Fix a typo in the commit message
> - Collect Peter Xu's Reviewed-by and Bin Meng's Tested-by

Thanks! :)

Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>

> 
>   system/physmem.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)