From: Gal Pressman <galpress@amazon.com>
To: Jason Gunthorpe <jgg@mellanox.com>
Cc: Leon Romanovsky <leon@kernel.org>,
Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Erez Alfasi <ereza@mellanox.com>
Subject: Re: [PATCH rdma-next 2/6] RDMA/umem: Add ODP type indicator within ib_umem_odp
Date: Wed, 7 Aug 2019 14:49:05 +0300 [thread overview]
Message-ID: <7c942fe3-cfba-e50a-c8e1-73d3a8ca80a5@amazon.com> (raw)
In-Reply-To: <20190807114451.GD1571@mellanox.com>
On 07/08/2019 14:44, Jason Gunthorpe wrote:
> On Wed, Aug 07, 2019 at 02:23:03PM +0300, Gal Pressman wrote:
>> On 07/08/2019 13:33, Leon Romanovsky wrote:
>>> +static inline void ib_umem_odp_set_type(struct ib_umem_odp *umem_odp,
>>> + unsigned long start, size_t end)
>>
>> Consider renaming 'end' to 'size'?
>>
>>> +{
>>> + if (!start && !end)
>>
>> According to the man pages, To create an implicit ODP MR, IBV_ACCESS_ON_DEMAND
>> should be set, addr should be 0 and length should be SIZE_MAX.
>> Why check end against zero?
>
> Because that isn't how it works at the umem level. The driver detects
> tha above and triggers a special umem creation flow that has a 0
> length umem.
I see, thanks!
next prev parent reply other threads:[~2019-08-07 11:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-07 10:33 [PATCH rdma-next 0/6] ODP information and statistics Leon Romanovsky
2019-08-07 10:33 ` [PATCH rdma-next 1/6] RDMA: Embed umem within core MR Leon Romanovsky
2019-08-14 9:33 ` Devesh Sharma
2019-08-07 10:33 ` [PATCH rdma-next 2/6] RDMA/umem: Add ODP type indicator within ib_umem_odp Leon Romanovsky
2019-08-07 11:23 ` Gal Pressman
2019-08-07 11:44 ` Jason Gunthorpe
2019-08-07 11:49 ` Gal Pressman [this message]
2019-08-07 11:44 ` Jason Gunthorpe
2019-08-07 12:13 ` Leon Romanovsky
2019-08-07 12:35 ` Jason Gunthorpe
2019-08-07 13:12 ` Leon Romanovsky
2019-08-12 10:53 ` Leon Romanovsky
2019-08-12 12:11 ` Jason Gunthorpe
2019-08-12 13:32 ` Leon Romanovsky
2019-08-07 10:34 ` [PATCH rdma-next 3/6] RDMA/nldev: Return ODP type per MR Leon Romanovsky
2019-08-07 10:34 ` [PATCH rdma-next 4/6] IB/mlx5: Introduce ODP diagnostic counters Leon Romanovsky
2019-08-07 10:34 ` [PATCH rdma-next 5/6] RDMA/nldev: Allow different fill function per resource Leon Romanovsky
2019-08-07 10:34 ` [PATCH rdma-next 6/6] RDMA/nldev: Provide MR statistics Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c942fe3-cfba-e50a-c8e1-73d3a8ca80a5@amazon.com \
--to=galpress@amazon.com \
--cc=dledford@redhat.com \
--cc=ereza@mellanox.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.