From: Eric Blake <eblake@redhat.com>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Cc: "Daniel P . Berrangé" <berrange@redhat.com>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>
Subject: Re: [PATCH-for-5.0?] configure: Do not leave sphinx in-tree artifacts
Date: Fri, 3 Apr 2020 12:37:12 -0500 [thread overview]
Message-ID: <7c976a7a-beeb-e3ce-5760-e4239ff7dd1f@redhat.com> (raw)
In-Reply-To: <CAFEAcA-BAvi3HEuvpMyyir9CqAbkg3nF3920zBVF-sPyFz++Rg@mail.gmail.com>
On 4/3/20 11:57 AM, Peter Maydell wrote:
> On Fri, 3 Apr 2020 at 17:54, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>>
>> When ./configure checks the sphinx version is new enough, it leaves
>> the docs/sphinx/__pycache__/ directory. Avoid this by using the '-B'
>> option (don't write .py[co] files on import) via the
>> PYTHONDONTWRITEBYTECODE environment variable.
>>
>> Reported-by: Eric Blake <eblake@redhat.com>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> This only happens for an in-tree build, right? I think in
> that case you're kind of OK with having random stuff
> left in the source tree... It seems easy enough to suppress
> them though, so I guess we might as well.
It happens in VPATH too - and what's more, in VPATH, it is still
creating it under srcdir rather than builddir, which feels like
unnecessary pollution. I was trying to prove whether 'make distclean'
got us back to a pristine state; this was one of the files that escaped
'make distclean', so our choice is to either add it to the clean rules,
or to avoid creating it in the first place. I like the approach of not
creating it in the first place :)
Reviewed-by: Eric Blake <eblake@redhat.com>
That said,
> + PYTHONDONTWRITEBYTECODE=yes "$sphinx_build" -c "$source_path/docs" -b html "$TMPDIR1/sphinx" "$TMPDIR1/sphinx/out" >/dev/null 2>&1
is now even a longer line; is it worth adding \-newline to split it up?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-04-03 17:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:54 [PATCH-for-5.0?] configure: Do not leave sphinx in-tree artifacts Philippe Mathieu-Daudé
2020-04-03 16:57 ` Peter Maydell
2020-04-03 17:33 ` Philippe Mathieu-Daudé
2020-04-03 17:37 ` Eric Blake [this message]
2020-04-03 17:49 ` Eric Blake
2020-04-03 17:55 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c976a7a-beeb-e3ce-5760-e4239ff7dd1f@redhat.com \
--to=eblake@redhat.com \
--cc=berrange@redhat.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.