All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ming-Jen Chen <mjchen0829@gmail.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-input@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, mjchen@nuvoton.com,
	peng.fan@nxp.com, sudeep.holla@arm.com, arnd@arndb.de,
	conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
	dmitry.torokhov@gmail.com
Subject: Re: [PATCH 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad
Date: Wed, 30 Oct 2024 07:10:15 +0100	[thread overview]
Message-ID: <7c993178-c021-43d2-a10f-710d7cb3a615@kernel.org> (raw)
In-Reply-To: <d6bf5b0d-7036-4636-a15e-41db6f665323@gmail.com>

On 30/10/2024 02:46, Ming-Jen Chen wrote:
>> Description of these properties did not tell me much about their purpose
>> and underlying hardware, so I don't know which fits here. It looks like
>> you want to configure clock... but then wording confuses me -
>> "per-scale". What is "per"? Isn't it usually "pre"?
>>
>> So in general I don't know what to recommend you because your patch is
>> really unclear.
>>
>> Please also wrap emails according to mailing lists standards. And use
>> proper line separation of sentences. It's really hard to understand your
>> email.
> 
> I apologize for any confusion caused by my previous responses regarding 
> this issue.
> It seems that our discussion has reached a bit of a bottleneck.
> 
> I have a suggestion that I hope you might agree with: I would like to 
> upload version 2 of the code.
> In this version, I will rewrite the properties, although it may not 
> resolve their underlying issues.
> I will also continue to keep our current discussion ongoing in version 2.
> 
> Thank you for your understanding, and I look forward to your thoughts on 
> this approach

Sure, let's try that.

Best regards,
Krzysztof



  reply	other threads:[~2024-10-30  6:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-22  6:31 [PATCH 0/2] Add support for nuvoton ma35d1 keypad controller mjchen
2024-10-22  6:31 ` [PATCH 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad mjchen
2024-10-23  8:40   ` Krzysztof Kozlowski
2024-10-25  5:36     ` Ming-Jen Chen
2024-10-25 11:42       ` Krzysztof Kozlowski
2024-10-28  1:23         ` Ming-Jen Chen
     [not found]         ` <984781ba-9f4c-4179-84d5-4ab8bbe4c3c6@gmail.com>
2024-10-28  7:04           ` Krzysztof Kozlowski
2024-10-29  2:00             ` Ming-Jen Chen
2024-10-29 13:19               ` Krzysztof Kozlowski
2024-10-30  1:46                 ` Ming-Jen Chen
2024-10-30  6:10                   ` Krzysztof Kozlowski [this message]
2024-10-23  8:53   ` Krzysztof Kozlowski
2024-10-22  6:31 ` [PATCH 2/2] input: keypad: add new keypad driver for MA35D1 mjchen
2024-10-23  8:45   ` Krzysztof Kozlowski
2024-10-28  6:23     ` Ming-Jen Chen
2024-10-23 21:20   ` Dmitry Torokhov
2024-10-29  7:06     ` Ming-Jen Chen
  -- strict thread matches above, loose matches on Subject: below --
2024-11-19  2:59 [PATCH v3 0/2] Add support for nuvoton ma35d1 keypad controller Ming-Jen Chen
2024-11-19  2:59 ` [PATCH 1/2] dt-bindings: input: Add Nuvoton MA35D1 keypad Ming-Jen Chen
2024-11-20  8:41   ` Krzysztof Kozlowski
2024-12-06  3:32     ` Ming-Jen Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c993178-c021-43d2-a10f-710d7cb3a615@kernel.org \
    --to=krzk@kernel.org \
    --cc=arnd@arndb.de \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjchen0829@gmail.com \
    --cc=mjchen@nuvoton.com \
    --cc=peng.fan@nxp.com \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.