From: John Hubbard <jhubbard@nvidia.com>
To: Timur Tabi <ttabi@nvidia.com>,
"miguel.ojeda.sandonis@gmail.com"
<miguel.ojeda.sandonis@gmail.com>
Cc: "ojeda@kernel.org" <ojeda@kernel.org>,
"aliceryhl@google.com" <aliceryhl@google.com>,
"lossin@kernel.org" <lossin@kernel.org>,
"dakr@kernel.org" <dakr@kernel.org>,
"rust-for-linux@vger.kernel.org" <rust-for-linux@vger.kernel.org>
Subject: Re: [PATCH] [v2] rust: introduce sfile macro for succinct code tracing
Date: Fri, 6 Jun 2025 17:13:33 -0700 [thread overview]
Message-ID: <7cb5acbe-a643-4489-936a-0e68d760f960@nvidia.com> (raw)
In-Reply-To: <ecc4bb6c582bb99c17b4795d80d2556e98e590f9.camel@nvidia.com>
On 6/6/25 3:11 PM, Timur Tabi wrote:
> On Wed, 2025-06-04 at 00:53 +0200, Miguel Ojeda wrote:
>> On Tue, Jun 3, 2025 at 9:55 PM Timur Tabi <ttabi@nvidia.com> wrote:
...>> By the way, please use the standard "[...]" for patch titles -- you
>> can pass e.g. `-v2` to Git for that. (And ideally please provide `--base` too).
>
--base is quite helpful, please don't overlook that, too.
> You mean you don't like [PATCH][V2]? I've been doing that for 20 years, and this is the first time
> anyone's complained.
During those 20 years, the kernel community moved to a mostly git-based
workflow. And git's "-v2" is a neat little time saver that also ensures that
your patchsets look "standard" to...pretty much everyone else here.
It's less about what you have been doing, and more about what others
expect to see.
thanks,
--
John Hubbard
next prev parent reply other threads:[~2025-06-07 0:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 19:54 [PATCH] [v2] rust: introduce sfile macro for succinct code tracing Timur Tabi
2025-06-03 22:53 ` Miguel Ojeda
2025-06-06 22:11 ` Timur Tabi
2025-06-07 0:13 ` John Hubbard [this message]
2025-06-07 10:17 ` Miguel Ojeda
2025-06-04 9:00 ` Alice Ryhl
2025-06-04 20:43 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cb5acbe-a643-4489-936a-0e68d760f960@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=aliceryhl@google.com \
--cc=dakr@kernel.org \
--cc=lossin@kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=ttabi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.