From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D355DC433EF for ; Thu, 16 Dec 2021 14:25:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C23691FAF; Thu, 16 Dec 2021 15:24:58 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C23691FAF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1639664748; bh=mkTC902VJsukGWYp0cd2hXrBg3Mu9ttjfy/WA0MbxBs=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=q44KCnZxmYQK14WFRdBxjfUetX8aWuo0CvgPUY5jmLJjr5JPnfeuxljZwl2h0sEVG LbBBuj1UWtY6elFM7aPCk+3l1pQl24LxBeCCtraTatOVkhOaQthsBZZQ8+VxNRVZox E95Si5s/ryWE40tNeDSlrYWOeuM4ICqloU0NWcts= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 46FADF800F4; Thu, 16 Dec 2021 15:24:58 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D0AB9F80116; Thu, 16 Dec 2021 15:24:56 +0100 (CET) Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 66132F800DE for ; Thu, 16 Dec 2021 15:24:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 66132F800DE Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="igVil4d7" Received: by mail-lj1-x22c.google.com with SMTP id a37so37682072ljq.13 for ; Thu, 16 Dec 2021 06:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3te9pe7rOJHos3EuPgW4pF2bDr58GHICUC52sb6TTQw=; b=igVil4d7hecRf/ZlSHkjGruHgf+4OOe4/KwyAc3HNyI/F2/EASnbWlmBW1xTb9kyIf LCsjrURmGl04f3eT9XO2PC7S7qc7QHJF7vXVdsW221Oir2aAxMMhWcEDjv3yX9WDczqV ZDS/IvjvPnck+FzEw10c7WJJf3Hs1whJzcS4oMZEwL83kIugA95UTue+8vljF7orSw/F W1pN26OniH5nNBEyrLvvldgEsL7ZcXLfrgZgfW/+EJCzdM179Fnek2baPlSqDFWaJuu5 R2hxrJEuFfzP88gWkIzimlDjZBs6i7mip18yIbHvCl3zFmfzJdLvHKsnANZ9IEim+FqC +aZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3te9pe7rOJHos3EuPgW4pF2bDr58GHICUC52sb6TTQw=; b=100oSgGl9I8AJDZ81+JA9r5jKLrrv+UUeExbuZ2dYLw+diyZSSPnPE2Q5Z0K1+w+Rl XeAK7tvcEwBGAR3pD00u+kSUAXxUAzQs4urIReNH+JkSpq5KPubLFgI6R+riVCDc6qWI oyK5aqUqN5V5H+LMTOn/FHjAAnHgiWAQ/GbNV+8SO8wbQiKjxhrnbuCPPCSSATNCGg92 oeisZuFUNGuPjlg+Es3uGNljqxJ464zS9SrBtANrwvHbsqtkUDSKa3/OQHdWi1z4MJnK hRTlto+Zu+9dJIAVa388mgAVHFbAMU/vD+bdZZjrh99cX7Bl4wjRjJP/V5GK2jxWZypS 5Ikg== X-Gm-Message-State: AOAM533Ke72lzE5n0NPyZMNXFDhTJqrpZIKPovdqDXq+emDw7dOJED/t 1JCNhX0w8kTC/ZItFe56QXo= X-Google-Smtp-Source: ABdhPJyZgc6J3PJapwYvBcgEEKZ/Jerd++aLCQoky0Jcr64DLrgfwsKC+jhHtu9KLPZdgvdP4/NUvA== X-Received: by 2002:a2e:948:: with SMTP id 69mr15645160ljj.82.1639664692137; Thu, 16 Dec 2021 06:24:52 -0800 (PST) Received: from [192.168.2.145] (94-29-63-156.dynamic.spd-mgts.ru. [94.29.63.156]) by smtp.googlemail.com with ESMTPSA id a12sm896315lfk.227.2021.12.16.06.24.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Dec 2021 06:24:51 -0800 (PST) Subject: Re: [PATCH v4 20/22] ARM: tegra: Add HDMI audio graph to Tegra20 device-tree To: Thierry Reding References: <20211204143725.31646-1-digetx@gmail.com> <20211204143725.31646-21-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <7cc2693f-df2d-b3ca-5336-4815d98a67cb@gmail.com> Date: Thu, 16 Dec 2021 17:24:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Rob Herring , Mark Brown , dri-devel@lists.freedesktop.org, Agneli , linux-tegra@vger.kernel.org, Jonathan Hunter X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" 16.12.2021 16:46, Thierry Reding пишет: > On Sat, Dec 04, 2021 at 05:37:23PM +0300, Dmitry Osipenko wrote: >> Add HDMI audio graph to Tegra20 device-tree to enable HDMI audio on >> Tegra20 devices. >> >> Signed-off-by: Dmitry Osipenko >> --- >> arch/arm/boot/dts/tegra20.dtsi | 22 +++++++++++++++++++++- >> 1 file changed, 21 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >> index 72cbe32d0c1d..dde228bcbbff 100644 >> --- a/arch/arm/boot/dts/tegra20.dtsi >> +++ b/arch/arm/boot/dts/tegra20.dtsi >> @@ -186,7 +186,7 @@ rgb { >> }; >> }; >> >> - hdmi@54280000 { >> + tegra_hdmi: hdmi@54280000 { >> compatible = "nvidia,tegra20-hdmi"; >> reg = <0x54280000 0x00040000>; >> interrupts = ; >> @@ -1063,4 +1063,24 @@ pmu { >> interrupt-affinity = <&{/cpus/cpu@0}>, >> <&{/cpus/cpu@1}>; >> }; >> + >> + sound-hdmi { >> + compatible = "simple-audio-card"; >> + simple-audio-card,name = "NVIDIA Tegra20 HDMI"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + simple-audio-card,dai-link@0 { >> + reg = <0>; >> + >> + cpu { >> + sound-dai = <&tegra_spdif>; >> + }; >> + >> + codec { >> + sound-dai = <&tegra_hdmi>; >> + }; >> + }; >> + }; > > Should this be status = "disabled" and then only enabled for platforms > that actually enable HDMI? Assuming that HDMI node is disabled, we assume that the card won't be initialized. It won't be a problem to restructure this card in DT later on if we will have any other use-cases than we currently have, but this is unlikely to happen in practice. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7706BC433EF for ; Thu, 16 Dec 2021 14:24:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237922AbhLPOYy (ORCPT ); Thu, 16 Dec 2021 09:24:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbhLPOYy (ORCPT ); Thu, 16 Dec 2021 09:24:54 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D97C061574; Thu, 16 Dec 2021 06:24:53 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id u22so38732254lju.7; Thu, 16 Dec 2021 06:24:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3te9pe7rOJHos3EuPgW4pF2bDr58GHICUC52sb6TTQw=; b=igVil4d7hecRf/ZlSHkjGruHgf+4OOe4/KwyAc3HNyI/F2/EASnbWlmBW1xTb9kyIf LCsjrURmGl04f3eT9XO2PC7S7qc7QHJF7vXVdsW221Oir2aAxMMhWcEDjv3yX9WDczqV ZDS/IvjvPnck+FzEw10c7WJJf3Hs1whJzcS4oMZEwL83kIugA95UTue+8vljF7orSw/F W1pN26OniH5nNBEyrLvvldgEsL7ZcXLfrgZgfW/+EJCzdM179Fnek2baPlSqDFWaJuu5 R2hxrJEuFfzP88gWkIzimlDjZBs6i7mip18yIbHvCl3zFmfzJdLvHKsnANZ9IEim+FqC +aZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3te9pe7rOJHos3EuPgW4pF2bDr58GHICUC52sb6TTQw=; b=3u6oU+SIT2NvO14nNK86ndpl5Uz+kufgoj8KnNh33RabfG5b8AJl6/9RE6oUYPcB6f NCTXf28/9dRU1BJ9baxj17uhhX4mN4Mn+ElrniqeUj4xAJvbjcpGCfxpx6voQzFFefJN 8g/k2ehbO7fZgx8UUyF9bB6dm6VyZKRJFhSWEnp9qrOiKEtoCmUVdxG7kbnWRepObcB1 ndphNIeDlgeHgCvk6Ur4r0gJ/ZmB/DLOpVcjXH9/l+9DMEVJRlVSLLgtsVP3T9LvsEsH GSUP8sIND1YVxeNKlehH2W8dwEahvQG+kfblCYKjqGT+OEWAxWUYxWuGjQ6CEocrgXm+ R6rQ== X-Gm-Message-State: AOAM532b9toFQPV126tPw7RK6d7IMgS1jUBjA97rWsgH5PFSHj7kqN+O 8yN1+aAzKCuD0X0SdpneZfk= X-Google-Smtp-Source: ABdhPJyZgc6J3PJapwYvBcgEEKZ/Jerd++aLCQoky0Jcr64DLrgfwsKC+jhHtu9KLPZdgvdP4/NUvA== X-Received: by 2002:a2e:948:: with SMTP id 69mr15645160ljj.82.1639664692137; Thu, 16 Dec 2021 06:24:52 -0800 (PST) Received: from [192.168.2.145] (94-29-63-156.dynamic.spd-mgts.ru. [94.29.63.156]) by smtp.googlemail.com with ESMTPSA id a12sm896315lfk.227.2021.12.16.06.24.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Dec 2021 06:24:51 -0800 (PST) Subject: Re: [PATCH v4 20/22] ARM: tegra: Add HDMI audio graph to Tegra20 device-tree To: Thierry Reding Cc: Jonathan Hunter , Mark Brown , Takashi Iwai , Jaroslav Kysela , Liam Girdwood , Agneli , linux-tegra@vger.kernel.org, Arnd Bergmann , Rob Herring , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20211204143725.31646-1-digetx@gmail.com> <20211204143725.31646-21-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <7cc2693f-df2d-b3ca-5336-4815d98a67cb@gmail.com> Date: Thu, 16 Dec 2021 17:24:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 16.12.2021 16:46, Thierry Reding пишет: > On Sat, Dec 04, 2021 at 05:37:23PM +0300, Dmitry Osipenko wrote: >> Add HDMI audio graph to Tegra20 device-tree to enable HDMI audio on >> Tegra20 devices. >> >> Signed-off-by: Dmitry Osipenko >> --- >> arch/arm/boot/dts/tegra20.dtsi | 22 +++++++++++++++++++++- >> 1 file changed, 21 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >> index 72cbe32d0c1d..dde228bcbbff 100644 >> --- a/arch/arm/boot/dts/tegra20.dtsi >> +++ b/arch/arm/boot/dts/tegra20.dtsi >> @@ -186,7 +186,7 @@ rgb { >> }; >> }; >> >> - hdmi@54280000 { >> + tegra_hdmi: hdmi@54280000 { >> compatible = "nvidia,tegra20-hdmi"; >> reg = <0x54280000 0x00040000>; >> interrupts = ; >> @@ -1063,4 +1063,24 @@ pmu { >> interrupt-affinity = <&{/cpus/cpu@0}>, >> <&{/cpus/cpu@1}>; >> }; >> + >> + sound-hdmi { >> + compatible = "simple-audio-card"; >> + simple-audio-card,name = "NVIDIA Tegra20 HDMI"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + simple-audio-card,dai-link@0 { >> + reg = <0>; >> + >> + cpu { >> + sound-dai = <&tegra_spdif>; >> + }; >> + >> + codec { >> + sound-dai = <&tegra_hdmi>; >> + }; >> + }; >> + }; > > Should this be status = "disabled" and then only enabled for platforms > that actually enable HDMI? Assuming that HDMI node is disabled, we assume that the card won't be initialized. It won't be a problem to restructure this card in DT later on if we will have any other use-cases than we currently have, but this is unlikely to happen in practice. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1619C4332F for ; Thu, 16 Dec 2021 14:24:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C8DD9112283; Thu, 16 Dec 2021 14:24:55 +0000 (UTC) Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20A21112280 for ; Thu, 16 Dec 2021 14:24:54 +0000 (UTC) Received: by mail-lj1-x22a.google.com with SMTP id v15so38866239ljc.0 for ; Thu, 16 Dec 2021 06:24:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=3te9pe7rOJHos3EuPgW4pF2bDr58GHICUC52sb6TTQw=; b=igVil4d7hecRf/ZlSHkjGruHgf+4OOe4/KwyAc3HNyI/F2/EASnbWlmBW1xTb9kyIf LCsjrURmGl04f3eT9XO2PC7S7qc7QHJF7vXVdsW221Oir2aAxMMhWcEDjv3yX9WDczqV ZDS/IvjvPnck+FzEw10c7WJJf3Hs1whJzcS4oMZEwL83kIugA95UTue+8vljF7orSw/F W1pN26OniH5nNBEyrLvvldgEsL7ZcXLfrgZgfW/+EJCzdM179Fnek2baPlSqDFWaJuu5 R2hxrJEuFfzP88gWkIzimlDjZBs6i7mip18yIbHvCl3zFmfzJdLvHKsnANZ9IEim+FqC +aZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=3te9pe7rOJHos3EuPgW4pF2bDr58GHICUC52sb6TTQw=; b=mrK2PeEatPMoNcDA8uOakIpYJEu+FY9nKJAIQHhVkiLaeDSoGTAHvOdKZ+c4Apkf/V 6ixfoyrn662vpieVhHN5v/FTH7PLXKh9X7qrZMFFlQjPSV1JuqlJGS+b4bvLdEJ+PUF6 kQiaAKhJfONtpKMyKxpTmW16m/+5iNCWwkFnLhJtfcYwBgT/saw0keG+7rYsUWfA2Led 6dFePZY5yVyc34QntZqjNb96vZvpZo8K11XyZyKmbSv8nQqH2JxpGTcWzmWJvaB89FWU 4EWMk2eRQpcKDPOKvZWaLLINYJnkrcvp40CdanHkrMaov9H8afKqiCdFMFvzzPF9Yqe4 d+9Q== X-Gm-Message-State: AOAM533O2MMqyId5wry0G75g2rlUAYSHDIoLS2FfpzEnLuPJXCPn4g+Y DWwYVdnrtM+1kmm2EwGn/tlxDT+6Im8= X-Google-Smtp-Source: ABdhPJyZgc6J3PJapwYvBcgEEKZ/Jerd++aLCQoky0Jcr64DLrgfwsKC+jhHtu9KLPZdgvdP4/NUvA== X-Received: by 2002:a2e:948:: with SMTP id 69mr15645160ljj.82.1639664692137; Thu, 16 Dec 2021 06:24:52 -0800 (PST) Received: from [192.168.2.145] (94-29-63-156.dynamic.spd-mgts.ru. [94.29.63.156]) by smtp.googlemail.com with ESMTPSA id a12sm896315lfk.227.2021.12.16.06.24.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Dec 2021 06:24:51 -0800 (PST) Subject: Re: [PATCH v4 20/22] ARM: tegra: Add HDMI audio graph to Tegra20 device-tree To: Thierry Reding References: <20211204143725.31646-1-digetx@gmail.com> <20211204143725.31646-21-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <7cc2693f-df2d-b3ca-5336-4815d98a67cb@gmail.com> Date: Thu, 16 Dec 2021 17:24:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Arnd Bergmann , linux-kernel@vger.kernel.org, Takashi Iwai , Liam Girdwood , Rob Herring , Jaroslav Kysela , Mark Brown , dri-devel@lists.freedesktop.org, Agneli , linux-tegra@vger.kernel.org, Jonathan Hunter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 16.12.2021 16:46, Thierry Reding пишет: > On Sat, Dec 04, 2021 at 05:37:23PM +0300, Dmitry Osipenko wrote: >> Add HDMI audio graph to Tegra20 device-tree to enable HDMI audio on >> Tegra20 devices. >> >> Signed-off-by: Dmitry Osipenko >> --- >> arch/arm/boot/dts/tegra20.dtsi | 22 +++++++++++++++++++++- >> 1 file changed, 21 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi >> index 72cbe32d0c1d..dde228bcbbff 100644 >> --- a/arch/arm/boot/dts/tegra20.dtsi >> +++ b/arch/arm/boot/dts/tegra20.dtsi >> @@ -186,7 +186,7 @@ rgb { >> }; >> }; >> >> - hdmi@54280000 { >> + tegra_hdmi: hdmi@54280000 { >> compatible = "nvidia,tegra20-hdmi"; >> reg = <0x54280000 0x00040000>; >> interrupts = ; >> @@ -1063,4 +1063,24 @@ pmu { >> interrupt-affinity = <&{/cpus/cpu@0}>, >> <&{/cpus/cpu@1}>; >> }; >> + >> + sound-hdmi { >> + compatible = "simple-audio-card"; >> + simple-audio-card,name = "NVIDIA Tegra20 HDMI"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + simple-audio-card,dai-link@0 { >> + reg = <0>; >> + >> + cpu { >> + sound-dai = <&tegra_spdif>; >> + }; >> + >> + codec { >> + sound-dai = <&tegra_hdmi>; >> + }; >> + }; >> + }; > > Should this be status = "disabled" and then only enabled for platforms > that actually enable HDMI? Assuming that HDMI node is disabled, we assume that the card won't be initialized. It won't be a problem to restructure this card in DT later on if we will have any other use-cases than we currently have, but this is unlikely to happen in practice.