From: Marek Vasut <marex@denx.de>
To: "Abbarapu, Venkatesh" <venkatesh.abbarapu@amd.com>,
"u-boot@lists.denx.de" <u-boot@lists.denx.de>,
"tudor.ambarus@linaro.org" <tudor.ambarus@linaro.org>,
"j-humphreys@ti.com" <j-humphreys@ti.com>
Cc: "Simek, Michal" <michal.simek@amd.com>,
"jagan@amarulasolutions.com" <jagan@amarulasolutions.com>,
"vigneshr@ti.com" <vigneshr@ti.com>,
"u-kumar1@ti.com" <u-kumar1@ti.com>,
"trini@konsulko.com" <trini@konsulko.com>,
"seanga2@gmail.com" <seanga2@gmail.com>,
"caleb.connolly@linaro.org" <caleb.connolly@linaro.org>,
"sjg@chromium.org" <sjg@chromium.org>,
"william.zhang@broadcom.com" <william.zhang@broadcom.com>,
"stefan_b@posteo.net" <stefan_b@posteo.net>,
"quentin.schulz@cherry.de" <quentin.schulz@cherry.de>,
"Takahiro.Kuwano@infineon.com" <Takahiro.Kuwano@infineon.com>,
"p-mantena@ti.com" <p-mantena@ti.com>,
"git (AMD-Xilinx)" <git@amd.com>
Subject: Re: [PATCH v2] mtd: spi-nor: Fix the spi_nor_read() when config SPI_STACKED_PARALLEL is enabled
Date: Wed, 18 Dec 2024 14:58:09 +0100 [thread overview]
Message-ID: <7cef71fc-7d7f-4c9f-b28c-e2b1ab893f75@denx.de> (raw)
In-Reply-To: <SA1PR12MB86975AD9D85A5F7865FF4AFD98052@SA1PR12MB8697.namprd12.prod.outlook.com>
On 12/18/24 10:22 AM, Abbarapu, Venkatesh wrote:
>>>>> For parallel/stacked configuration and address width the
>>>>> "rem_bank_len" will vary
>>>> and as we don't want to disturb the default read functionality added
>>>> the ifdef separately.
>>>> What would happen if both SPI_FLASH_BAR and SPI_STACKED_PARALLEL
>> are
>>>> enabled on a system that only has one SPI NOR attached
>>>> (non-stacked/parallel) ? I noticed the second "copy" of the code
>>>> behaves slightly differently in the else branch, so does that mean this would
>> break such setup ?
>>>
>>> If both SPI_FLASH_BAR and SPI_STACKED_PARALLEL are enabled, the
>> "rem_bank_len" manipulation is done under the
>> CONFIG_IS_ENABLED(SPI_STACKED_PARALLEL) code and this won't break any
>> default functionality.
>> Wouldn't read_len calculation be done twice ?
> Yes. As "rem_bank_len" will be changed based on parallel configuration, so added the additional code copy to not break the default code.
Can you please also update it to avoid the code duplication ?
Thank you
next prev parent reply other threads:[~2024-12-18 15:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-11 12:06 [PATCH v2] mtd: spi-nor: Fix the spi_nor_read() when config SPI_STACKED_PARALLEL is enabled Venkatesh Yadav Abbarapu
2024-12-12 20:14 ` Jon Humphreys
2024-12-15 23:50 ` Marek Vasut
2024-12-16 4:16 ` Abbarapu, Venkatesh
2024-12-16 10:35 ` Marek Vasut
2024-12-16 13:58 ` Abbarapu, Venkatesh
2024-12-18 1:09 ` Marek Vasut
2024-12-18 9:22 ` Abbarapu, Venkatesh
2024-12-18 13:58 ` Marek Vasut [this message]
2024-12-19 4:21 ` Abbarapu, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7cef71fc-7d7f-4c9f-b28c-e2b1ab893f75@denx.de \
--to=marex@denx.de \
--cc=Takahiro.Kuwano@infineon.com \
--cc=caleb.connolly@linaro.org \
--cc=git@amd.com \
--cc=j-humphreys@ti.com \
--cc=jagan@amarulasolutions.com \
--cc=michal.simek@amd.com \
--cc=p-mantena@ti.com \
--cc=quentin.schulz@cherry.de \
--cc=seanga2@gmail.com \
--cc=sjg@chromium.org \
--cc=stefan_b@posteo.net \
--cc=trini@konsulko.com \
--cc=tudor.ambarus@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=u-kumar1@ti.com \
--cc=venkatesh.abbarapu@amd.com \
--cc=vigneshr@ti.com \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.