From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A4E00C636D4 for ; Wed, 1 Feb 2023 21:07:47 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BCF2A1FE; Wed, 1 Feb 2023 22:06:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BCF2A1FE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1675285664; bh=iRKnL0h2vDqLOR7wwetQc+wVcIvEQsrF0Mp7+5R7hA4=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=lv37L2K98xHtd+vJTDxLED64LUp2a//ZnqvZyzO/z2Y1dSmHZbOVTqmZ2FUhotXFl SQfYmXENDh7JF7sWnarXuxHrB+E3bKaerdUxkuhYp7F+HukNx21cVe9EwBE1csxkQJ beFoVJoKM7MEor0BBHxIJDrj1gEcnaf3LQPNBntc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B1857F8032B; Wed, 1 Feb 2023 22:06:53 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4B8FAF80423; Wed, 1 Feb 2023 22:06:52 +0100 (CET) Received: from esa2.hgst.iphmx.com (esa2.hgst.iphmx.com [68.232.143.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 03E6AF80155 for ; Wed, 1 Feb 2023 22:06:38 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 03E6AF80155 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=Yw90Ep8l; dkim=pass (2048-bit key, unprotected) header.d=opensource.wdc.com header.i=@opensource.wdc.com header.a=rsa-sha256 header.s=dkim header.b=V8ZS818B DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1675285601; x=1706821601; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=iRKnL0h2vDqLOR7wwetQc+wVcIvEQsrF0Mp7+5R7hA4=; b=Yw90Ep8lppjZVhvd40NR18aPlxYQ6PmQG6Vvm/knzM117FgoabZuyu+m 7PFXByJ2jX11rbTJ5XyVUG41Ltw3nuDN9Va8TO2MjbvY6kiJ+UJNeDWOp 6gdOwMdixH6p2IYrqeKxsV6p0oxAJkWzwxLIrv9fAnBzIkxqHbHEiPDEI eLVdkd7usyzdyEou2rWnYmx7IitEJlanpxm8h76wRroD6tvp8wsK6Rq5A pUMq0R2EK9yP4IWU0CyiOGaP+ta7JQ+tIC0/hJQcpP3CKhQSowrEQvTKO AMJku3lLtiLXZOPghRDlB2BKPmKyiia5uxasi9ZqiLL29ZrAGyBQa/Pe4 Q==; X-IronPort-AV: E=Sophos;i="5.97,265,1669046400"; d="scan'208";a="326598428" Received: from h199-255-45-15.hgst.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 02 Feb 2023 05:06:29 +0800 IronPort-SDR: 3tQMIRbpkYEtPELahjbt/UgpIxtx3sZ1qdwAZL3ec9WQ0n6DNq5ebTORzOIsbI/76ciHAps6Wx DtNoIYfBsXdxmcoUclKsqBBkt1NnmXyE4+hxPIt9EqV5U0LUT65s2V6NQ70Hy1H53/BvbFTmpX 7/XTpxzGuSZ8ZPydktOwT+N4Ma4P4ookrSuUvBmksGqBIMGfK5OHCSKjqzXdPENOSeqS1fhcbY GwQE2g1N/5XQ88RXx+u647/MmjKH144zmf6aLz7DITnAY0/Q60CtZ14cqKuEtY7Hq/uV6QZawn lys= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2023 12:18:08 -0800 IronPort-SDR: HsVGArOQMMhKreSy8Iihvc8vLmA3IObI4E4mhBZKdW7u3PIk5Scko3IFyiiE6+2yKGHy1Oo0t9 9YkdbGHvLMyfLVxuhfHd5G2Jwd5TFD8G7gbWSsD/YjNZC/GlYqmK9LNW1yL7OsFgykrslup401 5S7/5gHPakC+3gmVg/fmWzFzlRk2cy3uyNHSbic2id9WuXg5SwL9yLxJNbjy1YJKOUNNBbz0sz z5sdT8dtf+zKpUENOVSz/lRh9u6FVqQe+ATndvZvCTD6WBB1idnl2vaNaGW4DgNviulsZnkp63 3yc= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2023 13:06:29 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4P6ZGY0cq9z1RvTp for ; Wed, 1 Feb 2023 13:06:29 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1675285588; x=1677877589; bh=iRKnL0h2vDqLOR7wwetQc+wVcIvEQsrF0Mp 7+5R7hA4=; b=V8ZS818BsRUL1nCwybqdEYTe8Wx0WBi6qOXAxFoZKbXfCBwwWFf VOosxalLJs4cfWKySVQbx1ZrLB5YonTFBaoj/OLDVfT8cUBJ8bD5tiSE5hzQ46RF TEakRsy3ipmA2B41lBPZ393WOLeL83l8wWtcOnR/4nSLayBR+cXU60TKUAZZkqU3 m9id8XIALxEB+iWm2k7m3TXJnm913IifTzv30TSMO2LexFx2Yy+QwW5uL0PLMTEh vHlfWflhhZbCIVwDj00GWrUNQ6CJKTuSmUOhYwjGnWlId5TVTF+fr24Bl74RV9QG GmSDm/bX8s7qZ+Mjsw8eY/3NXzRSKvHjbdA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WUeuaLStLhp0 for ; Wed, 1 Feb 2023 13:06:28 -0800 (PST) Received: from [10.225.163.79] (unknown [10.225.163.79]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4P6ZGV4bwJz1RvLy; Wed, 1 Feb 2023 13:06:26 -0800 (PST) Message-ID: <7cf17a27-13dc-e6b4-c34c-47454239af30@opensource.wdc.com> Date: Thu, 2 Feb 2023 06:06:25 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned Content-Language: en-US To: Dawei Li , mpe@ellerman.id.au References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, christophe.leroy@csgroup.eu, linux-ide@vger.kernel.org, npiggin@gmail.com, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 2/1/23 23:36, Dawei Li wrote: > Commit fc7a6209d571 ("bus: Make remove callback return void") forces > bus_type::remove be void-returned, it doesn't make much sense for any > bus based driver implementing remove callbalk to return non-void to > its caller. > > This change is for macio bus based drivers. > > Signed-off-by: Dawei Li > --- > v2 -> v3 > - Rebased on latest powerpc/next. > - cc' to relevant subsysem lists. > > v1 -> v2 > - Revert unneeded changes. > - Rebased on latest powerpc/next. > > v1 > - https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/ > --- > arch/powerpc/include/asm/macio.h | 2 +- > drivers/ata/pata_macio.c | 4 +--- > drivers/macintosh/rack-meter.c | 4 +--- > drivers/net/ethernet/apple/bmac.c | 4 +--- > drivers/net/ethernet/apple/mace.c | 4 +--- > drivers/net/wireless/intersil/orinoco/airport.c | 4 +--- > drivers/scsi/mac53c94.c | 5 +---- > drivers/scsi/mesh.c | 5 +---- > drivers/tty/serial/pmac_zilog.c | 7 ++----- > sound/aoa/soundbus/i2sbus/core.c | 4 +--- > 10 files changed, 11 insertions(+), 32 deletions(-) For the ata bits: Acked-by: Damien Le Moal -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0BB6C636D4 for ; Wed, 1 Feb 2023 21:06:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231731AbjBAVGh (ORCPT ); Wed, 1 Feb 2023 16:06:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231614AbjBAVGd (ORCPT ); Wed, 1 Feb 2023 16:06:33 -0500 Received: from esa6.hgst.iphmx.com (esa6.hgst.iphmx.com [216.71.154.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 527916DFC9 for ; Wed, 1 Feb 2023 13:06:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1675285590; x=1706821590; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=iRKnL0h2vDqLOR7wwetQc+wVcIvEQsrF0Mp7+5R7hA4=; b=h7s5KrF9z59Ya/DfLyHy36chPuJOj0NYjb24DK35Eepv27PA4CDsrs2D u01bkbxfukVC5aU0omiOYnKZWE7C37FgEHHew4OAf6gx8RhVVUzuu1lfQ eHfl/sBR0Bmm9ySc2AEdcXT0f3P01M3os+V8ZYJfUQ2qC54rp88CJchB1 fXQ1Zhv3F0AxXhIn8wKVIAGJKyGWJwfSh+/LTpxu6hbIjH/h7bkCeTqSh xC4nuJsC/hTzfNiyl/3CNvwvUI7OwxzHwBUIagD5z6AX+8JT4ASXlldGL gK5nppYkhkpslB9OsFkiaa+nHPxqX/lVZdB6fhBzcJx6XqTAP9ctu7F+a Q==; X-IronPort-AV: E=Sophos;i="5.97,265,1669046400"; d="scan'208";a="222354875" Received: from uls-op-cesaip02.wdc.com (HELO uls-op-cesaep02.wdc.com) ([199.255.45.15]) by ob1.hgst.iphmx.com with ESMTP; 02 Feb 2023 05:06:29 +0800 IronPort-SDR: aaE6glIN/XZcx6zAhp1B3Tyle0BHzwUxQiCKWIL7ebTA1mTUG0inmf5GFzj9uAu3qb77AdM10C j00Iizg3mSmJlw0Wn4dS4ScrT5DEY74XaCFJSKDGFdhmscDnUTAWvwSjFmF3j1zTvs7K1xzj73 ZVCTMW20bTAIjv1HGaqMB9YIoVrt+/jIvUjRcuCHk5Ha+vmPkAnKdEYqTGZJ2thkKfgH5YfqbV 4e+CGDUjqCqpT5oYs2dutZHDmS2iTGAMSyI+XADu/3nL2Naf3ih848QM6LM8RiLWTs/ELP//BR K4I= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2023 12:18:08 -0800 IronPort-SDR: ZF/MND1F9YpaWHbqqjQgXMwdta4URDlTV5X0v5rjMWJ0ksQBe5/q8InEsvhcRDWwwyFmTR5IBS oO8C8wh4VjLVBhv6RQMQ5MEfsHMNy0q9odiZN66rW+yGx6rP6vqrOHpzjW8qR9pqy+cnLB/Xc3 QyKogwtqCvljXLGoVAReYJ5L0GL4gosZXkpKIxsM/F6ILWoqcsDWCbIcpcaNp4BXPoMzPy6dYb 6q7uABZV9N6r7iDG7LTH78HzvzYzX2b4FXAHIa8QACdBpqztaIEtFZrMmua5ZIydn3Kmr4UvtG tBA= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2023 13:06:29 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4P6ZGY1Lcxz1RwqL for ; Wed, 1 Feb 2023 13:06:29 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1675285588; x=1677877589; bh=iRKnL0h2vDqLOR7wwetQc+wVcIvEQsrF0Mp 7+5R7hA4=; b=V8ZS818BsRUL1nCwybqdEYTe8Wx0WBi6qOXAxFoZKbXfCBwwWFf VOosxalLJs4cfWKySVQbx1ZrLB5YonTFBaoj/OLDVfT8cUBJ8bD5tiSE5hzQ46RF TEakRsy3ipmA2B41lBPZ393WOLeL83l8wWtcOnR/4nSLayBR+cXU60TKUAZZkqU3 m9id8XIALxEB+iWm2k7m3TXJnm913IifTzv30TSMO2LexFx2Yy+QwW5uL0PLMTEh vHlfWflhhZbCIVwDj00GWrUNQ6CJKTuSmUOhYwjGnWlId5TVTF+fr24Bl74RV9QG GmSDm/bX8s7qZ+Mjsw8eY/3NXzRSKvHjbdA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id tuAA8zZaF9U0 for ; Wed, 1 Feb 2023 13:06:28 -0800 (PST) Received: from [10.225.163.79] (unknown [10.225.163.79]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4P6ZGV4bwJz1RvLy; Wed, 1 Feb 2023 13:06:26 -0800 (PST) Message-ID: <7cf17a27-13dc-e6b4-c34c-47454239af30@opensource.wdc.com> Date: Thu, 2 Feb 2023 06:06:25 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned Content-Language: en-US To: Dawei Li , mpe@ellerman.id.au Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu, linuxppc-dev@lists.ozlabs.org, linux-ide@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-ide@vger.kernel.org On 2/1/23 23:36, Dawei Li wrote: > Commit fc7a6209d571 ("bus: Make remove callback return void") forces > bus_type::remove be void-returned, it doesn't make much sense for any > bus based driver implementing remove callbalk to return non-void to > its caller. > > This change is for macio bus based drivers. > > Signed-off-by: Dawei Li > --- > v2 -> v3 > - Rebased on latest powerpc/next. > - cc' to relevant subsysem lists. > > v1 -> v2 > - Revert unneeded changes. > - Rebased on latest powerpc/next. > > v1 > - https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/ > --- > arch/powerpc/include/asm/macio.h | 2 +- > drivers/ata/pata_macio.c | 4 +--- > drivers/macintosh/rack-meter.c | 4 +--- > drivers/net/ethernet/apple/bmac.c | 4 +--- > drivers/net/ethernet/apple/mace.c | 4 +--- > drivers/net/wireless/intersil/orinoco/airport.c | 4 +--- > drivers/scsi/mac53c94.c | 5 +---- > drivers/scsi/mesh.c | 5 +---- > drivers/tty/serial/pmac_zilog.c | 7 ++----- > sound/aoa/soundbus/i2sbus/core.c | 4 +--- > 10 files changed, 11 insertions(+), 32 deletions(-) For the ata bits: Acked-by: Damien Le Moal -- Damien Le Moal Western Digital Research From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DDB9C636D4 for ; Wed, 1 Feb 2023 21:08:40 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P6ZK24yKGz3f64 for ; Thu, 2 Feb 2023 08:08:38 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=dySxpDQ3; dkim=pass (2048-bit key; unprotected) header.d=opensource.wdc.com header.i=@opensource.wdc.com header.a=rsa-sha256 header.s=dkim header.b=V8ZS818B; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=opensource.wdc.com (client-ip=68.232.141.245; helo=esa1.hgst.iphmx.com; envelope-from=prvs=389e0ffe8=damien.lemoal@opensource.wdc.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=wdc.com header.i=@wdc.com header.a=rsa-sha256 header.s=dkim.wdc.com header.b=dySxpDQ3; dkim=pass (2048-bit key; unprotected) header.d=opensource.wdc.com header.i=@opensource.wdc.com header.a=rsa-sha256 header.s=dkim header.b=V8ZS818B; dkim-atps=neutral X-Greylist: delayed 63 seconds by postgrey-1.36 at boromir; Thu, 02 Feb 2023 08:07:39 AEDT Received: from esa1.hgst.iphmx.com (esa1.hgst.iphmx.com [68.232.141.245]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P6ZHv31fmz30F7 for ; Thu, 2 Feb 2023 08:07:39 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1675285659; x=1706821659; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=iRKnL0h2vDqLOR7wwetQc+wVcIvEQsrF0Mp7+5R7hA4=; b=dySxpDQ3Rtbkh9i2SX1DMMKJtFhnJJuj/HvvL1z+iVnynag6uWtIuLOg fnu8/nH4vo6VcP3FPBYVPZoP0k2ZWsSoUydCNQ2lxshkMB3HpxMtt0Fpw HayFPYnFSLUh7W+I+ZESruuWzCtuDy5K2khtkc20RZKit3l1IULnau1NS lOQ1kkywe9BmZB443TDqy/x82LaI0ywv0h7Y8iOtDt7I4/qZixdjswTEc o7XuIj16LjGD74M3YVE/UaAX3m31WHfN881KL6XBuYYh9o2iv67LxFMWu q6OxoO7rmVHGfiSP6hQeG7dLkm1kalpJ/XJ64XalrKtFrk1O9cLxN39ns A==; X-IronPort-AV: E=Sophos;i="5.97,265,1669046400"; d="scan'208";a="334269083" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 02 Feb 2023 05:06:29 +0800 IronPort-SDR: 9Spy/sWxB9BK54sy7SUqVm+PdtIt7zC3S4aVCb/uUibQLnfMqP3eGjGXHJY2178UuVcIv1qmkD Bb0PB2y4C7tu+bMwUpo+9rygW5s3mnt/e2UqSsylFQP74o+DDaE5iIQsZsDWXqq53JmVtyaUWV rlKfhlv+mdjXDuNMQ9GA2Hrzjzq1xEaU+YjBSAulJ9Zmzivlp6AEzGXjOPAnLpSjEq89Q7Xzec 1421Qto7Fx+Wnj/fZsHJABcTCHj5/BgcBciaUjYJvvWONo2MJlxRynJSxgNTIhFprF/ZIsHtyf 2FM= Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2023 12:23:52 -0800 IronPort-SDR: PBohHU/NYIru7rzh048F5eNbPE1dzW8B3teO4WIdfFX2jyUBxA7Cg07mWauOXV27NgjNcV94lt oh1sV5q9XORkCMeACl4T6yMQwG7s8NwYv9hz0KRVQgtPtI1w6n4wfO0ENGdqczuTOyGNwmbd2k XvN8phXMjrgXO7Sf6K1GVvthoFyYsbiNJ/FHJjWuPmDUV/dBFg6pYi+5oP5aAUUMlQUTyaALg4 OsyCNaTKXpIz7CGC4WkPlBtoc1fjzt39C+TP3+zg3bxxfbsk4e/fTptknc+e8V+YldPqZDtudG nks= WDCIronportException: Internal Received: from usg-ed-osssrv.wdc.com ([10.3.10.180]) by uls-op-cesaip02.wdc.com with ESMTP/TLS/ECDHE-RSA-AES128-GCM-SHA256; 01 Feb 2023 13:06:29 -0800 Received: from usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTP id 4P6ZGY2HBgz1RwtC for ; Wed, 1 Feb 2023 13:06:29 -0800 (PST) Authentication-Results: usg-ed-osssrv.wdc.com (amavisd-new); dkim=pass reason="pass (just generated, assumed good)" header.d=opensource.wdc.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d= opensource.wdc.com; h=content-transfer-encoding:content-type :in-reply-to:organization:from:references:to:content-language :subject:user-agent:mime-version:date:message-id; s=dkim; t= 1675285588; x=1677877589; bh=iRKnL0h2vDqLOR7wwetQc+wVcIvEQsrF0Mp 7+5R7hA4=; b=V8ZS818BsRUL1nCwybqdEYTe8Wx0WBi6qOXAxFoZKbXfCBwwWFf VOosxalLJs4cfWKySVQbx1ZrLB5YonTFBaoj/OLDVfT8cUBJ8bD5tiSE5hzQ46RF TEakRsy3ipmA2B41lBPZ393WOLeL83l8wWtcOnR/4nSLayBR+cXU60TKUAZZkqU3 m9id8XIALxEB+iWm2k7m3TXJnm913IifTzv30TSMO2LexFx2Yy+QwW5uL0PLMTEh vHlfWflhhZbCIVwDj00GWrUNQ6CJKTuSmUOhYwjGnWlId5TVTF+fr24Bl74RV9QG GmSDm/bX8s7qZ+Mjsw8eY/3NXzRSKvHjbdA== X-Virus-Scanned: amavisd-new at usg-ed-osssrv.wdc.com Received: from usg-ed-osssrv.wdc.com ([127.0.0.1]) by usg-ed-osssrv.wdc.com (usg-ed-osssrv.wdc.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id icfu52oxIOro for ; Wed, 1 Feb 2023 13:06:28 -0800 (PST) Received: from [10.225.163.79] (unknown [10.225.163.79]) by usg-ed-osssrv.wdc.com (Postfix) with ESMTPSA id 4P6ZGV4bwJz1RvLy; Wed, 1 Feb 2023 13:06:26 -0800 (PST) Message-ID: <7cf17a27-13dc-e6b4-c34c-47454239af30@opensource.wdc.com> Date: Thu, 2 Feb 2023 06:06:25 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v3] powerpc: macio: Make remove callback of macio driver void returned Content-Language: en-US To: Dawei Li , mpe@ellerman.id.au References: From: Damien Le Moal Organization: Western Digital Research In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, npiggin@gmail.com, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 2/1/23 23:36, Dawei Li wrote: > Commit fc7a6209d571 ("bus: Make remove callback return void") forces > bus_type::remove be void-returned, it doesn't make much sense for any > bus based driver implementing remove callbalk to return non-void to > its caller. > > This change is for macio bus based drivers. > > Signed-off-by: Dawei Li > --- > v2 -> v3 > - Rebased on latest powerpc/next. > - cc' to relevant subsysem lists. > > v1 -> v2 > - Revert unneeded changes. > - Rebased on latest powerpc/next. > > v1 > - https://lore.kernel.org/all/TYCP286MB2323FCDC7ECD87F8D97CB74BCA189@TYCP286MB2323.JPNP286.PROD.OUTLOOK.COM/ > --- > arch/powerpc/include/asm/macio.h | 2 +- > drivers/ata/pata_macio.c | 4 +--- > drivers/macintosh/rack-meter.c | 4 +--- > drivers/net/ethernet/apple/bmac.c | 4 +--- > drivers/net/ethernet/apple/mace.c | 4 +--- > drivers/net/wireless/intersil/orinoco/airport.c | 4 +--- > drivers/scsi/mac53c94.c | 5 +---- > drivers/scsi/mesh.c | 5 +---- > drivers/tty/serial/pmac_zilog.c | 7 ++----- > sound/aoa/soundbus/i2sbus/core.c | 4 +--- > 10 files changed, 11 insertions(+), 32 deletions(-) For the ata bits: Acked-by: Damien Le Moal -- Damien Le Moal Western Digital Research