From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ka1Oi-0000qN-Ef for mharc-grub-devel@gnu.org; Tue, 03 Nov 2020 13:51:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:49990) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ka1Og-0000n8-NS for grub-devel@gnu.org; Tue, 03 Nov 2020 13:51:10 -0500 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]:42353) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ka1OZ-0001fv-TW for grub-devel@gnu.org; Tue, 03 Nov 2020 13:51:10 -0500 Received: by mail-ot1-x342.google.com with SMTP id h62so16921825oth.9 for ; Tue, 03 Nov 2020 10:51:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:message-id:in-reply-to:references:subject :mime-version:content-transfer-encoding; bh=WpuiZGeEKNFjNOqQPf4jPNf1pd6h5WLf2+MkW2ja3Ac=; b=n24JHeXZ8rlBISbKEQXBc4cLf22qIC96sFS6QFVvsuhMeGuf5uLfu0pwQVilufq5+6 hYPHAkuCJaHDarS4+E4zxlSdYqpZ8V8bk5HahyelvzRLZpK5B3RNc6p8p39gG246gDuo J0WcdCPx4BDy7g87LEGm+c3HnKk0n/Ld7VFpeM59XOR9aJKsfwUoJmDvhuXz0SZGZKje ltrrXSHtNB7QggyGSd009/f+EgGXg2CtAurPYV6ZorEh4EZG2SeyJtBFDtH8prMCbjWz 8q/85FgC/I3dS/3EwN93RzeRZA1meHNCkY0P8b0Cxk1hdOnhTuu59zRrKdkTgUjdWPWJ tXqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:message-id:in-reply-to :references:subject:mime-version:content-transfer-encoding; bh=WpuiZGeEKNFjNOqQPf4jPNf1pd6h5WLf2+MkW2ja3Ac=; b=tEo/ZgZLkkHCZj5gb63IjQv/pPyZCgEmL9qMDshQH3aZ48c/XTo+6gkhfiPCrdnFpa TyEgeP6NM1F/yuCrfpKB/bS8jupBZHsZnd8LgwtGx5htJgxwsA+0ycmAU3SPNnm5FRbt 2c1RH3EOMZdUIBBhjQeQnKDcke7y6iBGZW/qQ7yXSWwTuAk+A1B5Pt+AvWis+IB6sJtF 3we775Rahp9P0odoJmxCRK6xJKD5d/9R9yQFdwolbUAK8eakthcnXSzgjLjtgnQe+sZL IuSjYthG/6JL67EOSWGHWN7d6DnMiipiwLk2oXLJsJ6R0ZFrf4BHKxZlUvRU2mMyQa+h dF8Q== X-Gm-Message-State: AOAM530x5qz1FqzqEZ9ZLd4ZvEyaIBP/crqIEmw8eyRtREzuU8aQYP5g BuGKCv6tE3wv9JY+MqgQlKaPTn37mAIw/g== X-Google-Smtp-Source: ABdhPJwY0HERosV+7/ap+gzcDLuG0peQFGkqBmLDF1h45m25pSwg543HD7EMup5jHGCz6pXgsvzbKQ== X-Received: by 2002:a05:6830:22ed:: with SMTP id t13mr14940437otc.150.1604429462249; Tue, 03 Nov 2020 10:51:02 -0800 (PST) Received: from ?IPv6:::1? ([2806:103e:1d:44c7:ece2:4187:f0ae:ca36]) by smtp.gmail.com with ESMTPSA id l2sm4705162otl.67.2020.11.03.10.51.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2020 10:51:01 -0800 (PST) Date: Tue, 3 Nov 2020 18:50:56 +0000 (UTC) From: Glenn Washburn To: Daniel Kiper Cc: grub-devel@gnu.org, Patrick Steinhardt Message-ID: <7cfa134f-2ead-411d-8f8c-c9f07399a2af@efficientek.com> In-Reply-To: <20201102155652.hlzlj3ywjmp47azb@tomti.i.net-space.pl> References: <20201009100122.GH2088@tanuki> <20201027192513.gtrjl5koqgf5gxca@tomti.i.net-space.pl> <20201102155652.hlzlj3ywjmp47azb@tomti.i.net-space.pl> Subject: Re: [PATCH v3 00/10] Cryptodisk fixes for v2.06 redux MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Correlation-ID: <7cfa134f-2ead-411d-8f8c-c9f07399a2af@efficientek.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::342; envelope-from=development@efficientek.com; helo=mail-ot1-x342.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Nov 2020 18:51:11 -0000 Nov 2, 2020 9:56:58 AM Daniel Kiper : > On Tue, Oct 27, 2020 at 08:25:13PM +0100, Daniel Kiper wrote: >> On Mon, Oct 19, 2020 at 06:09:48PM -0500, Glenn Washburn wrote: >>> Heres an updated patch series which addresses comment from Patrick. The only >>> code change is adding a slot_key member to grub_luks2_keyslot and using that >>> instead of an extra out parameter to luks2_get_keyslot. >>> >>> Glenn Washburn (10): >>> luks2: Fix use of incorrect index and some grub_error() messages. >>> luks2: Improve readability in luks2_get_keyslot. >>> luks2: Use more intuitive keyslot key instead of index when naming >>> keyslot. >>> luks2: grub_cryptodisk_t->total_length is the max number of device >>> native sectors >>> cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'. >>> cryptodisk: Properly handle non-512 byte sized sectors. >>> cryptodisk: Replace some literals with constants in >>> grub_cryptodisk_endecrypt. >>> cryptodisk: Rename total_length field in grub_cryptodisk_t to >>> total_sectors. >>> cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors. >>> luks2: Rename source disk variabled named 'disk' to 'source' as in >>> luks.c. >> >> Most of LUKS2 patches require rework. The rest which got Patrick's and >> my RB I will push into the GRUB git repo by the end of this week. Of >> course if there are no objections... > > I was only able to take 'cryptodisk: Fix cipher IV mode "plain64" always > being set as "plain"' patch. The other patches depend on some changes in > earlier patches in the series. So, feel free to add my RB to the patches > which got it from me. > > Daniel > If I move the rework the rename patches to be earlier in the patch series, you should be able to get those in right? It's annoying to keep them in the patch series while reworking the other patches. Glenn