From: Liang, Kan <kan.liang@linux.intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [peterz-queue:perf/core 10/10] arch/x86/events/intel/uncore_snb.c:1111:36: warning: left shift count >= width of type
Date: Mon, 10 Feb 2020 13:23:49 -0500 [thread overview]
Message-ID: <7d121a07-658e-82dc-5a0e-ebc8e4f93486@linux.intel.com> (raw)
In-Reply-To: <20200210171542.GW302770@tassilo.jf.intel.com>
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On 2/10/2020 12:15 PM, Andi Kleen wrote:
>>
>> +#ifdef CONFIG_PHYS_ADDR_T_64BIT
>> pci_read_config_dword(pdev, SNB_UNCORE_PCI_IMC_BAR_OFFSET + 4, &mch_bar);
>> addr |= ((resource_size_t)mch_bar << 32);
>> +#endif
>
> Should really have a generic helper for this.
>
> I'm sure other drivers have the same problem.
The server uncore doesn't need to shift left 32. The warning should not
be triggered for server uncore.
Since both server and client uncore start to support MMIO type of uncore
unit, yes, a generic helper for mmio_init_box() looks better.
I will submit a clean up patch later.
Thanks,
Kan
prev parent reply other threads:[~2020-02-10 18:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-07 22:50 [peterz-queue:perf/core 10/10] arch/x86/events/intel/uncore_snb.c:1111:36: warning: left shift count >= width of type kbuild test robot
2020-02-09 16:20 ` Liang, Kan
2020-02-10 8:47 ` Peter Zijlstra
2020-02-10 13:14 ` Liang, Kan
2020-02-10 17:15 ` Andi Kleen
2020-02-10 18:23 ` Liang, Kan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d121a07-658e-82dc-5a0e-ebc8e4f93486@linux.intel.com \
--to=kan.liang@linux.intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.