From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6BCD9CD343A for ; Tue, 3 Sep 2024 14:27:57 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.789287.1198877 (Exim 4.92) (envelope-from ) id 1slUVZ-0002kW-IM; Tue, 03 Sep 2024 14:27:49 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 789287.1198877; Tue, 03 Sep 2024 14:27:49 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1slUVZ-0002kN-Em; Tue, 03 Sep 2024 14:27:49 +0000 Received: by outflank-mailman (input) for mailman id 789287; Tue, 03 Sep 2024 14:27:48 +0000 Received: from se1-gles-flk1-in.inumbo.com ([94.247.172.50] helo=se1-gles-flk1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1slUVY-0002jY-1f for xen-devel@lists.xenproject.org; Tue, 03 Sep 2024 14:27:48 +0000 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [2a00:1450:4864:20::62b]) by se1-gles-flk1.inumbo.com (Halon) with ESMTPS id b0364def-6a00-11ef-99a1-01e77a169b0f; Tue, 03 Sep 2024 16:27:46 +0200 (CEST) Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-a7a843bef98so552054066b.2 for ; Tue, 03 Sep 2024 07:27:46 -0700 (PDT) Received: from [10.125.226.166] ([185.25.67.249]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a8988feb32asm688581666b.23.2024.09.03.07.27.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2024 07:27:44 -0700 (PDT) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: b0364def-6a00-11ef-99a1-01e77a169b0f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=citrix.com; s=google; t=1725373666; x=1725978466; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=5ZRiA7pv2JEf0geeDpV/w6sgThpmDoyBtEknv+BKboA=; b=aeEML0ksPdbRKXEth6mBrOTRzZFYKdL06JH8AD3wuVm7FpkvyzEsAtw2XGIDD+rET8 X0j8VTAZ5qj2MR9CE454TMcAVyMnFox77/YVKvzwwKjGecXBp3PgtaIYWHlTxVj2aFPA ub9yzsZ3JO/VFw+EkT2Mwg922U5wJ6ahiJkj4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725373666; x=1725978466; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5ZRiA7pv2JEf0geeDpV/w6sgThpmDoyBtEknv+BKboA=; b=uTFfAHopCgBqoGzVVmlHCjixDqbJykT3U+rYUHurKY81kaMmGc69trN+iLayCJifhe nY+5i6lQWnTjW8OOXzMzr3lV83YjdK2KWeu3cJGsIFpkYB/FwebJvEOMOZtEs4Fu1+FD PSXvHAkQvo+ltfYuqmu+/S16RoAKof3M/IL2z1ADG5QkP9TnyADfYIjrLNXxM7Flw4C+ RKNiVZFgHJ1+wVCJuG+6WyIUMUXn2T5jWPoeqCkrzyUm425HO7SXmi/vx/ZsRex+iQGx inSliwKKGMmOnRtYbJtgnyF8cRUeg4DRi8EAoEMxUI7tK0y6uzqJ+QniulGuDI8CGrCV wtQA== X-Forwarded-Encrypted: i=1; AJvYcCURzacGbQeOeK6jyHZNvQ9OfZShMb2Yf86RT25lDcrbNMb11tjt1LWmJM6LDPZmlcs1cQFYrwJzd2o=@lists.xenproject.org X-Gm-Message-State: AOJu0Yznb3/+uk7aZ5fE37u+gTmD6X2bYDsMxJYLqHowAFfTRSDtHDXs kc4ktLYZiPDV0oFKr0tXVu/cj0JJKtbUfbqtlllXglIffSeohxPJ9TUJr3tqHdU= X-Google-Smtp-Source: AGHT+IHTs06em5ein2cPvX5+TnrDoUdHIFjH1kMOW5eQrJ7Ddl6RuaCCrD2DnKfymokvCP2llv5HAQ== X-Received: by 2002:a17:907:8f07:b0:a8a:75:bf5 with SMTP id a640c23a62f3a-a8a007514famr362635566b.19.1725373665318; Tue, 03 Sep 2024 07:27:45 -0700 (PDT) Message-ID: <7d2c4b4a-e366-4f95-9e41-1eb4439d1333@citrix.com> Date: Tue, 3 Sep 2024 15:27:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] RISCV/shutdown: Implement machine_{halt,restart}() To: Jan Beulich Cc: Oleksii Kurochko , Xen-devel References: <3d32a952c7cc77fd759e211c3b60427485a75582.1725295716.git.oleksii.kurochko@gmail.com> <20240903141937.3552353-1-andrew.cooper3@citrix.com> <1ace3e56-9cd8-4828-aaa2-92ba7766945a@suse.com> Content-Language: en-GB From: Andrew Cooper Autocrypt: addr=andrew.cooper3@citrix.com; keydata= xsFNBFLhNn8BEADVhE+Hb8i0GV6mihnnr/uiQQdPF8kUoFzCOPXkf7jQ5sLYeJa0cQi6Penp VtiFYznTairnVsN5J+ujSTIb+OlMSJUWV4opS7WVNnxHbFTPYZVQ3erv7NKc2iVizCRZ2Kxn srM1oPXWRic8BIAdYOKOloF2300SL/bIpeD+x7h3w9B/qez7nOin5NzkxgFoaUeIal12pXSR Q354FKFoy6Vh96gc4VRqte3jw8mPuJQpfws+Pb+swvSf/i1q1+1I4jsRQQh2m6OTADHIqg2E ofTYAEh7R5HfPx0EXoEDMdRjOeKn8+vvkAwhviWXTHlG3R1QkbE5M/oywnZ83udJmi+lxjJ5 YhQ5IzomvJ16H0Bq+TLyVLO/VRksp1VR9HxCzItLNCS8PdpYYz5TC204ViycobYU65WMpzWe LFAGn8jSS25XIpqv0Y9k87dLbctKKA14Ifw2kq5OIVu2FuX+3i446JOa2vpCI9GcjCzi3oHV e00bzYiHMIl0FICrNJU0Kjho8pdo0m2uxkn6SYEpogAy9pnatUlO+erL4LqFUO7GXSdBRbw5 gNt25XTLdSFuZtMxkY3tq8MFss5QnjhehCVPEpE6y9ZjI4XB8ad1G4oBHVGK5LMsvg22PfMJ ISWFSHoF/B5+lHkCKWkFxZ0gZn33ju5n6/FOdEx4B8cMJt+cWwARAQABzSlBbmRyZXcgQ29v cGVyIDxhbmRyZXcuY29vcGVyM0BjaXRyaXguY29tPsLBegQTAQgAJAIbAwULCQgHAwUVCgkI CwUWAgMBAAIeAQIXgAUCWKD95wIZAQAKCRBlw/kGpdefoHbdD/9AIoR3k6fKl+RFiFpyAhvO 59ttDFI7nIAnlYngev2XUR3acFElJATHSDO0ju+hqWqAb8kVijXLops0gOfqt3VPZq9cuHlh IMDquatGLzAadfFx2eQYIYT+FYuMoPZy/aTUazmJIDVxP7L383grjIkn+7tAv+qeDfE+txL4 SAm1UHNvmdfgL2/lcmL3xRh7sub3nJilM93RWX1Pe5LBSDXO45uzCGEdst6uSlzYR/MEr+5Z JQQ32JV64zwvf/aKaagSQSQMYNX9JFgfZ3TKWC1KJQbX5ssoX/5hNLqxMcZV3TN7kU8I3kjK mPec9+1nECOjjJSO/h4P0sBZyIUGfguwzhEeGf4sMCuSEM4xjCnwiBwftR17sr0spYcOpqET ZGcAmyYcNjy6CYadNCnfR40vhhWuCfNCBzWnUW0lFoo12wb0YnzoOLjvfD6OL3JjIUJNOmJy RCsJ5IA/Iz33RhSVRmROu+TztwuThClw63g7+hoyewv7BemKyuU6FTVhjjW+XUWmS/FzknSi dAG+insr0746cTPpSkGl3KAXeWDGJzve7/SBBfyznWCMGaf8E2P1oOdIZRxHgWj0zNr1+ooF /PzgLPiCI4OMUttTlEKChgbUTQ+5o0P080JojqfXwbPAyumbaYcQNiH1/xYbJdOFSiBv9rpt TQTBLzDKXok86M7BTQRS4TZ/ARAAkgqudHsp+hd82UVkvgnlqZjzz2vyrYfz7bkPtXaGb9H4 Rfo7mQsEQavEBdWWjbga6eMnDqtu+FC+qeTGYebToxEyp2lKDSoAsvt8w82tIlP/EbmRbDVn 7bhjBlfRcFjVYw8uVDPptT0TV47vpoCVkTwcyb6OltJrvg/QzV9f07DJswuda1JH3/qvYu0p vjPnYvCq4NsqY2XSdAJ02HrdYPFtNyPEntu1n1KK+gJrstjtw7KsZ4ygXYrsm/oCBiVW/OgU g/XIlGErkrxe4vQvJyVwg6YH653YTX5hLLUEL1NS4TCo47RP+wi6y+TnuAL36UtK/uFyEuPy wwrDVcC4cIFhYSfsO0BumEI65yu7a8aHbGfq2lW251UcoU48Z27ZUUZd2Dr6O/n8poQHbaTd 6bJJSjzGGHZVbRP9UQ3lkmkmc0+XCHmj5WhwNNYjgbbmML7y0fsJT5RgvefAIFfHBg7fTY/i kBEimoUsTEQz+N4hbKwo1hULfVxDJStE4sbPhjbsPCrlXf6W9CxSyQ0qmZ2bXsLQYRj2xqd1 bpA+1o1j2N4/au1R/uSiUFjewJdT/LX1EklKDcQwpk06Af/N7VZtSfEJeRV04unbsKVXWZAk uAJyDDKN99ziC0Wz5kcPyVD1HNf8bgaqGDzrv3TfYjwqayRFcMf7xJaL9xXedMcAEQEAAcLB XwQYAQgACQUCUuE2fwIbDAAKCRBlw/kGpdefoG4XEACD1Qf/er8EA7g23HMxYWd3FXHThrVQ HgiGdk5Yh632vjOm9L4sd/GCEACVQKjsu98e8o3ysitFlznEns5EAAXEbITrgKWXDDUWGYxd pnjj2u+GkVdsOAGk0kxczX6s+VRBhpbBI2PWnOsRJgU2n10PZ3mZD4Xu9kU2IXYmuW+e5KCA vTArRUdCrAtIa1k01sPipPPw6dfxx2e5asy21YOytzxuWFfJTGnVxZZSCyLUO83sh6OZhJkk b9rxL9wPmpN/t2IPaEKoAc0FTQZS36wAMOXkBh24PQ9gaLJvfPKpNzGD8XWR5HHF0NLIJhgg 4ZlEXQ2fVp3XrtocHqhu4UZR4koCijgB8sB7Tb0GCpwK+C4UePdFLfhKyRdSXuvY3AHJd4CP 4JzW0Bzq/WXY3XMOzUTYApGQpnUpdOmuQSfpV9MQO+/jo7r6yPbxT7CwRS5dcQPzUiuHLK9i nvjREdh84qycnx0/6dDroYhp0DFv4udxuAvt1h4wGwTPRQZerSm4xaYegEFusyhbZrI0U9tJ B8WrhBLXDiYlyJT6zOV2yZFuW47VrLsjYnHwn27hmxTC/7tvG3euCklmkn9Sl9IAKFu29RSo d5bD8kMSCYsTqtTfT6W4A3qHGvIDta3ptLYpIAOD2sY3GYq2nf3Bbzx81wZK14JdDDHUX2Rs 6+ahAA== In-Reply-To: <1ace3e56-9cd8-4828-aaa2-92ba7766945a@suse.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 03/09/2024 3:26 pm, Jan Beulich wrote: > On 03.09.2024 16:19, Andrew Cooper wrote: >> SBI has an API for shutdown so wire it up. However, the spec does allow the >> call not to be implemented, so we have to cope with the call return returning. >> >> There is a reboot-capable SBI extention, but in the short term route route >> machine_restart() into machine_halt(). >> >> Then, use use machine_halt() rather than an infinite loop at the end of >> start_xen(). This avoids the Qemu smoke test needing to wait for the full >> timeout in order to succeed. >> >> Signed-off-by: Andrew Cooper > Acked-by: Jan Beulich Thanks. > ideally with ... > >> --- /dev/null >> +++ b/xen/arch/riscv/shutdown.c >> @@ -0,0 +1,25 @@ >> +/* SPDX-License-Identifier: GPL-2.0-or-later */ >> +#include >> + >> +#include >> + >> +void machine_halt(void) >> +{ >> + sbi_shutdown(); >> + >> + for ( ;; ) >> + asm volatile ("wfi"); > ... the missing blanks added here, as you move that loop around. Ah yes.  Will do. ~Andrew