From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v3 7/9] mptcp: drop struct mptcp_pm_add_entry
Date: Wed, 4 Dec 2024 18:49:06 +0100 [thread overview]
Message-ID: <7d33f358-4893-4e2d-bcdd-89403a8855de@kernel.org> (raw)
In-Reply-To: <b881437711fb806cbe9aa7a0b2e36b5bb3cc1c84.1730961810.git.tanggeliang@kylinos.cn>
On 07/11/2024 07:45, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> There is no need to add a dedicated address entry type "mptcp_pm_add_entry"
> to represent ADD_ADDR addresses. Additional fields for ADD_ADDR addresses
> can be added into struct mptcp_pm_addr_entry directly. This makes the path
> manager code simpler.
To be honest, I don't know if the "union" simplifies stuff: we will need
to make sure some fields are not overridden by mistake. Always a bit risky.
Do you need this to simplify another patch later on?
> Here "union" can be used to merge struct mptcp_pm_addr_entry and struct
> mptcp_pm_add_entry into one. Then all mptcp_pm_add_entry can be replaced by
> mptcp_pm_addr_entry.
>
> Although this increases the size of the structure even more, but that's OK
> to do so because it is not used in an array.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2024-12-04 17:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 6:45 [PATCH mptcp-next v3 0/9] BPF path manager, part 1 Geliang Tang
2024-11-07 6:45 ` [PATCH mptcp-next v3 1/9] mptcp: add mptcp_userspace_pm_lookup_addr helper Geliang Tang
2024-11-07 6:45 ` [PATCH mptcp-next v3 2/9] mptcp: add mptcp_for_each_userspace_pm_addr macro Geliang Tang
2024-11-07 6:45 ` [PATCH mptcp-next v3 3/9] mptcp: add mptcp_userspace_pm_get_sock helper Geliang Tang
2024-11-07 6:45 ` [PATCH mptcp-next v3 4/9] mptcp: move mptcp_pm_remove_addrs into pm_userspace Geliang Tang
2024-12-04 17:48 ` Matthieu Baerts
2024-12-05 7:26 ` Geliang Tang
2024-12-05 9:27 ` Matthieu Baerts
2024-12-05 9:36 ` Geliang Tang
2024-12-05 9:38 ` Matthieu Baerts
2024-11-07 6:45 ` [PATCH mptcp-next v3 5/9] mptcp: drop free_list for deleting entries Geliang Tang
2024-12-04 17:49 ` Matthieu Baerts
2024-12-05 7:27 ` Geliang Tang
2024-11-07 6:45 ` [PATCH mptcp-next v3 6/9] mptcp: use mptcp_pm_local in pm_netlink only Geliang Tang
2024-11-10 4:40 ` Geliang Tang
2024-11-07 6:45 ` [PATCH mptcp-next v3 7/9] mptcp: drop struct mptcp_pm_add_entry Geliang Tang
2024-12-04 17:49 ` Matthieu Baerts [this message]
2024-12-05 7:28 ` Geliang Tang
2024-11-07 6:45 ` [PATCH mptcp-next v3 8/9] mptcp: change local addr type of subflow_destroy Geliang Tang
2024-11-07 6:45 ` [PATCH mptcp-next v3 9/9] mptcp: drop useless "err = 0" in subflow_destroy Geliang Tang
2024-12-04 17:49 ` Matthieu Baerts
2024-12-05 7:30 ` Geliang Tang
2024-11-07 7:56 ` [PATCH mptcp-next v3 0/9] BPF path manager, part 1 MPTCP CI
2024-12-04 17:48 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d33f358-4893-4e2d-bcdd-89403a8855de@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.