From: Ping-Ke Shih <pkshih@realtek.com>
To: "jiapeng.chong@linux.alibaba.com" <jiapeng.chong@linux.alibaba.com>
Cc: "kvalo@kernel.org" <kvalo@kernel.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"abaci@linux.alibaba.com" <abaci@linux.alibaba.com>
Subject: Re: [PATCH] wifi: rtw89: chan: Use swap() instead of open coding it
Date: Fri, 24 May 2024 09:47:47 +0000 [thread overview]
Message-ID: <7d3bbf5bcbe134edc8305bdc044b53edb88bbdab.camel@realtek.com> (raw)
In-Reply-To: <20240524075819.2789-1-jiapeng.chong@linux.alibaba.com>
Hi,
Subject "wifi: rtw89: chan: Use swap() instead of open coding it" is too common.
If more than one patch does similar thing, we can't know the change from
subject. It would be better to mention "swap sub_entity".
Others are good to me.
On Fri, 2024-05-24 at 15:58 +0800, Jiapeng Chong wrote:
>
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
>
> ./drivers/net/wireless/realtek/rtw89/chan.c:2336:32-33: WARNING opportunity for swap().
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=9174
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
>
next prev parent reply other threads:[~2024-05-24 9:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 7:58 [PATCH] wifi: rtw89: chan: Use swap() instead of open coding it Jiapeng Chong
2024-05-24 9:47 ` Ping-Ke Shih [this message]
2024-05-24 10:18 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d3bbf5bcbe134edc8305bdc044b53edb88bbdab.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=abaci@linux.alibaba.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.