All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhukeqian <zhukeqian1@huawei.com>
To: Peter Xu <peterx@redhat.com>
Cc: Zenghui Yu <yuzenghui@huawei.com>,
	pbonzini@redhat.com, qemu-devel@nongnu.org,
	wanghaibin.wang@huawei.com
Subject: Re: [PATCH] kvm: Take into account the unaligned section size when preparing bitmap
Date: Thu, 10 Dec 2020 10:53:23 +0800	[thread overview]
Message-ID: <7d46e5ca-24ab-7c44-201c-77e8fc6a2ace@huawei.com> (raw)
In-Reply-To: <20201210020843.GB3211@xz-x1>



On 2020/12/10 10:08, Peter Xu wrote:
> Keqian,
> 
> On Thu, Dec 10, 2020 at 09:46:06AM +0800, zhukeqian wrote:
>> Hi,
>>
>> I see that if start or size is not PAGE aligned, it also clears areas
>> which beyond caller's expectation, so do we also need to consider this?
> 
> Could you elaborate?
> 
> If start_delta != 0, kvm_log_clear_one_slot() should already go the slow path.
> 
> Thanks,
> 

Hi Peter,

start_delta /= psize;

If start is not PAGE aligned, then start_delta is not PAGE aligned.
so I think the above code will implicitly extend our start to be PAGE aligned.

I suggest that we should shrink the start and (start + size) to be PAGE aligned
at beginning of this function.

Maybe I miss something?

Keqian.


  reply	other threads:[~2020-12-10  2:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 11:40 [PATCH] kvm: Take into account the unaligned section size when preparing bitmap Zenghui Yu
2020-12-08 15:16 ` Peter Xu
2020-12-09  2:33   ` Zenghui Yu
2020-12-09 21:09     ` Peter Xu
2020-12-10  4:23       ` Zenghui Yu
2020-12-10  1:46     ` zhukeqian
2020-12-10  2:08       ` Peter Xu
2020-12-10  2:53         ` zhukeqian [this message]
2020-12-10  3:31           ` Zenghui Yu
2020-12-10 14:50           ` Peter Xu
2020-12-11  1:13             ` zhukeqian
2020-12-11 15:25               ` Peter Xu
2020-12-14  2:14                 ` zhukeqian
2020-12-14 15:36                   ` Peter Xu
2020-12-15  7:23                     ` zhukeqian
2020-12-15  7:39                       ` Zenghui Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d46e5ca-24ab-7c44-201c-77e8fc6a2ace@huawei.com \
    --to=zhukeqian1@huawei.com \
    --cc=pbonzini@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wanghaibin.wang@huawei.com \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.