From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01EEAC61DA3 for ; Fri, 24 Feb 2023 12:58:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id AF815C433EF; Fri, 24 Feb 2023 12:58:03 +0000 (UTC) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id AE6DAC433D2; Fri, 24 Feb 2023 12:58:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org AE6DAC433D2 Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-f181.google.com with SMTP id z2so16806651plf.12; Fri, 24 Feb 2023 04:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677243482; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CXtEyT8xVIkUMApBSTQ3cYy66lfTrvRLYpoVJHa9vcs=; b=fGNjMXdOa/2jFDtcv4zjh5C+rTTvUkujg/MH7jVU3TzF9pgNNfvHMmhe9KdoxBz/IP nmztiOBlWTPhe8cRXO284AFl+WeBp8e9PutPukzpzZTijXvU5PcC9Nwy+uMv/Mg7/qtq 65O0QVE2iGRv7s6zI0/YqQm+oO4XGzzePhfEJTl4EHbLKkdZRyyrGgetPgQYcn5MyOt0 nWXkaJhYVsiaj+Q125hN1AqIJe9XEGJAPYQOZDSmCVkg9j/6QVnGvmRJ4xPlwhoxDCJb vwEnSRVIkmlUamNSmoPcmYEFDgUuf7R29/rCGuSskTxzfp6gAWVsKMS24m6VaAWqb/kB sQqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677243482; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CXtEyT8xVIkUMApBSTQ3cYy66lfTrvRLYpoVJHa9vcs=; b=UVVYFkpGzky6+/EZpHfDsu+87vjX0Rn0Zz9eYwimGL0WuWRc5w5g/fNzx318dYiuaa V5/2HdZm9xfhaiQf/gViXQ2EHNa+HhQSfXrFpnPRsm/mzcnDTtqPWOTG081OBppZIpkz Fo9iNMBANCkPZnVNohiYuT5ynFneevrCddLBtMTUsXcsm9vhtwL09p71DBMGihmtXsQP mSdzAK1bjBBN1KZbQ4Y0s3bNlciwM1WK8xc3ptHjNhNTGQuaN3gnrjtwjo0MT/gUVBHT Mw7I0kqByvwblWymEeN4OUGOkS0h8C9J8+mBqtu5RPlyRiCQxts0DoOlAKi2rq/PAOaR fs5w== X-Gm-Message-State: AO0yUKVj1xV1PQny7mqjDE+pQt9OPcV39djGTerTQ54gZbfUokFZnh7O qfaQvqvOD1ksT2LhEeyuVWc= X-Google-Smtp-Source: AK7set+YzXg/RfEEChGbQ+6UrrWMwrZYY/kX2hO/BsunvHndn5j3QyvNXnxK3qAajg7VWTkoh4nCsg== X-Received: by 2002:a17:902:d2cd:b0:19a:98fd:9c54 with SMTP id n13-20020a170902d2cd00b0019a98fd9c54mr19495973plc.35.1677243482019; Fri, 24 Feb 2023 04:58:02 -0800 (PST) Received: from [192.168.1.39] (M014008005000.v4.enabler.ne.jp. [14.8.5.0]) by smtp.gmail.com with ESMTPSA id d2-20020a170902654200b0019a74841c9bsm6409474pln.192.2023.02.24.04.57.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 04:58:01 -0800 (PST) Message-ID: <7d4a218d-8b8a-5a1d-eff8-e154bfde69be@gmail.com> Date: Fri, 24 Feb 2023 21:57:37 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] ARM: dts: mvebu: add device tree for IIJ SA-W2 appliance Content-Language: en-US To: Andrew Lunn List-Id: Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, arnd@arndb.de, olof@lixom.net, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230223132502.2045-1-musashino.open@gmail.com> <20230223132502.2045-2-musashino.open@gmail.com> From: INAGAKI Hiroshi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Andrew, thank you for your reviews and detailed descriptions. On 2023/02/23 23:43, Andrew Lunn wrote: >> + pcie { >> + status = "okay"; >> + >> + pcie@1,0 { >> + status = "okay"; >> + >> + /* Atheros AR9287 */ >> + wifi@0,0 { >> + compatible = "pci168c,002e"; >> + reg = <0000 0 0 0 0>; >> + }; >> + }; >> + >> + pcie@3,0 { >> + status = "okay"; >> + >> + /* Qualcomm Atheros QCA9880 */ >> + wifi@0,0 { >> + compatible = "qcom,ath10k"; >> + reg = <0000 0 0 0 0>; >> + }; >> + }; >> + }; >> + }; > These are not wrong, but they are also not needed. PCI devices should > be discovered by enumeration, and you don't have any additional > properties here, or phandles pointing to these nodes. > > I assume these are COTS wifi modules? By listing them here you are > restricting some flexibility. The OEM could for example swap the > modules around, and Linux would not care, but the DT would then be > wrong. Or you could have a device with a different module because it > is cheaper, and again, Linux would not care, but the DT would be > wrong. Got it. SA-W2 is not designed to allow users to swap cards under normal use, but certainly things like you said can happen... I'll remove "wifi" nodes. > I assume these are COTS wifi modules? Yes, those are the modules manufactured by Silex Technology, Inc. [1][2]. [1]: https://www.silex.jp/products/wireless-module/sxpcegn.html [2]: https://www.silex.jp/products/wireless-module/sxpceac.html > >> +&usb0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pmx_usb_pins>; >> + status = "okay"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + /* SMSC USB2514B */ >> + hub@1 { >> + compatible = "usb424,2514"; >> + reg = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + hub_port1: port@1 { >> + reg = <1>; >> + #trigger-source-cells = <0>; >> + }; >> + >> + hub_port2: port@2 { >> + reg = <2>; >> + #trigger-source-cells = <0>; >> + }; >> + }; >> +}; > Same comment as PCI. However, it is likely that the USB hub is > actually on the board, not a module, so it is a lot less likely to > change. Yes, that USB hub is on the PCB and wired to the SoC directly. But I'll keep it in mind... > > As i said, they are not wrong, so you don't need to remove them. > > Andrew > Regards, Hiroshi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 63756C61DA3 for ; Fri, 24 Feb 2023 12:59:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yy3bNNSsPAIGpFmY+fy0YYDHCK1z2ngOWZ1WOq3Ett0=; b=XEtNfVAH+AAoO/ tonn8MFw+efdnGMng+hhy15PV4K12NlJl+oGIu3IJKgZEFpr6HVA8AvJpzwKNuVmPl/wa62971vi4 00xHhZ10MXIKXkFSA1qm+m43ElY7PLbxrMo7uqoIPNu/hToX7E3fGFOfaCdkiK/KlvP3cjHenw1zh x6vRcimtC9rbaEArTZFp7IbrUN0ZXnUHwymQDAUCXs7E4Z7Duh7rfgKEUe87irZ3LDgT+cTDWTJzl uGgi+X+JptSYUf9R6z2FWY429Vkrx/RkZH44rUfr3CQc6rXDL6diRt69+CyZiiGm2XXDqMevpgF3S kGUXBqf/C4iPOeFCpt5Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVXeL-002UMx-12; Fri, 24 Feb 2023 12:58:09 +0000 Received: from mail-pj1-x1033.google.com ([2607:f8b0:4864:20::1033]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pVXeG-002ULI-66 for linux-arm-kernel@lists.infradead.org; Fri, 24 Feb 2023 12:58:06 +0000 Received: by mail-pj1-x1033.google.com with SMTP id gi3-20020a17090b110300b0023762f642dcso2615381pjb.4 for ; Fri, 24 Feb 2023 04:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677243482; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CXtEyT8xVIkUMApBSTQ3cYy66lfTrvRLYpoVJHa9vcs=; b=fGNjMXdOa/2jFDtcv4zjh5C+rTTvUkujg/MH7jVU3TzF9pgNNfvHMmhe9KdoxBz/IP nmztiOBlWTPhe8cRXO284AFl+WeBp8e9PutPukzpzZTijXvU5PcC9Nwy+uMv/Mg7/qtq 65O0QVE2iGRv7s6zI0/YqQm+oO4XGzzePhfEJTl4EHbLKkdZRyyrGgetPgQYcn5MyOt0 nWXkaJhYVsiaj+Q125hN1AqIJe9XEGJAPYQOZDSmCVkg9j/6QVnGvmRJ4xPlwhoxDCJb vwEnSRVIkmlUamNSmoPcmYEFDgUuf7R29/rCGuSskTxzfp6gAWVsKMS24m6VaAWqb/kB sQqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677243482; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CXtEyT8xVIkUMApBSTQ3cYy66lfTrvRLYpoVJHa9vcs=; b=Pqfmk3gGB6/z3/9Il/zkF38BTgZSB7mAQnXbRzaxPDYppFgvetMIGgPgfs79zXg1nT kUXMwRyXaVwEV1Rfdsz7ZfPc+w4KEy3ZXOeHZO6BFI6idzbJfaDzajwSiL5Yf6JZEDNk V2nZma34DOocPnDWsCSQVj9Sj5klGyNhYx7aoKogJWhk4ayNQvS7MaLXnnPFUJB3ffHV ZYeVCIjKBsTgFQaKpWQCk8u+ni37ARIQi1vox+q8hRBbvC5eIY8xwm+1OTdO6Vh0OxDi IrmG7W8qHbqN7fZWCTHMtGoev9ZTRn7VYcYeacMTnFHhSDCJmEiKCOZdrEws8g1o0Hl5 fWpw== X-Gm-Message-State: AO0yUKXefsG190bBFEcey08G8XabalxWOYm7Nl2dDB+NHZfCE/MFK3l5 R2GKFgEFhtOx0f6BK6fGRQQ= X-Google-Smtp-Source: AK7set+YzXg/RfEEChGbQ+6UrrWMwrZYY/kX2hO/BsunvHndn5j3QyvNXnxK3qAajg7VWTkoh4nCsg== X-Received: by 2002:a17:902:d2cd:b0:19a:98fd:9c54 with SMTP id n13-20020a170902d2cd00b0019a98fd9c54mr19495973plc.35.1677243482019; Fri, 24 Feb 2023 04:58:02 -0800 (PST) Received: from [192.168.1.39] (M014008005000.v4.enabler.ne.jp. [14.8.5.0]) by smtp.gmail.com with ESMTPSA id d2-20020a170902654200b0019a74841c9bsm6409474pln.192.2023.02.24.04.57.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Feb 2023 04:58:01 -0800 (PST) Message-ID: <7d4a218d-8b8a-5a1d-eff8-e154bfde69be@gmail.com> Date: Fri, 24 Feb 2023 21:57:37 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH 2/2] ARM: dts: mvebu: add device tree for IIJ SA-W2 appliance Content-Language: en-US To: Andrew Lunn Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com, arnd@arndb.de, olof@lixom.net, soc@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230223132502.2045-1-musashino.open@gmail.com> <20230223132502.2045-2-musashino.open@gmail.com> From: INAGAKI Hiroshi In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230224_045804_296762_35154FE7 X-CRM114-Status: GOOD ( 19.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, thank you for your reviews and detailed descriptions. On 2023/02/23 23:43, Andrew Lunn wrote: >> + pcie { >> + status = "okay"; >> + >> + pcie@1,0 { >> + status = "okay"; >> + >> + /* Atheros AR9287 */ >> + wifi@0,0 { >> + compatible = "pci168c,002e"; >> + reg = <0000 0 0 0 0>; >> + }; >> + }; >> + >> + pcie@3,0 { >> + status = "okay"; >> + >> + /* Qualcomm Atheros QCA9880 */ >> + wifi@0,0 { >> + compatible = "qcom,ath10k"; >> + reg = <0000 0 0 0 0>; >> + }; >> + }; >> + }; >> + }; > These are not wrong, but they are also not needed. PCI devices should > be discovered by enumeration, and you don't have any additional > properties here, or phandles pointing to these nodes. > > I assume these are COTS wifi modules? By listing them here you are > restricting some flexibility. The OEM could for example swap the > modules around, and Linux would not care, but the DT would then be > wrong. Or you could have a device with a different module because it > is cheaper, and again, Linux would not care, but the DT would be > wrong. Got it. SA-W2 is not designed to allow users to swap cards under normal use, but certainly things like you said can happen... I'll remove "wifi" nodes. > I assume these are COTS wifi modules? Yes, those are the modules manufactured by Silex Technology, Inc. [1][2]. [1]: https://www.silex.jp/products/wireless-module/sxpcegn.html [2]: https://www.silex.jp/products/wireless-module/sxpceac.html > >> +&usb0 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&pmx_usb_pins>; >> + status = "okay"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + /* SMSC USB2514B */ >> + hub@1 { >> + compatible = "usb424,2514"; >> + reg = <1>; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + hub_port1: port@1 { >> + reg = <1>; >> + #trigger-source-cells = <0>; >> + }; >> + >> + hub_port2: port@2 { >> + reg = <2>; >> + #trigger-source-cells = <0>; >> + }; >> + }; >> +}; > Same comment as PCI. However, it is likely that the USB hub is > actually on the board, not a module, so it is a lot less likely to > change. Yes, that USB hub is on the PCB and wired to the SoC directly. But I'll keep it in mind... > > As i said, they are not wrong, so you don't need to remove them. > > Andrew > Regards, Hiroshi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel