From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D37A8C433EF for ; Wed, 16 Feb 2022 09:37:40 +0000 (UTC) Received: from localhost ([::1]:50614 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKGkl-00021p-NI for qemu-devel@archiver.kernel.org; Wed, 16 Feb 2022 04:37:39 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54188) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKGKv-0000Vm-Bu for qemu-devel@nongnu.org; Wed, 16 Feb 2022 04:10:57 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:23786) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKGKU-00066M-Vm for qemu-devel@nongnu.org; Wed, 16 Feb 2022 04:10:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645002630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r4I7Th247TY4HbG7kAa/kfBHKYzZCltQ1GNrkS9N6EM=; b=S+U+QYQZcs88lxDp+k6jkw5fWF2BQYgnk/2hOu6vXR1oyNHI+TqV8mnu9e73Yw+b+yLegl NHl+282XWa5vL1eywtCUfLRjx/941IVKoP2CWFgDYgj5BdPNg/7ioeXz4XgsDIxAusLD+N PAYsBVCK7niO5Ji0qzddf3FsYChVdT0= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-403-CbkK3UIgPGax35cBKjmXzg-1; Wed, 16 Feb 2022 04:10:29 -0500 X-MC-Unique: CbkK3UIgPGax35cBKjmXzg-1 Received: by mail-wm1-f71.google.com with SMTP id p24-20020a05600c1d9800b0037be98d03a1so2684256wms.0 for ; Wed, 16 Feb 2022 01:10:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=r4I7Th247TY4HbG7kAa/kfBHKYzZCltQ1GNrkS9N6EM=; b=0y8zdqOYyfgeHVTkgXk94icRRQ0KqXwDpC8nCLvOb3Az8ADeqIQ4v1RUq87CartaWu 6miDSRYRZU0ukUkQjzaFFVw8RvxvVF75y7RM1gTrj5Ic0uOXZglqDg4gCdlD5Cgnpsom dwdxIGivLuO5qhrVqIHoSQzDSuV2QC5c+WkZSjCMX5EavZJIGlWcS5rYVcTL2UZCamHu RL2JvVEDU+ekqPZP3ZTpbrrhWIJgmDHq8aFaMqvbqEDgGgV5HfBEGBD3zzdzmoykmKpt Slzoi27cKz/1QFI3vPD9LFsDhsYoUdDwXZ102tYNJQLniYzyr2JExxDHU3T0ztLFS/ty Oa+A== X-Gm-Message-State: AOAM533nGk+FnR8OcsS6MbQEPk/J6+8A7k/+h4pks8iRBbLQE01gT7tq v2XUhbiVBHKgXzIb4FdT/0RvAbWcaJaXxtioNlz3VoTbYXpYZoDUmQeFPtqS9M0iqlQ2U1E3oIo knk2fLBOFb8s6SW8= X-Received: by 2002:a5d:4e87:0:b0:1e3:45bd:f74 with SMTP id e7-20020a5d4e87000000b001e345bd0f74mr1450086wru.357.1645002628109; Wed, 16 Feb 2022 01:10:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJw1xgo+cIPtO6pJyHE8uX+mzX5UXIWAW1EZtg8VPel1IWVv46judOJ2YqONUhdXCjnfOSIyRQ== X-Received: by 2002:a5d:4e87:0:b0:1e3:45bd:f74 with SMTP id e7-20020a5d4e87000000b001e345bd0f74mr1450066wru.357.1645002627846; Wed, 16 Feb 2022 01:10:27 -0800 (PST) Received: from ?IPV6:2a04:ee41:4:31cb:e591:1e1e:abde:a8f1? ([2a04:ee41:4:31cb:e591:1e1e:abde:a8f1]) by smtp.gmail.com with ESMTPSA id t2sm16974911wrr.55.2022.02.16.01.10.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Feb 2022 01:10:27 -0800 (PST) Message-ID: <7d4cc9c1-d4d0-c588-003a-e422b2fc0948@redhat.com> Date: Wed, 16 Feb 2022 10:10:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v1 2/4] hyperv: Add definitions for syndbg To: Jon Doron , qemu-devel@nongnu.org References: <20220204100723.406121-1-arilou@gmail.com> <20220204100723.406121-3-arilou@gmail.com> From: Emanuele Giuseppe Esposito In-Reply-To: <20220204100723.406121-3-arilou@gmail.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=eesposit@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=eesposit@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.083, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pbonzini@redhat.com, vkuznets@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 04/02/2022 11:07, Jon Doron wrote: > Add all required definitions for hyperv synthetic debugger interface. > > Signed-off-by: Jon Doron > --- > include/hw/hyperv/hyperv-proto.h | 52 ++++++++++++++++++++++++++++++++ > target/i386/kvm/hyperv-proto.h | 37 +++++++++++++++++++++++ > 2 files changed, 89 insertions(+) > > diff --git a/include/hw/hyperv/hyperv-proto.h b/include/hw/hyperv/hyperv-proto.h > index 21dc28aee9..94c9658eb0 100644 > --- a/include/hw/hyperv/hyperv-proto.h > +++ b/include/hw/hyperv/hyperv-proto.h > @@ -24,12 +24,17 @@ > #define HV_STATUS_INVALID_PORT_ID 17 > #define HV_STATUS_INVALID_CONNECTION_ID 18 > #define HV_STATUS_INSUFFICIENT_BUFFERS 19 > +#define HV_STATUS_NOT_ACKNOWLEDGED 20 > +#define HV_STATUS_NO_DATA 27 > > /* > * Hypercall numbers > */ > #define HV_POST_MESSAGE 0x005c > #define HV_SIGNAL_EVENT 0x005d > +#define HV_POST_DEBUG_DATA 0x0069 > +#define HV_RETREIVE_DEBUG_DATA 0x006a s/RETREIVE/RETRIEVE? > +#define HV_RESET_DEBUG_SESSION 0x006b > #define HV_HYPERCALL_FAST (1u << 16) > > /* > @@ -127,4 +132,51 @@ struct hyperv_event_flags_page { > struct hyperv_event_flags slot[HV_SINT_COUNT]; > }; > > +/* > + * Kernel debugger structures > + */ > + > +/* Options flags for hyperv_reset_debug_session */ > +#define HV_DEBUG_PURGE_INCOMING_DATA 0x00000001 > +#define HV_DEBUG_PURGE_OUTGOING_DATA 0x00000002 > +struct hyperv_reset_debug_session_input { > + uint32_t options; > +} __attribute__ ((__packed__)); > + > +struct hyperv_reset_debug_session_output { > + uint32_t host_ip; > + uint32_t target_ip; > + uint16_t host_port; > + uint16_t target_port; > + uint8_t host_mac[6]; > + uint8_t target_mac[6]; > +} __attribute__ ((__packed__)); > + > +/* Options for hyperv_post_debug_data */ > +#define HV_DEBUG_POST_LOOP 0x00000001 > + > +struct hyperv_post_debug_data_input { > + uint32_t count; > + uint32_t options; > + /*uint8_t data[HV_HYP_PAGE_SIZE - 2 * sizeof(uint32_t)];*/ What is this comment for? > +} __attribute__ ((__packed__)); > + > +struct hyperv_post_debug_data_output { > + uint32_t pending_count; > +} __attribute__ ((__packed__)); > + > +/* Options for hyperv_retrieve_debug_data */ > +#define HV_DEBUG_RETRIEVE_LOOP 0x00000001 > +#define HV_DEBUG_RETRIEVE_TEST_ACTIVITY 0x00000002 > + > +struct hyperv_retrieve_debug_data_input { > + uint32_t count; > + uint32_t options; > + uint64_t timeout; > +} __attribute__ ((__packed__)); > + > +struct hyperv_retrieve_debug_data_output { > + uint32_t retrieved_count; > + uint32_t remaining_count; > +} __attribute__ ((__packed__)); > #endif > diff --git a/target/i386/kvm/hyperv-proto.h b/target/i386/kvm/hyperv-proto.h > index 89f81afda7..9480bcdf04 100644 > --- a/target/i386/kvm/hyperv-proto.h > +++ b/target/i386/kvm/hyperv-proto.h > @@ -19,6 +19,9 @@ > #define HV_CPUID_ENLIGHTMENT_INFO 0x40000004 > #define HV_CPUID_IMPLEMENT_LIMITS 0x40000005 > #define HV_CPUID_NESTED_FEATURES 0x4000000A > +#define HV_CPUID_SYNDBG_VENDOR_AND_MAX_FUNCTIONS 0x40000080 > +#define HV_CPUID_SYNDBG_INTERFACE 0x40000081 > +#define HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES 0x40000082 > #define HV_CPUID_MIN 0x40000005 > #define HV_CPUID_MAX 0x4000ffff > #define HV_HYPERVISOR_PRESENT_BIT 0x80000000 > @@ -55,8 +58,14 @@ > #define HV_GUEST_IDLE_STATE_AVAILABLE (1u << 5) > #define HV_FREQUENCY_MSRS_AVAILABLE (1u << 8) > #define HV_GUEST_CRASH_MSR_AVAILABLE (1u << 10) > +#define HV_FEATURE_DEBUG_MSRS_AVAILABLE (1u << 11) > #define HV_STIMER_DIRECT_MODE_AVAILABLE (1u << 19) > > +/* > + * HV_CPUID_FEATURES.EBX bits > + */ > +#define HV_PARTITION_DEUBGGING_ALLOWED (1u << 12) s/DEUBGGING/DEBUGGING > + > /* > * HV_CPUID_ENLIGHTMENT_INFO.EAX bits > */ > @@ -72,6 +81,11 @@ > #define HV_ENLIGHTENED_VMCS_RECOMMENDED (1u << 14) > #define HV_NO_NONARCH_CORESHARING (1u << 18) > > +/* > + * HV_CPUID_SYNDBG_PLATFORM_CAPABILITIES.EAX bits > + */ > +#define HV_SYNDBG_CAP_ALLOW_KERNEL_DEBUGGING (1u << 1) > + > /* > * Basic virtualized MSRs > */ > @@ -130,6 +144,18 @@ > #define HV_X64_MSR_STIMER3_CONFIG 0x400000B6 > #define HV_X64_MSR_STIMER3_COUNT 0x400000B7 > > +/* > + * Hyper-V Synthetic debug options MSR > + */ > +#define HV_X64_MSR_SYNDBG_CONTROL 0x400000F1 > +#define HV_X64_MSR_SYNDBG_STATUS 0x400000F2 > +#define HV_X64_MSR_SYNDBG_SEND_BUFFER 0x400000F3 > +#define HV_X64_MSR_SYNDBG_RECV_BUFFER 0x400000F4 > +#define HV_X64_MSR_SYNDBG_PENDING_BUFFER 0x400000F5 > +#define HV_X64_MSR_SYNDBG_OPTIONS 0x400000FF > + > +#define HV_X64_SYNDBG_OPTION_USE_HCALLS BIT(2) > + > /* > * Guest crash notification MSRs > */ > @@ -168,5 +194,16 @@ > > #define HV_STIMER_COUNT 4 > > +/* > + * Synthetic debugger control definitions > + */ > +#define HV_SYNDBG_CONTROL_SEND (1u << 0) > +#define HV_SYNDBG_CONTROL_RECV (1u << 1) > +#define HV_SYNDBG_CONTROL_SEND_SIZE(ctl) ((ctl >> 16) & 0xffff) > +#define HV_SYNDBG_STATUS_INVALID (0) > +#define HV_SYNDBG_STATUS_SEND_SUCCESS (1u << 0) > +#define HV_SYNDBG_STATUS_RECV_SUCCESS (1u << 2) > +#define HV_SYNDBG_STATUS_RESET (1u << 3) > +#define HV_SYNDBG_STATUS_SET_SIZE(st, sz) (st | (sz << 16)) > > #endif >