Re: [PATCH] riscv: process: Use str_supported_unsupported() in compat_mode_detect()

From: Paul Walmsley <pjw@kernel.org>
To: Thorsten Blum <blum@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Paul Walmsley <pjw@kernel.org>,
	 Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	 Alexandre Ghiti <alex@ghiti.fr>,
	Deepak Gupta <debug@rivosinc.com>,  Zong Li <zong.li@sifive.com>,
	Samuel Holland <samuel.holland@sifive.com>,
	 Zishun Yi <vulab@iscas.ac.cn>,
	linux-riscv@lists.infradead.org,  linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: process: Use str_supported_unsupported() in compat_mode_detect()
Date: Thu, 1 Oct 2026 10:45:11 -0600 (MDT)	[thread overview]
Message-ID: <7d4e8a05-4e4e-55be-2a9d-715c65787c38@kernel.org> (raw)
In-Reply-To: <aruH26spDeM8O9dh@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 1659 bytes --]

On Tue, 29 Sep 2026, Thorsten Blum wrote:

> On Tue, Sep 29, 2026 at 11:11:55AM +0200, Geert Uytterhoeven wrote:
> > Hi Paul, Thorsten,
> > 
> > On Sat, 26 Sept 2026 at 01:48, Paul Walmsley <pjw@kernel.org> wrote:
> > > On Thu, 24 Sep 2026, Thorsten Blum wrote:
> > > > Replace hard-coded strings with the str_supported_unsupported() helper.
> > > > This unifies the output and helps the linker with deduplication, which
> > > > can result in a smaller binary.
> > > >
> > > > Signed-off-by: Thorsten Blum <blum@kernel.org>
> > >
> > > Thanks, queued for v7.4.
> > 
> > Thanks for your patch, which is now commit a06776565b9e7351 ("riscv:
> > process: Use str_supported_unsupported() in compat_mode_detect()")
> > in riscv/for-next.
> > 
> > This fails to build:
> > 
> >     arch/riscv/kernel/process.c: In function ‘compat_mode_detect’:
> >     arch/riscv/kernel/process.c:138:17: error: implicit declaration of
> > function ‘str_supported_unsupported’
> > [-Werror=implicit-function-declaration]
> >       138 |                 str_supported_unsupported(compat_mode_supported));
> >           |                 ^~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > as it has a hard dependency on commit 5383cf280ef4f00b
> > ("lib/string_choices: Add str_supported_unsupported()
> > helper"), which is only present in the for-next branch of
> > https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git.
> 
> Hi Geert,
> 
> It's also in linux-next:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=5383cf280ef4f00b15f1d9e2a2886d0d02c0118b

I'm dropping this one until the dependency lands in mainline.  

- Paul

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv