Re: [PATCH 1/4] drm/i915/display: Make icl_dsi_frame_update use _fw too

[Jani Nikula <jani.nikula@linux.intel.com>]

On Thu, 02 Jul 2026, Maarten Lankhorst <dev@lankhorst.se> wrote:
> Don't use the dmc lock inside the vblank critical section,
> not even as last call.

The commit message should explain the why.

> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
> ---
>  drivers/gpu/drm/i915/display/icl_dsi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index ea0cdb7822f39..f1ccbc5efd6ea 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -242,8 +242,8 @@ void icl_dsi_frame_update(struct intel_crtc_state *crtc_state)
>  	else
>  		return;
>  
> -	intel_de_rmw(display, DSI_CMD_FRMCTL(port), 0,
> -		     DSI_FRAME_UPDATE_REQUEST);
> +	intel_de_rmw_fw(display, DSI_CMD_FRMCTL(port), 0,
> +			DSI_FRAME_UPDATE_REQUEST);
>  }
>  
>  static void dsi_program_swing_and_deemphasis(struct intel_encoder *encoder)

-- 
Jani Nikula, Intel