From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: [PATCH 1/8] wifi: rtw88: Fix rtw_mac_power_switch() for RTL8814AU
Date: Thu, 13 Feb 2025 07:29:19 +0000 [thread overview]
Message-ID: <7d83f8070d214427828e93020e5a443f@realtek.com> (raw)
In-Reply-To: <83c8e281-0d25-4de6-a6c7-84d24b228888@gmail.com>
Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> rtw_mac_power_switch() checks bit 8 of REG_SYS_STATUS1 to see if the
> chip is powered on. This bit appears to be always on in the RTL8814AU,
> so ignore it.
>
> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@gmail.com>
> ---
> drivers/net/wireless/realtek/rtw88/mac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/mac.c b/drivers/net/wireless/realtek/rtw88/mac.c
> index 63edf6461de8..5de16c75adf2 100644
> --- a/drivers/net/wireless/realtek/rtw88/mac.c
> +++ b/drivers/net/wireless/realtek/rtw88/mac.c
> @@ -291,7 +291,8 @@ static int rtw_mac_power_switch(struct rtw_dev *rtwdev, bool pwr_on)
> if (rtw_read8(rtwdev, REG_CR) == 0xea)
> cur_pwr = false;
> else if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_USB &&
> - (rtw_read8(rtwdev, REG_SYS_STATUS1 + 1) & BIT(0)))
> + chip->id != RTW_CHIP_TYPE_8814A &&
> + (rtw_read8(rtwdev, REG_SYS_STATUS1 + 1) & BIT(0)))
The newly added codes are not aligned, and seemingly only need to add
the line checking 8814A.
> cur_pwr = false;
> else
> cur_pwr = true;
> --
> 2.48.1
next prev parent reply other threads:[~2025-02-13 7:29 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 22:21 [PATCH 0/8] wifi: rtw88: Prepare to support RTL8814AU (part 2/2) Bitterblue Smith
2025-02-11 22:22 ` [PATCH 1/8] wifi: rtw88: Fix rtw_mac_power_switch() for RTL8814AU Bitterblue Smith
2025-02-13 7:29 ` Ping-Ke Shih [this message]
2025-02-11 22:22 ` [PATCH 2/8] wifi: rtw88: Fix rtw_desc_to_mcsrate() to handle MCS16-31 Bitterblue Smith
2025-02-13 7:30 ` Ping-Ke Shih
2025-02-13 16:12 ` Bitterblue Smith
2025-02-14 0:09 ` Ping-Ke Shih
2025-02-11 22:23 ` [PATCH 3/8] wifi: rtw88: Fix rtw_init_ht_cap() for RTL8814AU Bitterblue Smith
2025-02-13 7:35 ` Ping-Ke Shih
2025-02-11 22:23 ` [PATCH 4/8] wifi: rtw88: Fix rtw_init_vht_cap() " Bitterblue Smith
2025-02-13 7:39 ` Ping-Ke Shih
2025-02-11 22:24 ` [PATCH 5/8] wifi: rtw88: Fix rtw_rx_phy_stat() " Bitterblue Smith
2025-02-13 7:43 ` Ping-Ke Shih
2025-02-11 22:24 ` [PATCH 6/8] wifi: rtw88: Extend rtw_phy_config_swing_table() " Bitterblue Smith
2025-02-13 7:44 ` Ping-Ke Shih
2025-02-11 22:25 ` [PATCH 7/8] wifi: rtw88: Extend rtw_debugfs_get_phy_info() " Bitterblue Smith
2025-02-13 7:48 ` Ping-Ke Shih
2025-02-11 22:26 ` [PATCH 8/8] wifi: rtw88: Extend rtw_debugfs_get_tx_pwr_tbl() " Bitterblue Smith
2025-02-13 7:52 ` Ping-Ke Shih
2025-02-13 16:13 ` Bitterblue Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d83f8070d214427828e93020e5a443f@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rtl8821cerfe2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.