From: Tejun Heo <tj@kernel.org>
To: Usama Arif <usama.arif@linux.dev>
Cc: arighi@nvidia.com, bpf@vger.kernel.org, bsegall@google.com,
changwoo@igalia.com, dietmar.eggemann@arm.com, etsal@meta.com,
juri.lelli@redhat.com, kprateek.nayak@amd.com,
linux-kernel@vger.kernel.org, mgorman@suse.de, mingo@redhat.com,
peterz@infradead.org, rostedt@goodmis.org,
sched-ext@lists.linux.dev, vincent.guittot@linaro.org,
void@manifault.com, vschneid@redhat.com, yphbchou0911@gmail.com,
emil@etsalapatis.com, david.dai@linux.dev
Subject: Re: [PATCH] sched_ext: Update scx_dispatch_dequeue() comments
Date: Wed, 23 Sep 2026 13:20:34 -1000 [thread overview]
Message-ID: <7d8f411e5153472c11bf158c4d948816@kernel.org> (raw)
In-Reply-To: <20260923213418.3197834-1-usama.arif@linux.dev>
Hello, Usama.
On Wed, Sep 23, 2026 at 02:34:18PM -0700, Usama Arif wrote:
> /*
> - * When dispatching directly from the BPF scheduler to a local
> - * DSQ, the task isn't associated with any DSQ but
> - * @p->scx.holding_cpu may be set under the protection of
> - * %SCX_OPSS_DISPATCHING.
> + * When moving a task to a local DSQ through either direct dispatch
> + * or remote consumption, the task isn't associated with any DSQ but
> + * @p->scx.holding_cpu may be set.
> */
dispatch_to_local_dsq() sets holding_cpu for ops.dispatch() inserts too,
not just direct dispatches. Can you name dispatch_to_local_dsq() instead,
here and in the description?
Clearing holding_cpu here is also how dispatch_to_local_dsq() learns that
it lost to a dequeue. The old comment on the other branch described that,
but for the wrong branch. Can you add a sentence about it here?
Can you also rewrap both comments at 80 columns? A few lines go past it.
Thanks.
--
tejun
prev parent reply other threads:[~2026-09-23 23:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 21:34 [PATCH] sched_ext: Update scx_dispatch_dequeue() comments Usama Arif
2026-09-23 23:20 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8f411e5153472c11bf158c4d948816@kernel.org \
--to=tj@kernel.org \
--cc=arighi@nvidia.com \
--cc=bpf@vger.kernel.org \
--cc=bsegall@google.com \
--cc=changwoo@igalia.com \
--cc=david.dai@linux.dev \
--cc=dietmar.eggemann@arm.com \
--cc=emil@etsalapatis.com \
--cc=etsal@meta.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sched-ext@lists.linux.dev \
--cc=usama.arif@linux.dev \
--cc=vincent.guittot@linaro.org \
--cc=void@manifault.com \
--cc=vschneid@redhat.com \
--cc=yphbchou0911@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.