From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH] amdgpu/dc: Use DRM new-style object iterators. Date: Wed, 11 Oct 2017 16:30:26 +0200 Message-ID: <7dbcabe8-d3de-7cfa-1e4d-b61be746f0cd@linux.intel.com> References: <1507731880-5843-1-git-send-email-sunpeng.li@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1507731880-5843-1-git-send-email-sunpeng.li-5C7GfCeVMHo@public.gmane.org> Content-Language: en-US List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: sunpeng.li-5C7GfCeVMHo@public.gmane.org, airlied-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: harry.wentland-5C7GfCeVMHo@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org T3AgMTEtMTAtMTcgb20gMTY6MjQgc2NocmVlZiBzdW5wZW5nLmxpQGFtZC5jb206Cj4gRnJvbTog IkxlbyAoU3VucGVuZykgTGkiIDxzdW5wZW5nLmxpQGFtZC5jb20+Cj4KPiBVc2UgdGhlIGNvcnJl Y3QgZm9yX2VhY2hfbmV3L29sZF8qIGl0ZXJhdG9ycyBpbnN0ZWFkIG9mIGZvcl9lYWNoXyoKPgo+ IExpc3Qgb2YgYWZmZWN0ZWQgZnVuY3Rpb25zOgo+Cj4gYW1kZ3B1X2RtX2ZpbmRfZmlyc3RfY3J0 Y19tYXRjaGluZ19jb25uZWN0b3I6IHVzZSBmb3JfZWFjaF9uZXcKPiAgICAgLSBPbGQgZnJvbV9z dGF0ZV92YXIgZmxhZyB3YXMgYWx3YXlzIGNob29zaW5nIHRoZSBuZXcgc3RhdGUKPgo+IGFtZGdw dV9kbV9kaXNwbGF5X3Jlc3VtZTogdXNlIGZvcl9lYWNoX25ldwo+ICAgICAtIGRybV9hdG9taWNf aGVscGVyX2R1cGxpY2F0ZV9zdGF0ZSBpcyBjYWxsZWQgZHVyaW5nIHN1c3BlbmQgdG8KPiAgICAg ICBjYWNoZSB0aGUgc3RhdGUKPiAgICAgLSBJdCBzZXRzICdzdGF0ZScgd2l0aGluIHRoZSBzdGF0 ZSB0cmlwbGV0IHRvICduZXdfc3RhdGUnCj4KPiBhbWRncHVfZG1fY29tbWl0X3BsYW5lczogdXNl IGZvcl9lYWNoX29sZAo+ICAgICAtIENhbGxlZCBhZnRlciB0aGUgc3RhdGUgd2FzIHN3YXBwZWQg KHZpYSBhdG9taWMgY29tbWl0IHRhaWwpCj4KPiBhbWRncHVfZG1fYXRvbWljX2NvbW1pdDogdXNl IGZvcl9lYWNoX25ldwo+ICAgICAtIENhbGxlZCBiZWZvcmUgdGhlIHN0YXRlIGlzIHN3YXBwZWQK Pgo+IGFtZGdwdV9kbV9hdG9taWNfY29tbWl0X3RhaWw6IHVzZSBmb3JfZWFjaF9vbGQKPiAgICAg LSBDYWxsZWQgYWZ0ZXIgdGhlIHN0YXRlIHdhcyBzd2FwcGVkCj4KPiBkbV91cGRhdGVfY3J0Y3Nf c3RhdGU6IHVzZSBmb3JfZWFjaF9uZXcKPiAgICAgLSBDYWxsZWQgYmVmb3JlIHRoZSBzdGF0ZSBp cyBzd2FwcGVkICh2aWEgYXRvbWljIGNoZWNrKQo+Cj4gYW1kZ3B1X2RtX2F0b21pY19jaGVjazog dXNlIGZvcl9lYWNoX25ldwo+ICAgICAtIENhbGxlZCBiZWZvcmUgdGhlIHN0YXRlIGlzIHN3YXBw ZWQKPgo+IEFsc28gZml4IHNvbWUgdHlwb3MuCj4KPiBjcmN0IC0+IGNydGMKPiB1bmRlcnNhY24g LT4gdW5kZXJzY2FuCj4KPiBTaWduZWQtb2ZmLWJ5OiBMZW8gKFN1bnBlbmcpIExpIDxzdW5wZW5n LmxpQGFtZC5jb20+Cj4gLS0tCj4KPiBIaSBEYXZlLAo+Cj4gVGhpcyBwYXRjaCBnb2VzIG9uIHRv cCBvZiB5b3VyIGZpeHVwIGZvciBuZXcgYXBpJ3MgcGF0Y2guIFBsZWFzZSBmZWVsCj4gZnJlZSB0 byBzcXVhc2ggdGhlbS4KPgo+IFRoYW5rcywKPiBMZW8KPgo+ICBkcml2ZXJzL2dwdS9kcm0vYW1k L2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jIHwgMzggKysrKysrKysrLS0tLS0tLS0tLS0t LS0KPiAgZHJpdmVycy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uaCB8 ICA1ICsrLQo+ICAyIGZpbGVzIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDI3IGRlbGV0aW9u cygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVf ZG0vYW1kZ3B1X2RtLmMgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2Ft ZGdwdV9kbS5jCj4gaW5kZXggOWJmZTFmOS4uOTM5NDU1OCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2FtZC9kaXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uYwo+IEBAIC01NjgsMjUg KzU2OCwxNyBAQCBzdGF0aWMgaW50IGRtX3N1c3BlbmQodm9pZCAqaGFuZGxlKQo+ICAJcmV0dXJu IHJldDsKPiAgfQo+ICAKPiAtc3RydWN0IGFtZGdwdV9kbV9jb25uZWN0b3IgKmFtZGdwdV9kbV9m aW5kX2ZpcnN0X2NyY3RfbWF0Y2hpbmdfY29ubmVjdG9yKAo+ICtzdHJ1Y3QgYW1kZ3B1X2RtX2Nv bm5lY3RvciAqYW1kZ3B1X2RtX2ZpbmRfZmlyc3RfY3J0Y19tYXRjaGluZ19jb25uZWN0b3IoCj4g IAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gLQlzdHJ1Y3QgZHJtX2NydGMgKmNy dGMsCj4gLQlib29sIGZyb21fc3RhdGVfdmFyKQo+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjKQo+ ICB7Cj4gIAl1aW50MzJfdCBpOwo+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5f c3RhdGU7Cj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yOwo+ICAJc3RydWN0IGRy bV9jcnRjICpjcnRjX2Zyb21fc3RhdGU7Cj4gIAo+IC0JZm9yX2VhY2hfbmV3X2Nvbm5lY3Rvcl9p bl9zdGF0ZSgKPiAtCQlzdGF0ZSwKPiAtCQljb25uZWN0b3IsCj4gLQkJY29ubl9zdGF0ZSwKPiAt CQlpKSB7Cj4gLQkJY3J0Y19mcm9tX3N0YXRlID0KPiAtCQkJZnJvbV9zdGF0ZV92YXIgPwo+IC0J CQkJY29ubl9zdGF0ZS0+Y3J0YyA6Cj4gLQkJCQljb25uZWN0b3ItPnN0YXRlLT5jcnRjOwo+ICsJ Zm9yX2VhY2hfbmV3X2Nvbm5lY3Rvcl9pbl9zdGF0ZShzdGF0ZSwgY29ubmVjdG9yLCBjb25uX3N0 YXRlLCBpKSB7Cj4gKwkJY3J0Y19mcm9tX3N0YXRlID0gY29ubl9zdGF0ZS0+Y3J0YzsKUGxlYXNl IGFzc2lnbiBjcnRjX2Zyb21fc3RhdGUgaGVyZSB3aXRoIGRybV9hdG9taWNfZ2V0XyhuZXcvb2xk KV9jcnRjX3N0YXRlLgoKCj4gIAkJaWYgKGNydGNfZnJvbV9zdGF0ZSA9PSBjcnRjKQo+ICAJCQly ZXR1cm4gdG9fYW1kZ3B1X2RtX2Nvbm5lY3Rvcihjb25uZWN0b3IpOwo+IEBAIC0zODkwLDcgKzM4 ODIsNyBAQCBzdGF0aWMgdm9pZCBhbWRncHVfZG1fY29tbWl0X3BsYW5lcyhzdHJ1Y3QgZHJtX2F0 b21pY19zdGF0ZSAqc3RhdGUsCj4gIAl1bnNpZ25lZCBsb25nIGZsYWdzOwo+ICAKPiAgCS8qIHVw ZGF0ZSBwbGFuZXMgd2hlbiBuZWVkZWQgKi8KPiAtCWZvcl9lYWNoX25ld19wbGFuZV9pbl9zdGF0 ZShzdGF0ZSwgcGxhbmUsIG9sZF9wbGFuZV9zdGF0ZSwgaSkgewo+ICsJZm9yX2VhY2hfb2xkX3Bs YW5lX2luX3N0YXRlKHN0YXRlLCBwbGFuZSwgb2xkX3BsYW5lX3N0YXRlLCBpKSB7Cj4gIAkJc3Ry dWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGUgPSBwbGFuZS0+c3RhdGU7Cj4gIAkJc3Ry dWN0IGRybV9jcnRjICpjcnRjID0gcGxhbmVfc3RhdGUtPmNydGM7Cj4gIAkJc3RydWN0IGRybV9m cmFtZWJ1ZmZlciAqZmIgPSBwbGFuZV9zdGF0ZS0+ZmI7ClVzZSBmb3JfZWFjaF9vbGRuZXdfKl9p bl9zdGF0ZQo+IEBAIC00MDI0LDcgKzQwMTYsNyBAQCB2b2lkIGFtZGdwdV9kbV9hdG9taWNfY29t bWl0X3RhaWwoCj4gIAlkbV9zdGF0ZSA9IHRvX2RtX2F0b21pY19zdGF0ZShzdGF0ZSk7Cj4gIAo+ ICAJLyogdXBkYXRlIGNoYW5nZWQgaXRlbXMgKi8KPiAtCWZvcl9lYWNoX25ld19jcnRjX2luX3N0 YXRlKHN0YXRlLCBjcnRjLCBvbGRfY3J0Y19zdGF0ZSwgaSkgewo+ICsJZm9yX2VhY2hfb2xkX2Ny dGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG9sZF9jcnRjX3N0YXRlLCBpKSB7Cj4gIAkJc3RydWN0 IGFtZGdwdV9jcnRjICphY3J0YyA9IHRvX2FtZGdwdV9jcnRjKGNydGMpOwo+ICAJCXN0cnVjdCBk cm1fY3J0Y19zdGF0ZSAqbmV3X3N0YXRlID0gY3J0Yy0+c3RhdGU7ClNhbWUuCj4gIAo+IEBAIC00 MTEzLDExICs0MTA1LDkgQEAgdm9pZCBhbWRncHVfZG1fYXRvbWljX2NvbW1pdF90YWlsKAo+ICAJ CQluZXdfYWNydGNfc3RhdGUgPSB0b19kbV9jcnRjX3N0YXRlKG5ld19jcnRjc1tpXS0+YmFzZS5z dGF0ZSk7Cj4gIAo+ICAJCQluZXdfc3RyZWFtID0gbmV3X2FjcnRjX3N0YXRlLT5zdHJlYW07Cj4g LQkJCWFjb25uZWN0b3IgPQo+IC0JCQkJYW1kZ3B1X2RtX2ZpbmRfZmlyc3RfY3JjdF9tYXRjaGlu Z19jb25uZWN0b3IoCj4gKwkJCWFjb25uZWN0b3IgPSBhbWRncHVfZG1fZmluZF9maXJzdF9jcnRj X21hdGNoaW5nX2Nvbm5lY3RvcigKPiAgCQkJCQlzdGF0ZSwKPiAtCQkJCQkmbmV3X2NydGNzW2ld LT5iYXNlLAo+IC0JCQkJCWZhbHNlKTsKPiArCQkJCQkmbmV3X2NydGNzW2ldLT5iYXNlKTsKPiAg CQkJaWYgKCFhY29ubmVjdG9yKSB7Cj4gIAkJCQlEUk1fREVCVUdfRFJJVkVSKCJBdG9taWMgY29t bWl0OiBGYWlsZWQgdG8gZmluZCBjb25uZWN0b3IgZm9yIGFjcnRjIGlkOiVkICIKPiAgCQkJCQkg InNraXBwaW5nIGZyZWVzeW5jIGluaXRcbiIsCj4gQEAgLTQxNTAsOCArNDE0MCw4IEBAIHZvaWQg YW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbCgKPiAgCQl9Cj4gIAl9Cj4gIAo+IC0JLyogSGFu ZGxlIHNjYWxpbmcgYW5kIHVuZGVyc2FjbiBjaGFuZ2VzKi8KPiAtCWZvcl9lYWNoX25ld19jb25u ZWN0b3JfaW5fc3RhdGUoc3RhdGUsIGNvbm5lY3Rvciwgb2xkX2Nvbm5fc3RhdGUsIGkpIHsKPiAr CS8qIEhhbmRsZSBzY2FsaW5nIGFuZCB1bmRlcnNjYW4gY2hhbmdlcyovCj4gKwlmb3JfZWFjaF9v bGRfY29ubmVjdG9yX2luX3N0YXRlKHN0YXRlLCBjb25uZWN0b3IsIG9sZF9jb25uX3N0YXRlLCBp KSB7Cj4gIAkJc3RydWN0IGFtZGdwdV9kbV9jb25uZWN0b3IgKmFjb25uZWN0b3IgPSB0b19hbWRn cHVfZG1fY29ubmVjdG9yKGNvbm5lY3Rvcik7Cj4gIAkJc3RydWN0IGRtX2Nvbm5lY3Rvcl9zdGF0 ZSAqY29uX25ld19zdGF0ZSA9Cj4gIAkJCQl0b19kbV9jb25uZWN0b3Jfc3RhdGUoYWNvbm5lY3Rv ci0+YmFzZS5zdGF0ZSk7ClNhbWUgaGVyZS4uCj4gQEAgLTQyMDUsNyArNDE5NSw3IEBAIHZvaWQg YW1kZ3B1X2RtX2F0b21pY19jb21taXRfdGFpbCgKPiAgCX0KPiAgCj4gIAkvKiB1cGRhdGUgcGxh bmVzIHdoZW4gbmVlZGVkIHBlciBjcnRjKi8KPiAtCWZvcl9lYWNoX25ld19jcnRjX2luX3N0YXRl KHN0YXRlLCBwY3J0Yywgb2xkX2NydGNfc3RhdGUsIGopIHsKPiArCWZvcl9lYWNoX29sZF9jcnRj X2luX3N0YXRlKHN0YXRlLCBwY3J0Yywgb2xkX2NydGNfc3RhdGUsIGopIHsKPiAgCQluZXdfYWNy dGNfc3RhdGUgPSB0b19kbV9jcnRjX3N0YXRlKHBjcnRjLT5zdGF0ZSk7ClNhbWUuCj4gIAkJaWYg KG5ld19hY3J0Y19zdGF0ZS0+c3RyZWFtKQo+IEBAIC00MjE4LDcgKzQyMDgsNyBAQCB2b2lkIGFt ZGdwdV9kbV9hdG9taWNfY29tbWl0X3RhaWwoCj4gIAkgKiBtYXJrIGNvbnN1bWVkIGV2ZW50IGZv ciBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfaHdfZG9uZQo+ICAJICovCj4gIAlzcGluX2xvY2tf aXJxc2F2ZSgmYWRldi0+ZGRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+IC0JZm9yX2VhY2hfbmV3 X2NydGNfaW5fc3RhdGUoc3RhdGUsIGNydGMsIG9sZF9jcnRjX3N0YXRlLCBpKSB7Cj4gKwlmb3Jf ZWFjaF9vbGRfY3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3RhdGUsIGkpIHsK PiAgCQlzdHJ1Y3QgYW1kZ3B1X2NydGMgKmFjcnRjID0gdG9fYW1kZ3B1X2NydGMoY3J0Yyk7Cj4g IAo+ICAJCWlmIChhY3J0Yy0+YmFzZS5zdGF0ZS0+ZXZlbnQpClNhbWUuIFlvdSdyZSBkZXJlZmVy ZW5jaW5nIGNydGMtPnN0YXRlCj4gQEAgLTQ0MDIsNyArNDM5Miw3IEBAIHN0YXRpYyBpbnQgZG1f dXBkYXRlX2NydGNzX3N0YXRlKAo+ICAJCW5ld19hY3J0Y19zdGF0ZSA9IHRvX2RtX2NydGNfc3Rh dGUoY3J0Y19zdGF0ZSk7Cj4gIAkJYWNydGMgPSB0b19hbWRncHVfY3J0YyhjcnRjKTsKPiAgCj4g LQkJYWNvbm5lY3RvciA9IGFtZGdwdV9kbV9maW5kX2ZpcnN0X2NyY3RfbWF0Y2hpbmdfY29ubmVj dG9yKHN0YXRlLCBjcnRjLCB0cnVlKTsKPiArCQlhY29ubmVjdG9yID0gYW1kZ3B1X2RtX2ZpbmRf Zmlyc3RfY3J0Y19tYXRjaGluZ19jb25uZWN0b3Ioc3RhdGUsIGNydGMpOwo+ICAKPiAgCQkvKiBU T0RPIFRoaXMgaGFjayBzaG91bGQgZ28gYXdheSAqLwo+ICAJCWlmIChhY29ubmVjdG9yKSB7Cj4g QEAgLTQ3MTUsNyArNDcwNSw3IEBAIGludCBhbWRncHVfZG1fYXRvbWljX2NoZWNrKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsCj4gIAkgaWYgKHJldCkKPiAgCQkgZ290byBmYWlsOwo+ICAKPiAtCS8q IENoZWNrIHNjYWxpbmcgYW5kIHVuZGVyc2FjbiBjaGFuZ2VzKi8KPiArCS8qIENoZWNrIHNjYWxp bmcgYW5kIHVuZGVyc2NhbiBjaGFuZ2VzKi8KPiAgCS8qVE9ETyBSZW1vdmVkIHNjYWxpbmcgY2hh bmdlcyB2YWxpZGF0aW9uIGR1ZSB0byBpbmFiaWxpdHkgdG8gY29tbWl0Cj4gIAkgKiBuZXcgc3Ry ZWFtIGludG8gY29udGV4dCB3XG8gY2F1c2luZyBmdWxsIHJlc2V0LiBOZWVkIHRvCj4gIAkgKiBk ZWNpZGUgaG93IHRvIGhhbmRsZS4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9k aXNwbGF5L2FtZGdwdV9kbS9hbWRncHVfZG0uaCBiL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxh eS9hbWRncHVfZG0vYW1kZ3B1X2RtLmgKPiBpbmRleCA2MzBlNmNkLi5jMWI3N2JkIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvZGlzcGxheS9hbWRncHVfZG0vYW1kZ3B1X2RtLmgK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2Rpc3BsYXkvYW1kZ3B1X2RtL2FtZGdwdV9kbS5o Cj4gQEAgLTIyNiwxMCArMjI2LDkgQEAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBhbWRncHVfaXBfYmxv Y2tfdmVyc2lvbiBkbV9pcF9ibG9jazsKPiAgdm9pZCBhbWRncHVfZG1fdXBkYXRlX2Nvbm5lY3Rv cl9hZnRlcl9kZXRlY3QoCj4gIAlzdHJ1Y3QgYW1kZ3B1X2RtX2Nvbm5lY3RvciAqYWNvbm5lY3Rv cik7Cj4gIAo+IC1zdHJ1Y3QgYW1kZ3B1X2RtX2Nvbm5lY3RvciAqYW1kZ3B1X2RtX2ZpbmRfZmly c3RfY3JjdF9tYXRjaGluZ19jb25uZWN0b3IoCj4gK3N0cnVjdCBhbWRncHVfZG1fY29ubmVjdG9y ICphbWRncHVfZG1fZmluZF9maXJzdF9jcnRjX21hdGNoaW5nX2Nvbm5lY3RvcigKPiAgCXN0cnVj dCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAtCXN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAt CWJvb2wgZnJvbV9zdGF0ZV92YXIpOwo+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjKTsKPiAgCj4g IAo+ICBzdHJ1Y3QgYW1kZ3B1X2ZyYW1lYnVmZmVyOwoKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGluZyBsaXN0CmFtZC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vYW1kLWdmeAo=