From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Daniel Drake <drake@endlessm.com>
Cc: liam.r.girdwood@linux.intel.com, "Lin,
Mengdong" <mengdong.lin@intel.com>,
alsa-devel@alsa-project.org
Subject: Re: snd_soc_set_dmi_name - Shouldn't it use SYS_VENDOR?
Date: Thu, 27 Apr 2017 15:32:31 -0500 [thread overview]
Message-ID: <7dbec345-e058-18ca-b4b3-e071fbc08fb0@linux.intel.com> (raw)
In-Reply-To: <CAD8Lp44uqQW9+V_ZgB4LLXa8WFb+=CX8hT8PmWbZEGFhZGTvBw@mail.gmail.com>
On 04/27/2017 03:13 PM, Daniel Drake wrote:
> On Thu, Apr 27, 2017 at 1:28 PM, Pierre-Louis Bossart
> <pierre-louis.bossart@linux.intel.com> wrote:
>> Not sure if we can really limit the conventions to type1 or type2 if we want
>> the names to be somewhat meaningful.
>>
>> I can't recall why we selected DMI_BOARD_VENDOR instead of DMI_SYS_VENDOR
>> though.
> Is it too late to change to DMI_SYS_VENDOR? Or to have both present in
> the string?
While in general DMI_SYS_VENDOR is commonly used, there are exceptions
to the rule, such as the very machine I am working on at the moment
which does have any useful DMI_SYS_VENDOR information (see below)
Mengdong may be able to comment on why we took this direction.
Handle 0x0001, DMI type 1, 27 bytes
System Information
Manufacturer:
Product Name:
Version:
Serial Number:
UUID: 6DD3E1A2-7A70-41FC-917A-231C2C4E2E4E
Wake-up Type: Power Switch
SKU Number:
Family:
Handle 0x0002, DMI type 2, 15 bytes
Base Board Information
Manufacturer: Intel Corporation
Product Name: NUC6i7KYB
Version: H90766-405
next prev parent reply other threads:[~2017-04-27 20:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 18:00 snd_soc_set_dmi_name - Shouldn't it use SYS_VENDOR? Daniel Drake
2017-04-27 19:28 ` Pierre-Louis Bossart
2017-04-27 20:13 ` Daniel Drake
2017-04-27 20:32 ` Pierre-Louis Bossart [this message]
2017-04-27 21:02 ` Daniel Drake
2017-04-28 8:36 ` Takashi Iwai
2017-04-28 10:35 ` Liam Girdwood
2017-04-28 15:02 ` Lin, Mengdong
2017-04-28 16:21 ` Lin, Mengdong
2017-04-29 15:27 ` Daniel Drake
2017-05-02 10:19 ` Mengdong Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dbec345-e058-18ca-b4b3-e071fbc08fb0@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=drake@endlessm.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=mengdong.lin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.