From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abhinav Kumar Subject: Re: [PATCH] drm/msm: check for equals 0 only Date: Thu, 25 Apr 2019 15:52:50 -0700 Message-ID: <7dc496f1663fa788977b8b00bce9d695@codeaurora.org> References: <1556201031-3676-1-git-send-email-hofrat@osadl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1556201031-3676-1-git-send-email-hofrat-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Nicholas Mc Guire Cc: Sean Paul , Archit Taneja , Jordan Crouse , David Airlie , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Rob Clark , Sibi Sankar , Daniel Vetter , Daniel Mack , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Chandan Uddaraju List-Id: linux-arm-msm@vger.kernel.org T24gMjAxOS0wNC0yNSAwNzowMywgTmljaG9sYXMgTWMgR3VpcmUgd3JvdGU6Cj4gd2FpdF9mb3Jf Y29tcGxldGlvbl90aW1lb3V0KCkgcmV0dXJucyAwIG9uIHRpbWVvdXQgYW5kIGFsZWFzdCAxIAo+ IG90aGVyd2lzZQo+IHNvIGNoZWNraW5nIGZvciA8IG1ha2VzIG5vIHNlbnNlIGhlcmUuCj4gCj4g U2lnbmVkLW9mZi1ieTogTmljaG9sYXMgTWMgR3VpcmUgPGhvZnJhdEBvc2FkbC5vcmc+ClJldmll d2VkLWJ5OiBBYmhpbmF2IEt1bWFyIDxhYmhpbmF2a0Bjb2RlYXVyb3JhLm9yZz4KPiAtLS0KPiAK PiBQcm9ibGVtIGxvY2F0ZWQgd2l0aCBhbiBleHBlcmltZW50YWwgY29jY2luZWxsZSBzY3JpcHQK PiAKPiBXaGlsZSB0aGlzIGNoZWNrIGRvZXMgbm8gaGFybSBpbiB0aGlzIGZvcm0gLSBpdCBzaG91 bGQgYmUgZml4ZWQgYW55d2F5Cj4gdG8gY29tcGx5IHdpdGggdGhlIEFQSSBzZWU6IGtlcm5lbC9z Y2hlZC9jb21wbGV0aW9uLmMKPiAKPiBBbHNvIG5vdGljZWQgdGhhdCBnZXRfbWFpbnRhaW5lci5w bCB3aWxsIG5vdCBsaXN0IAo+IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPiB3aGVuIHJ1 biBvbiBkcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9kc2lfaG9zdC5jIC0gaXMgdGhhdCBpbnRlbnRp b25hbCA/Cj4gCj4gUGF0Y2ggd2FzIGNvbXBpbGUtdGVzdGVkIHdpdGg6IHFjb21fZGVmY29uZmln IChpbXBsaWVzIERSTV9NU01fRFNJPXkpCj4gCj4gUGF0Y2ggaXMgYWdhaW5zdCB2NS4xLXJjNiAo bG9jYWx2ZXJzaW9uLW5leHQgaXMgbmV4dC0yMDE5MDQyNCkKPiAKPiAgZHJpdmVycy9ncHUvZHJt L21zbS9kc2kvZHNpX2hvc3QuYyB8IDIgKy0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9u KCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20v ZHNpL2RzaV9ob3N0LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9tc20vZHNpL2RzaV9ob3N0LmMKPiBp bmRleCA2MTAxODNkLi5kYzE2MDY3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20v ZHNpL2RzaV9ob3N0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2RzaS9kc2lfaG9zdC5j Cj4gQEAgLTEwNDksNyArMTA0OSw3IEBAIHN0YXRpYyB2b2lkIGRzaV93YWl0NHZpZGVvX2RvbmUo c3RydWN0Cj4gbXNtX2RzaV9ob3N0ICptc21faG9zdCkKPiAgCXJldCA9IHdhaXRfZm9yX2NvbXBs ZXRpb25fdGltZW91dCgmbXNtX2hvc3QtPnZpZGVvX2NvbXAsCj4gIAkJCW1zZWNzX3RvX2ppZmZp ZXMoNzApKTsKPiAKPiAtCWlmIChyZXQgPD0gMCkKPiArCWlmIChyZXQgPT0gMCkKPiAgCQlEUk1f REVWX0VSUk9SKGRldiwgIndhaXQgZm9yIHZpZGVvIGRvbmUgdGltZWQgb3V0XG4iKTsKPiAKPiAg CWRzaV9pbnRyX2N0cmwobXNtX2hvc3QsIERTSV9JUlFfTUFTS19WSURFT19ET05FLCAwKTsKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KRnJlZWRyZW5vIG1h aWxpbmcgbGlzdApGcmVlZHJlbm9AbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZnJlZWRyZW5v From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C8D5C43218 for ; Thu, 25 Apr 2019 22:52:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 284D7206BF for ; Thu, 25 Apr 2019 22:52:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="K9jUC5ZV"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="RnSnNj1T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbfDYWww (ORCPT ); Thu, 25 Apr 2019 18:52:52 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:57506 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbfDYWww (ORCPT ); Thu, 25 Apr 2019 18:52:52 -0400 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 2B62660252; Thu, 25 Apr 2019 22:52:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556232771; bh=D5eGQwtPsK+KFB8H0bbBPZv1fYvpokAlLVAkWuAxFGs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=K9jUC5ZVQC5yhos2xgDlNDI15RmnqrfWcAsGcPKz/7Qi0LzVwzRgTAa7M7cXdjFSQ +YE1+sX2Ho58QIRxeBW9qSz/+PSFAcpfrq9goYOQWu6gbUqz8GDqJR7Z7uCMYvuQEr 06xFPiRhbSqsiIw6h5C2f8amcDhljAMPsF7/olUg= Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.codeaurora.org (Postfix) with ESMTP id 6B4A760746; Thu, 25 Apr 2019 22:52:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1556232770; bh=D5eGQwtPsK+KFB8H0bbBPZv1fYvpokAlLVAkWuAxFGs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RnSnNj1To+jl8lzHTtFl0znyUO85DwTDUhMtJHKUprCyApnyHL3uwY/YTv6NLp26A wY8OW5CILNGuuMQ0TWTCrFJ/mNWQb3wX0v8/pmgmwYgKYdUDZV+aKRAQQXKEWDc/6K b2d8YRBcw4M8DyhT1lbLi1FeHFWvn4N0cX2xIcCU= MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 7bit Date: Thu, 25 Apr 2019 15:52:50 -0700 From: Abhinav Kumar To: Nicholas Mc Guire Cc: Rob Clark , freedreno@lists.freedesktop.org, Archit Taneja , David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jordan Crouse , Sibi Sankar , Daniel Vetter , Chandan Uddaraju , Sean Paul , Daniel Mack Subject: Re: [Freedreno] [PATCH] drm/msm: check for equals 0 only In-Reply-To: <1556201031-3676-1-git-send-email-hofrat@osadl.org> References: <1556201031-3676-1-git-send-email-hofrat@osadl.org> Message-ID: <7dc496f1663fa788977b8b00bce9d695@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.2.5 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Message-ID: <20190425225250.2vGjgmWcPTmQtJ4fZCIPR9_FIKHrFRgS4BX1_fthqyE@z> On 2019-04-25 07:03, Nicholas Mc Guire wrote: > wait_for_completion_timeout() returns 0 on timeout and aleast 1 > otherwise > so checking for < makes no sense here. > > Signed-off-by: Nicholas Mc Guire Reviewed-by: Abhinav Kumar > --- > > Problem located with an experimental coccinelle script > > While this check does no harm in this form - it should be fixed anyway > to comply with the API see: kernel/sched/completion.c > > Also noticed that get_maintainer.pl will not list > linux-kernel@vger.kernel.org > when run on drivers/gpu/drm/msm/dsi/dsi_host.c - is that intentional ? > > Patch was compile-tested with: qcom_defconfig (implies DRM_MSM_DSI=y) > > Patch is against v5.1-rc6 (localversion-next is next-20190424) > > drivers/gpu/drm/msm/dsi/dsi_host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c > b/drivers/gpu/drm/msm/dsi/dsi_host.c > index 610183d..dc16067 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_host.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c > @@ -1049,7 +1049,7 @@ static void dsi_wait4video_done(struct > msm_dsi_host *msm_host) > ret = wait_for_completion_timeout(&msm_host->video_comp, > msecs_to_jiffies(70)); > > - if (ret <= 0) > + if (ret == 0) > DRM_DEV_ERROR(dev, "wait for video done timed out\n"); > > dsi_intr_ctrl(msm_host, DSI_IRQ_MASK_VIDEO_DONE, 0);