From: Khem Raj <raj.khem@gmail.com>
To: Andre McCurdy <armccurdy@gmail.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH][master-next] webkitgtk: add PACKAGECONFIG gobject-introspection
Date: Thu, 20 Feb 2020 14:06:29 -0800 [thread overview]
Message-ID: <7dd9779b1be7e10a54b3b1bff4788cae931cb02a.camel@gmail.com> (raw)
In-Reply-To: <CAJ86T=URADiQr=_iOdw990WWCHhkDL0sAS-oD1JEtyV9UOHGXg@mail.gmail.com>
On Thu, 2020-02-20 at 14:00 -0800, Andre McCurdy wrote:
> On Thu, Feb 20, 2020 at 12:33 PM Khem Raj <raj.khem@gmail.com> wrote:
> > On Thu, Feb 20, 2020 at 12:24 PM Andreas Müller <
> > schnitzeltony@gmail.com> wrote:
> > > On Thu, Feb 20, 2020 at 1:45 PM Andreas Müller <
> > > schnitzeltony@gmail.com> wrote:
> > > > On Thu, Feb 20, 2020 at 11:07 AM Alexander Kanavin
> > > > <alex.kanavin@gmail.com> wrote:
> > > > > You need to at the same time drop the introspection
> > > > > enablement logic from EXTRA_OECMAKE I think?
> > > > > This line:
> > > > > http://git.yoctoproject.org/cgit/cgit.cgi/poky/tree/meta/recipes-sato/webkit/webkitgtk_2.26.4.bb?h=master-next#n70
> > > > >
> > > > > And for consistency, it would be good to do the same for gtk-
> > > > > doc.
> > > >
> > > > This is odd: I fell over this because there was no gir created.
> > > > Did
> > > > not notice it was few lines below. Need to check that - maybe I
> > > > am a
> > > > bit off-sync to master or something is wrong elsewhere.
> > > >
> > > > Will sync to master and send V2 then.
> > > >
> > > Finally had time to look into again. In the recipe there is
> > >
> > > GI_DATA_ENABLED_armv7a = "False"
> > > GI_DATA_ENABLED_armv7ve = "False"
> > >
> > > => My patch is wrong it overrides above accidentally - thanks
> > > Alex!
> > >
> > > Since webkit builds gir fine (my machine is armv7ve) that does
> > > not
> > > seem necessary any more. I would like to send out a patch
> > > removing at
> > > least armv7ve - shall I take the risk to remove armv7a - maybe as
> > > two
> > > patches?
>
> These two should be equivalent for all practical purposes and so
> should be updated together. ie remove them both, one patch.
it will run user mode qemu underneath, which is not same for both, are
you sure libraries and apps it will run are identical ?
next prev parent reply other threads:[~2020-02-20 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 0:28 [PATCH][master-next] webkitgtk: add PACKAGECONFIG gobject-introspection Andreas Müller
2020-02-20 10:08 ` Alexander Kanavin
2020-02-20 12:45 ` Andreas Müller
2020-02-20 20:24 ` Andreas Müller
2020-02-20 20:33 ` Khem Raj
2020-02-20 22:00 ` Andre McCurdy
2020-02-20 22:06 ` Khem Raj [this message]
2020-02-20 22:11 ` Andre McCurdy
2020-02-20 22:24 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7dd9779b1be7e10a54b3b1bff4788cae931cb02a.camel@gmail.com \
--to=raj.khem@gmail.com \
--cc=armccurdy@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.