From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE01A4F885 for ; Mon, 18 Mar 2024 15:28:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710775737; cv=none; b=Co91EuriV7kaV9IhiBcZ0hLE6LrfedCCrkIHmIxqNQhAcTTrEI5n7d5y5udgShNs/oJkFKR6j9KyzVjPmFqfVEGFVg2dhJKoSZ++mYuF4Edmy4BeeCRVqyhl1rxBMpf7mBiS/tcXuBa6qKMy39MH69G5mkp4iDR46hxZ6ZHo86I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710775737; c=relaxed/simple; bh=ksLvNZ2Wo837ga0lzZfmm0D62wGihKXV3yyTa57lg/Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mDNcgEm6ha3s6x6JKGiVgZz7OfPxicakr0lySg+XWTWXceezMMyZ/o+gY2T5Oec2Xa0sxdUkUpnagGEcmAvpyNHVAGvuMCbd9B/kp7JMMpekJnpa10dbfmBkUl+Gp4l9qGZqYXGlB1zIsl88Bf1Pqr6aeFC3GUHI3aTap1FXAcE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=CeD3uX43; arc=none smtp.client-ip=95.215.58.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="CeD3uX43" Message-ID: <7ddf8d4a-5b68-432d-93c1-ff270403cb60@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710775732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ogI4Ujs+JUHaqHuKV+R+xjZenZ7/y4llr8moF4vivgo=; b=CeD3uX43HXFbFfXit67H1ug3tLxw14uwn69KdgqJY0uGyDjouwGdY0g31D4a+9TGx7skth GihOEAZaixaQoGqpmLFiL7HsYAiJvTXJyG2BKW2A31ien2JWXzni4LAf4TaKPek/uy1IvJ EyFVfxklW7aSc8nHZ6BV6CioQ9GqzB0= Date: Mon, 18 Mar 2024 11:28:49 -0400 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in scan_mask Content-Language: en-US To: Jonathan Cameron Cc: Jonathan Cameron , "O'Griofa, Conall" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen References: <20240311162800.11074-1-sean.anderson@linux.dev> <20240314154824.37150a54@jic23-huawei> <3b481539-0c9c-4110-ad03-bd252e80efb0@linux.dev> <20240316133627.5d2bf585@jic23-huawei> <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> <20240318152446.00001345@Huawei.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240318152446.00001345@Huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 3/18/24 11:24, Jonathan Cameron wrote: > On Mon, 18 Mar 2024 11:18:43 -0400 > Sean Anderson wrote: > >> On 3/16/24 09:36, Jonathan Cameron wrote: >> > On Fri, 15 Mar 2024 13:47:40 -0400 >> > Sean Anderson wrote: >> > >> >> Hi Conall, >> >> >> >> On 3/15/24 09:18, O'Griofa, Conall wrote: >> >> > [AMD Official Use Only - General] >> >> > >> >> > Hi, >> >> > >> >> > I think there was a fix for this issue applied to the version that was running on 5.15 that didn't seem to make it into the upstream driver. >> >> > Please see link for reference https://github.com/Xilinx/linux-xlnx/commit/608426961f16ab149b1b699f1c35f7ad244c0720 >> >> > >> >> > I think a similar fix to the above patch is may be beneficial? >> >> >> >> These patches look functionally identical to me. >> > >> > Because there are no channels with scan index between >> > 22 * 2 + 16 (that patch) and 22 * 3 (your patch) that is >> > the effect is indeed the same. But given the issues is the >> > 64 limit on maximum scan index, 22 * 3 = 66 is an ugly value >> > to compare with. >> > >> > I'm still very against the use of scan_index for anything other >> > than scan indices (which is why partly how this bug wasn't noticed >> > in the first palce). So the check should be scan_index != -1 >> > and uses of those values elsewhere in the driver should be fixed >> > (which looks simple to do from a quick glance at the code). >> >> OK, so how do the sysfs files get named then? > > Using channel and channel2 as appropriate (+ index and modified > which change the meaning of channel2) - scan_index never had > anything to do with sysfs file names - just the value in > bufferX/in_xyz_scan_index I tried to prototype setting scan_index to -1, but when registering channels I saw [ 1.637049] iio iio:device0: tried to double register : in_voltage_raw [ 1.637245] xilinx-ams ffa50000.ams: Failed to register sysfs interfaces [ 1.637433] xilinx-ams: probe of ffa50000.ams failed with error -16 And AIUI .channel is filled in by ams_parse_firmware. --Sean >> >> --Sean >> >> >> >> >> --Sean >> >> >> >> >> -----Original Message----- >> >> >> From: Sean Anderson >> >> >> Sent: Thursday, March 14, 2024 5:30 PM >> >> >> To: Jonathan Cameron >> >> >> Cc: linux-iio@vger.kernel.org; O'Griofa, Conall ; >> >> >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Lars-Peter >> >> >> Clausen >> >> >> Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in >> >> >> scan_mask >> >> >> >> >> >> Caution: This message originated from an External Source. Use proper caution >> >> >> when opening attachments, clicking links, or responding. >> >> >> >> >> >> >> >> >> On 3/14/24 11:48, Jonathan Cameron wrote: >> >> >> > On Mon, 11 Mar 2024 12:28:00 -0400 >> >> >> > Sean Anderson wrote: >> >> >> > >> >> >> >> ams_enable_channel_sequence constructs a "scan_mask" for all the PS >> >> >> >> and PL channels. This works out fine, since scan_index for these >> >> >> >> channels is less than 64. However, it also includes the >> >> >> >> ams_ctrl_channels, where scan_index is greater than 64, triggering >> >> >> >> undefined behavior. Since we don't need these channels anyway, just >> >> >> exclude them. >> >> >> >> >> >> >> >> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") >> >> >> >> Signed-off-by: Sean Anderson >> >> >> > >> >> >> > Hi Sean, >> >> >> > >> >> >> > I'd ideally like to understand why we have channels with such large >> >> >> > scan indexes. Those values should only be used for buffered capture. >> >> >> > It feels like they are being abused here. Can we set them to -1 >> >> >> > instead and check based on that? >> >> >> > For a channel, a scan index of -1 means it can't be captured via the >> >> >> > buffered interfaces but only accessed via sysfs reads. >> >> >> > I think that's what we have here? >> >> >> >> >> >> From what I can tell, none of the channels support buffered reads. And we can't >> >> >> naïvely convert the scan_index to -1, since that causes sysfs naming conflicts >> >> >> (not to mention the compatibility break). >> >> >> >> >> >> > >> >> >> > I just feel like if we leave these as things stand, we will get bitten >> >> >> > by similar bugs in the future. At least with -1 it should be obvious why! >> >> >> >> >> >> There are just as likely to be bugs confusing the PL/PS subdevices... >> >> >> >> >> >> FWIW I had no trouble identifying the channels involved with this bug. >> >> >> >> >> >> --Sean >> >> >> >> >> >> > Jonathan >> >> >> > >> >> >> > >> >> >> >> --- >> >> >> >> >> >> >> >> drivers/iio/adc/xilinx-ams.c | 8 ++++++-- >> >> >> >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> >> >> >> >> >> >> diff --git a/drivers/iio/adc/xilinx-ams.c >> >> >> >> b/drivers/iio/adc/xilinx-ams.c index a55396c1f8b2..4de7ce598e4d >> >> >> >> 100644 >> >> >> >> --- a/drivers/iio/adc/xilinx-ams.c >> >> >> >> +++ b/drivers/iio/adc/xilinx-ams.c >> >> >> >> @@ -414,8 +414,12 @@ static void ams_enable_channel_sequence(struct >> >> >> >> iio_dev *indio_dev) >> >> >> >> >> >> >> >> /* Run calibration of PS & PL as part of the sequence */ >> >> >> >> scan_mask = BIT(0) | BIT(AMS_PS_SEQ_MAX); >> >> >> >> - for (i = 0; i < indio_dev->num_channels; i++) >> >> >> >> - scan_mask |= BIT_ULL(indio_dev->channels[i].scan_index); >> >> >> >> + for (i = 0; i < indio_dev->num_channels; i++) { >> >> >> >> + const struct iio_chan_spec *chan = >> >> >> >> + &indio_dev->channels[i]; >> >> >> >> + >> >> >> >> + if (chan->scan_index < AMS_CTRL_SEQ_BASE) >> >> >> >> + scan_mask |= BIT_ULL(chan->scan_index); >> >> >> >> + } >> >> >> >> >> >> >> >> if (ams->ps_base) { >> >> >> >> /* put sysmon in a soft reset to change the sequence */ >> >> >> > >> >> >> > >> >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22BF1C54E58 for ; Mon, 18 Mar 2024 15:29:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Iga+04c71XfqVXqC9DlJqdkSXSGL8gFOX3AkjJgsOek=; b=H2OYF7qskX7jwZ 0QjMTf/wdcAaOS3nk5pIQqGQcWm3t/o1D9WqYDa62/S6+mSe5sukZxaO5B+iU4X6gfhR8mdiNdyfc 5jQMW2WkBDVPEBTEoGNLM84Xip/8TNNrNk+RKGoTi73ehvw7IIG828GdwF06LuND+FVyDlNhTFbyo Q802KmoQ2KWwMRzPMJWpdfvE4WD31OtmU8J3k05sXO2rAfBlPCvrGpc51ZHVXE7hAPpAqO8jNrrK1 mueJbFcJS+SWrBF0hNd3/EyRDIiA/ENbKPwJebTOde2rAM660bfKhwqNA2pLDueWcq8cWXFsMmmL/ K2BBtGng3XFeC+xF0AnQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmEvA-000000092Su-3pAT; Mon, 18 Mar 2024 15:29:04 +0000 Received: from out-177.mta1.migadu.com ([95.215.58.177]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmEv6-000000092P3-1N9l for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 15:29:02 +0000 Message-ID: <7ddf8d4a-5b68-432d-93c1-ff270403cb60@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710775732; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ogI4Ujs+JUHaqHuKV+R+xjZenZ7/y4llr8moF4vivgo=; b=CeD3uX43HXFbFfXit67H1ug3tLxw14uwn69KdgqJY0uGyDjouwGdY0g31D4a+9TGx7skth GihOEAZaixaQoGqpmLFiL7HsYAiJvTXJyG2BKW2A31ien2JWXzni4LAf4TaKPek/uy1IvJ EyFVfxklW7aSc8nHZ6BV6CioQ9GqzB0= Date: Mon, 18 Mar 2024 11:28:49 -0400 MIME-Version: 1.0 Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in scan_mask Content-Language: en-US To: Jonathan Cameron Cc: Jonathan Cameron , "O'Griofa, Conall" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen References: <20240311162800.11074-1-sean.anderson@linux.dev> <20240314154824.37150a54@jic23-huawei> <3b481539-0c9c-4110-ad03-bd252e80efb0@linux.dev> <20240316133627.5d2bf585@jic23-huawei> <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> <20240318152446.00001345@Huawei.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240318152446.00001345@Huawei.com> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_082900_837954_F4406729 X-CRM114-Status: GOOD ( 40.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy8xOC8yNCAxMToyNCwgSm9uYXRoYW4gQ2FtZXJvbiB3cm90ZToKPiBPbiBNb24sIDE4IE1h ciAyMDI0IDExOjE4OjQzIC0wNDAwCj4gU2VhbiBBbmRlcnNvbiA8c2Vhbi5hbmRlcnNvbkBsaW51 eC5kZXY+IHdyb3RlOgo+IAo+PiBPbiAzLzE2LzI0IDA5OjM2LCBKb25hdGhhbiBDYW1lcm9uIHdy b3RlOgo+PiA+IE9uIEZyaSwgMTUgTWFyIDIwMjQgMTM6NDc6NDAgLTA0MDAKPj4gPiBTZWFuIEFu ZGVyc29uIDxzZWFuLmFuZGVyc29uQGxpbnV4LmRldj4gd3JvdGU6Cj4+ID4gICAKPj4gPj4gSGkg Q29uYWxsLAo+PiA+PiAKPj4gPj4gT24gMy8xNS8yNCAwOToxOCwgTydHcmlvZmEsIENvbmFsbCB3 cm90ZTogIAo+PiA+PiA+IFtBTUQgT2ZmaWNpYWwgVXNlIE9ubHkgLSBHZW5lcmFsXQo+PiA+PiA+ IAo+PiA+PiA+IEhpLAo+PiA+PiA+IAo+PiA+PiA+IEkgdGhpbmsgdGhlcmUgd2FzIGEgZml4IGZv ciB0aGlzIGlzc3VlIGFwcGxpZWQgdG8gdGhlIHZlcnNpb24gdGhhdCB3YXMgcnVubmluZyBvbiA1 LjE1IHRoYXQgZGlkbid0IHNlZW0gdG8gbWFrZSBpdCBpbnRvIHRoZSB1cHN0cmVhbSBkcml2ZXIu Cj4+ID4+ID4gUGxlYXNlIHNlZSBsaW5rIGZvciByZWZlcmVuY2UgaHR0cHM6Ly9naXRodWIuY29t L1hpbGlueC9saW51eC14bG54L2NvbW1pdC82MDg0MjY5NjFmMTZhYjE0OWIxYjY5OWYxYzM1Zjdh ZDI0NGMwNzIwCj4+ID4+ID4gCj4+ID4+ID4gSSB0aGluayBhIHNpbWlsYXIgZml4IHRvIHRoZSBh Ym92ZSBwYXRjaCBpcyBtYXkgYmUgYmVuZWZpY2lhbD8gICAgCj4+ID4+IAo+PiA+PiBUaGVzZSBw YXRjaGVzIGxvb2sgZnVuY3Rpb25hbGx5IGlkZW50aWNhbCB0byBtZS4gIAo+PiA+IAo+PiA+IEJl Y2F1c2UgdGhlcmUgYXJlIG5vIGNoYW5uZWxzIHdpdGggc2NhbiBpbmRleCBiZXR3ZWVuCj4+ID4g MjIgKiAyICsgMTYgKHRoYXQgcGF0Y2gpIGFuZCAyMiAqIDMgKHlvdXIgcGF0Y2gpIHRoYXQgaXMK Pj4gPiB0aGUgZWZmZWN0IGlzIGluZGVlZCB0aGUgc2FtZS4gQnV0IGdpdmVuIHRoZSBpc3N1ZXMg aXMgdGhlCj4+ID4gNjQgbGltaXQgb24gbWF4aW11bSBzY2FuIGluZGV4LCAyMiAqIDMgPSA2NiBp cyBhbiB1Z2x5IHZhbHVlCj4+ID4gdG8gY29tcGFyZSB3aXRoLgo+PiA+IAo+PiA+IEknbSBzdGls bCB2ZXJ5IGFnYWluc3QgdGhlIHVzZSBvZiBzY2FuX2luZGV4IGZvciBhbnl0aGluZyBvdGhlcgo+ PiA+IHRoYW4gc2NhbiBpbmRpY2VzICh3aGljaCBpcyB3aHkgcGFydGx5IGhvdyB0aGlzIGJ1ZyB3 YXNuJ3Qgbm90aWNlZAo+PiA+IGluIHRoZSBmaXJzdCBwYWxjZSkuIFNvIHRoZSBjaGVjayBzaG91 bGQgYmUgc2Nhbl9pbmRleCAhPSAtMQo+PiA+IGFuZCB1c2VzIG9mIHRob3NlIHZhbHVlcyBlbHNl d2hlcmUgaW4gdGhlIGRyaXZlciBzaG91bGQgYmUgZml4ZWQKPj4gPiAod2hpY2ggbG9va3Mgc2lt cGxlIHRvIGRvIGZyb20gYSBxdWljayBnbGFuY2UgYXQgdGhlIGNvZGUpLiAgCj4+IAo+PiBPSywg c28gaG93IGRvIHRoZSBzeXNmcyBmaWxlcyBnZXQgbmFtZWQgdGhlbj8KPiAKPiBVc2luZyBjaGFu bmVsIGFuZCBjaGFubmVsMiBhcyBhcHByb3ByaWF0ZSAoKyBpbmRleCBhbmQgbW9kaWZpZWQKPiB3 aGljaCBjaGFuZ2UgdGhlIG1lYW5pbmcgb2YgY2hhbm5lbDIpIC0gc2Nhbl9pbmRleCBuZXZlciBo YWQKPiBhbnl0aGluZyB0byBkbyB3aXRoIHN5c2ZzIGZpbGUgbmFtZXMgLSBqdXN0IHRoZSB2YWx1 ZSBpbgo+IGJ1ZmZlclgvaW5feHl6X3NjYW5faW5kZXgKCkkgdHJpZWQgdG8gcHJvdG90eXBlIHNl dHRpbmcgc2Nhbl9pbmRleCB0byAtMSwgYnV0IHdoZW4gcmVnaXN0ZXJpbmcgY2hhbm5lbHMgSSBz YXcKClsgICAgMS42MzcwNDldIGlpbyBpaW86ZGV2aWNlMDogdHJpZWQgdG8gZG91YmxlIHJlZ2lz dGVyIDogaW5fdm9sdGFnZV9yYXcKWyAgICAxLjYzNzI0NV0geGlsaW54LWFtcyBmZmE1MDAwMC5h bXM6IEZhaWxlZCB0byByZWdpc3RlciBzeXNmcyBpbnRlcmZhY2VzClsgICAgMS42Mzc0MzNdIHhp bGlueC1hbXM6IHByb2JlIG9mIGZmYTUwMDAwLmFtcyBmYWlsZWQgd2l0aCBlcnJvciAtMTYKCkFu ZCBBSVVJIC5jaGFubmVsIGlzIGZpbGxlZCBpbiBieSBhbXNfcGFyc2VfZmlybXdhcmUuCgotLVNl YW4KCj4+IAo+PiAtLVNlYW4KPj4gCj4+ID4+IAo+PiA+PiAtLVNlYW4KPj4gPj4gICAKPj4gPj4g Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4gPj4gPj4gRnJvbTogU2VhbiBBbmRlcnNv biA8c2Vhbi5hbmRlcnNvbkBsaW51eC5kZXY+Cj4+ID4+ID4+IFNlbnQ6IFRodXJzZGF5LCBNYXJj aCAxNCwgMjAyNCA1OjMwIFBNCj4+ID4+ID4+IFRvOiBKb25hdGhhbiBDYW1lcm9uIDxqaWMyM0Br ZXJuZWwub3JnPgo+PiA+PiA+PiBDYzogbGludXgtaWlvQHZnZXIua2VybmVsLm9yZzsgTydHcmlv ZmEsIENvbmFsbCA8Y29uYWxsLm9ncmlvZmFAYW1kLmNvbT47Cj4+ID4+ID4+IGxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsg TGFycy1QZXRlcgo+PiA+PiA+PiBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4+ID4+ID4+IFN1 YmplY3Q6IFJlOiBbUEFUQ0hdIGlpbzogeGlsaW54LWFtczogRG9uJ3QgaW5jbHVkZSBhbXNfY3Ry bF9jaGFubmVscyBpbgo+PiA+PiA+PiBzY2FuX21hc2sKPj4gPj4gPj4KPj4gPj4gPj4gQ2F1dGlv bjogVGhpcyBtZXNzYWdlIG9yaWdpbmF0ZWQgZnJvbSBhbiBFeHRlcm5hbCBTb3VyY2UuIFVzZSBw cm9wZXIgY2F1dGlvbgo+PiA+PiA+PiB3aGVuIG9wZW5pbmcgYXR0YWNobWVudHMsIGNsaWNraW5n IGxpbmtzLCBvciByZXNwb25kaW5nLgo+PiA+PiA+Pgo+PiA+PiA+Pgo+PiA+PiA+PiBPbiAzLzE0 LzI0IDExOjQ4LCBKb25hdGhhbiBDYW1lcm9uIHdyb3RlOiAgICAKPj4gPj4gPj4gPiBPbiBNb24s IDExIE1hciAyMDI0IDEyOjI4OjAwIC0wNDAwCj4+ID4+ID4+ID4gU2VhbiBBbmRlcnNvbiA8c2Vh bi5hbmRlcnNvbkBsaW51eC5kZXY+IHdyb3RlOgo+PiA+PiA+PiA+ICAgIAo+PiA+PiA+PiA+PiBh bXNfZW5hYmxlX2NoYW5uZWxfc2VxdWVuY2UgY29uc3RydWN0cyBhICJzY2FuX21hc2siIGZvciBh bGwgdGhlIFBTCj4+ID4+ID4+ID4+IGFuZCBQTCBjaGFubmVscy4gVGhpcyB3b3JrcyBvdXQgZmlu ZSwgc2luY2Ugc2Nhbl9pbmRleCBmb3IgdGhlc2UKPj4gPj4gPj4gPj4gY2hhbm5lbHMgaXMgbGVz cyB0aGFuIDY0LiBIb3dldmVyLCBpdCBhbHNvIGluY2x1ZGVzIHRoZQo+PiA+PiA+PiA+PiBhbXNf Y3RybF9jaGFubmVscywgd2hlcmUgc2Nhbl9pbmRleCBpcyBncmVhdGVyIHRoYW4gNjQsIHRyaWdn ZXJpbmcKPj4gPj4gPj4gPj4gdW5kZWZpbmVkIGJlaGF2aW9yLiBTaW5jZSB3ZSBkb24ndCBuZWVk IHRoZXNlIGNoYW5uZWxzIGFueXdheSwganVzdCAgICAKPj4gPj4gPj4gZXhjbHVkZSB0aGVtLiAg ICAKPj4gPj4gPj4gPj4KPj4gPj4gPj4gPj4gRml4ZXM6IGQ1YzcwNjI3YTc5NCAoImlpbzogYWRj OiBBZGQgWGlsaW54IEFNUyBkcml2ZXIiKQo+PiA+PiA+PiA+PiBTaWduZWQtb2ZmLWJ5OiBTZWFu IEFuZGVyc29uIDxzZWFuLmFuZGVyc29uQGxpbnV4LmRldj4gICAgCj4+ID4+ID4+ID4KPj4gPj4g Pj4gPiBIaSBTZWFuLAo+PiA+PiA+PiA+Cj4+ID4+ID4+ID4gSSdkIGlkZWFsbHkgbGlrZSB0byB1 bmRlcnN0YW5kIHdoeSB3ZSBoYXZlIGNoYW5uZWxzIHdpdGggc3VjaCBsYXJnZQo+PiA+PiA+PiA+ IHNjYW4gaW5kZXhlcy4gIFRob3NlIHZhbHVlcyBzaG91bGQgb25seSBiZSB1c2VkIGZvciBidWZm ZXJlZCBjYXB0dXJlLgo+PiA+PiA+PiA+IEl0IGZlZWxzIGxpa2UgdGhleSBhcmUgYmVpbmcgYWJ1 c2VkIGhlcmUuICBDYW4gd2Ugc2V0IHRoZW0gdG8gLTEKPj4gPj4gPj4gPiBpbnN0ZWFkIGFuZCBj aGVjayBiYXNlZCBvbiB0aGF0Pwo+PiA+PiA+PiA+IEZvciBhIGNoYW5uZWwsIGEgc2NhbiBpbmRl eCBvZiAtMSBtZWFucyBpdCBjYW4ndCBiZSBjYXB0dXJlZCB2aWEgdGhlCj4+ID4+ID4+ID4gYnVm ZmVyZWQgaW50ZXJmYWNlcyBidXQgb25seSBhY2Nlc3NlZCB2aWEgc3lzZnMgcmVhZHMuCj4+ID4+ ID4+ID4gSSB0aGluayB0aGF0J3Mgd2hhdCB3ZSBoYXZlIGhlcmU/ICAgIAo+PiA+PiA+Pgo+PiA+ PiA+PiBGcm9tIHdoYXQgSSBjYW4gdGVsbCwgbm9uZSBvZiB0aGUgY2hhbm5lbHMgc3VwcG9ydCBi dWZmZXJlZCByZWFkcy4gQW5kIHdlIGNhbid0Cj4+ID4+ID4+IG5hacyIdmVseSBjb252ZXJ0IHRo ZSBzY2FuX2luZGV4IHRvIC0xLCBzaW5jZSB0aGF0IGNhdXNlcyBzeXNmcyBuYW1pbmcgY29uZmxp Y3RzCj4+ID4+ID4+IChub3QgdG8gbWVudGlvbiB0aGUgY29tcGF0aWJpbGl0eSBicmVhaykuCj4+ ID4+ID4+ICAgIAo+PiA+PiA+PiA+Cj4+ID4+ID4+ID4gSSBqdXN0IGZlZWwgbGlrZSBpZiB3ZSBs ZWF2ZSB0aGVzZSBhcyB0aGluZ3Mgc3RhbmQsIHdlIHdpbGwgZ2V0IGJpdHRlbgo+PiA+PiA+PiA+ IGJ5IHNpbWlsYXIgYnVncyBpbiB0aGUgZnV0dXJlLiAgQXQgbGVhc3Qgd2l0aCAtMSBpdCBzaG91 bGQgYmUgb2J2aW91cyB3aHkhICAgIAo+PiA+PiA+Pgo+PiA+PiA+PiBUaGVyZSBhcmUganVzdCBh cyBsaWtlbHkgdG8gYmUgYnVncyBjb25mdXNpbmcgdGhlIFBML1BTIHN1YmRldmljZXMuLi4KPj4g Pj4gPj4KPj4gPj4gPj4gRldJVyBJIGhhZCBubyB0cm91YmxlIGlkZW50aWZ5aW5nIHRoZSBjaGFu bmVscyBpbnZvbHZlZCB3aXRoIHRoaXMgYnVnLgo+PiA+PiA+Pgo+PiA+PiA+PiAtLVNlYW4KPj4g Pj4gPj4gICAgCj4+ID4+ID4+ID4gSm9uYXRoYW4KPj4gPj4gPj4gPgo+PiA+PiA+PiA+ICAgIAo+ PiA+PiA+PiA+PiAtLS0KPj4gPj4gPj4gPj4KPj4gPj4gPj4gPj4gIGRyaXZlcnMvaWlvL2FkYy94 aWxpbngtYW1zLmMgfCA4ICsrKysrKy0tCj4+ID4+ID4+ID4+ICAxIGZpbGUgY2hhbmdlZCwgNiBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+PiA+PiA+PiA+Pgo+PiA+PiA+PiA+PiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9paW8vYWRjL3hpbGlueC1hbXMuYwo+PiA+PiA+PiA+PiBiL2RyaXZl cnMvaWlvL2FkYy94aWxpbngtYW1zLmMgaW5kZXggYTU1Mzk2YzFmOGIyLi40ZGU3Y2U1OThlNGQK Pj4gPj4gPj4gPj4gMTAwNjQ0Cj4+ID4+ID4+ID4+IC0tLSBhL2RyaXZlcnMvaWlvL2FkYy94aWxp bngtYW1zLmMKPj4gPj4gPj4gPj4gKysrIGIvZHJpdmVycy9paW8vYWRjL3hpbGlueC1hbXMuYwo+ PiA+PiA+PiA+PiBAQCAtNDE0LDggKzQxNCwxMiBAQCBzdGF0aWMgdm9pZCBhbXNfZW5hYmxlX2No YW5uZWxfc2VxdWVuY2Uoc3RydWN0Cj4+ID4+ID4+ID4+IGlpb19kZXYgKmluZGlvX2RldikKPj4g Pj4gPj4gPj4KPj4gPj4gPj4gPj4gICAgICAvKiBSdW4gY2FsaWJyYXRpb24gb2YgUFMgJiBQTCBh cyBwYXJ0IG9mIHRoZSBzZXF1ZW5jZSAqLwo+PiA+PiA+PiA+PiAgICAgIHNjYW5fbWFzayA9IEJJ VCgwKSB8IEJJVChBTVNfUFNfU0VRX01BWCk7Cj4+ID4+ID4+ID4+IC0gICAgZm9yIChpID0gMDsg aSA8IGluZGlvX2Rldi0+bnVtX2NoYW5uZWxzOyBpKyspCj4+ID4+ID4+ID4+IC0gICAgICAgICAg ICBzY2FuX21hc2sgfD0gQklUX1VMTChpbmRpb19kZXYtPmNoYW5uZWxzW2ldLnNjYW5faW5kZXgp Owo+PiA+PiA+PiA+PiArICAgIGZvciAoaSA9IDA7IGkgPCBpbmRpb19kZXYtPm51bV9jaGFubmVs czsgaSsrKSB7Cj4+ID4+ID4+ID4+ICsgICAgICAgICAgICBjb25zdCBzdHJ1Y3QgaWlvX2NoYW5f c3BlYyAqY2hhbiA9Cj4+ID4+ID4+ID4+ICsgJmluZGlvX2Rldi0+Y2hhbm5lbHNbaV07Cj4+ID4+ ID4+ID4+ICsKPj4gPj4gPj4gPj4gKyAgICAgICAgICAgIGlmIChjaGFuLT5zY2FuX2luZGV4IDwg QU1TX0NUUkxfU0VRX0JBU0UpCj4+ID4+ID4+ID4+ICsgICAgICAgICAgICAgICAgICAgIHNjYW5f bWFzayB8PSBCSVRfVUxMKGNoYW4tPnNjYW5faW5kZXgpOwo+PiA+PiA+PiA+PiArICAgIH0KPj4g Pj4gPj4gPj4KPj4gPj4gPj4gPj4gICAgICBpZiAoYW1zLT5wc19iYXNlKSB7Cj4+ID4+ID4+ID4+ ICAgICAgICAgICAgICAvKiBwdXQgc3lzbW9uIGluIGEgc29mdCByZXNldCB0byBjaGFuZ2UgdGhl IHNlcXVlbmNlICovICAgIAo+PiA+PiA+PiA+ICAgIAo+PiA+PiAgIAo+PiA+ICAgCj4+IAo+PiAK PiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg==