From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Cyril Hrubis <chrubis@suse.cz>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Subject: Re: [PATCH v2] loop: Add regression test for unsupported backing file fallocate
Date: Tue, 18 Jun 2024 00:48:22 +0000 [thread overview]
Message-ID: <7e01d8db-0cdf-4a9c-8214-56f9f35318df@nvidia.com> (raw)
In-Reply-To: <20240617120018.13832-1-chrubis@suse.cz>
On 6/17/24 05:00, Cyril Hrubis wrote:
> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
[...]
> +
> + errors=$(_dmesg_since_test_start |grep -c "operation not supported error, dev .*WRITE_ZEROES")
> +
nit:- space on the both side of '|' before grep would be nice, can be
done at
the time of applying the patch ...
Looks good.
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-06-18 0:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-17 12:00 [PATCH v2] loop: Add regression test for unsupported backing file fallocate Cyril Hrubis
2024-06-18 0:48 ` Chaitanya Kulkarni [this message]
2024-06-20 7:35 ` Shinichiro Kawasaki
2024-06-21 9:09 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e01d8db-0cdf-4a9c-8214-56f9f35318df@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=chrubis@suse.cz \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.