From: rishabhb@codeaurora.org
To: miklos@szeredi.hu, linux-unionfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: tsoni@codeaurora.org, psodagud@codeaurora.org, jshriram@codeaurora.org
Subject: Re: Bug at kernel/cred.c +443
Date: Mon, 09 Sep 2019 15:49:19 -0700 [thread overview]
Message-ID: <7e14f9c6fa089da67ebc28d7048c369a@codeaurora.org> (raw)
In-Reply-To: <083b3f61efeca1d73839ac96e396748e@codeaurora.org>
On 2019-09-09 15:47, rishabhb@codeaurora.org wrote:
> Hi Miklos
>
> In 4.19 kernel when we write to a file that doesn't exist we see the
> following stack:
> [ 377.382745] ovl_create_or_link+0xac/0x710
> [ 377.382745] ovl_create_object+0xb8/0x110
> [ 377.382745] ovl_create+0x34/0x40
> [ 377.382745] path_openat+0xd44/0x15a8
> [ 377.382745] do_filp_open+0x80/0x128
> [ 377.382745] do_sys_open+0x140/0x250
> [ 377.382745] __arm64_sys_openat+0x2c/0x38
>
> If the override_cred flag = off, the ovl_override_cred and
> ovl_revert_cred just returns NULL.
> But there is another override_cred in between these two functions;
> put_cred(override_creds(override_cred));
> put_cred(override_cred);
>
> This will override the credentials permanently as there is no
> corresponding revert_cred associated.
> So whenever we do commit_creds for this task, we see a BUG_ON at
> kernel/cred.c +443.
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/kernel/cred.c#n443
>
> Should this override_cred be changed to ovl_override_cred to maintain
> consistency and avoid this
> BUG_ON?
>
>
> Thanks,
> Rishabh
Corrected line number in the subject.
prev parent reply other threads:[~2019-09-09 22:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-09 22:47 Bug at kernel/cred.c +432 rishabhb
2019-09-09 22:49 ` rishabhb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e14f9c6fa089da67ebc28d7048c369a@codeaurora.org \
--to=rishabhb@codeaurora.org \
--cc=jshriram@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=psodagud@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.