From: Damien Le Moal <dlemoal@kernel.org>
To: Niklas Cassel <cassel@kernel.org>
Cc: Frederic Weisbecker <frederic@kernel.org>,
Marco Crivellari <marco.crivellari@suse.com>,
Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata: libata-eh: queue hotplug work on the system_dfl_long_wq workqueue
Date: Thu, 14 May 2026 11:13:14 +0900 [thread overview]
Message-ID: <7e452d99-0208-4eca-a340-f72814ee30d2@kernel.org> (raw)
In-Reply-To: <20260513081001.714630-2-cassel@kernel.org>
On 5/13/26 5:10 PM, Niklas Cassel wrote:
> ata_scsi_port_error_handler() uses schedule_delayed_work() to queue
> the ap->hotplug_task work.
>
> schedule_delayed_work() always uses the system_percpu_wq per-cpu
> workqueue.
>
> ata_scsi_scan_host() queues the ap->hotplug_task work on the unbound
> system_dfl_long_wq workqueue.
>
> It seems counter-intuitive to queue the same work on two different
> workqueues. Thus, change ata_scsi_port_error_handler() to also queue
> the ap->hotplug_task work on the system_dfl_long_wq workqueue, such
> that the work is always queued on the same workqueue.
>
> Signed-off-by: Niklas Cassel <cassel@kernel.org>
Looks OK.
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2026-05-14 2:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 8:10 [PATCH] ata: libata-eh: queue hotplug work on the system_dfl_long_wq workqueue Niklas Cassel
2026-05-14 2:13 ` Damien Le Moal [this message]
2026-05-14 3:07 ` sashiko-bot
2026-05-14 6:25 ` Niklas Cassel
2026-05-14 7:10 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e452d99-0208-4eca-a340-f72814ee30d2@kernel.org \
--to=dlemoal@kernel.org \
--cc=cassel@kernel.org \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.