From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1EA22CDB474 for ; Mon, 23 Oct 2023 10:34:35 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.621288.967623 (Exim 4.92) (envelope-from ) id 1qusGQ-0006C9-7M; Mon, 23 Oct 2023 10:34:26 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 621288.967623; Mon, 23 Oct 2023 10:34:26 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qusGQ-0006C2-4p; Mon, 23 Oct 2023 10:34:26 +0000 Received: by outflank-mailman (input) for mailman id 621288; Mon, 23 Oct 2023 10:34:24 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1qusGO-0006Bs-Pa for xen-devel@lists.xenproject.org; Mon, 23 Oct 2023 10:34:24 +0000 Received: from support.bugseng.com (mail.bugseng.com [162.55.131.47]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id bbb282b3-718f-11ee-98d5-6d05b1d4d9a1; Mon, 23 Oct 2023 12:34:24 +0200 (CEST) Received: from support.bugseng.com (support.bugseng.com [162.55.131.47]) by support.bugseng.com (Postfix) with ESMTPA id AA1F64EE0740; Mon, 23 Oct 2023 12:34:23 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: bbb282b3-718f-11ee-98d5-6d05b1d4d9a1 MIME-Version: 1.0 Date: Mon, 23 Oct 2023 12:34:23 +0200 From: Nicola Vetrini To: Stefano Stabellini Cc: Julien Grall , Jan Beulich , Andrew Cooper , Xen-devel , consulting@bugseng.com, Bertrand Marquis , roger.pau@citrix.com, George Dunlap , Wei Liu Subject: Re: MISRA C:2012 D4.11 caution on staging In-Reply-To: References: <7972c20f361126022fa97f6b51ca2d9c@bugseng.com> <61f04d4b-34d9-4fd1-a989-56b042b4f3d8@citrix.com> <26f09702-9340-41ae-afcc-808becb67876@citrix.com> <75a00257-c062-4d82-9b64-1707ce4566e6@xen.org> <594c09e1f8b2e1e8321c2cb862fcb378@bugseng.com> <5ddb6398-f2a3-4bcb-8808-bad653b6c3cd@xen.org> <3573c8c2-1a9c-444c-a542-539b16f689f2@xen.org> <8c25bfd7768d6b290362f56a8b8d44d9@bugseng.com> <87b5936151ace813d9dc9592ee35f86e@bugseng.com> <1aaea648-b156-4297-b290-9c7b7a5010fd@xen.org> User-Agent: Roundcube Webmail/1.4.3 Message-ID: <7e4c60d92abd0d44e7cb3b2d195d0e01@bugseng.com> X-Sender: nicola.vetrini@bugseng.com Organization: BUGSENG s.r.l. Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit On 18/10/2023 23:33, Stefano Stabellini wrote: > On Wed, 18 Oct 2023, Julien Grall wrote: >> On 18/10/2023 13:52, Nicola Vetrini wrote: >> > On 18/10/2023 14:38, Julien Grall wrote: >> > > Hi Nicola, >> > > >> > > On 18/10/2023 13:30, Nicola Vetrini wrote: >> > > > On 17/10/2023 15:28, Julien Grall wrote: >> > > > I tested this, and the report is prevented by the ASSERT. It's up to the >> > > > maintainers to >> > > > decide how do you want to proceed: my suggestion is deviating it, >> > > >> > > It is not clear to me what would you deviate. Can you clarify? >> > > >> > > Cheers, >> > >> > The memcpy call, as in: >> > >> > /* SAF-x-false-positive-eclair */ >> > memcpy(d->handle, config->handle, sizeof(d->handle)); >> >> I am not in favor of this deviation. It could be a false positive >> today, but >> it may not be in the future. >> >> I much prefer the ASSERT() version or the rework. > > Just to be clear about the next steps, Nicola are you OK with sending a > patch with the ASSERT or would you prefer Julien or someone else to do > it? Anyone can pick this up. -- Nicola Vetrini, BSc Software Engineer, BUGSENG srl (https://bugseng.com)