From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 715E5C3DA4A for ; Tue, 20 Aug 2024 14:25:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oIijWWzfx2wkvf+z8Rr+7gk9fjf1EjLJm1Yyu7y8HBk=; b=TsbXG/31gnhA3DwgCmpkWsFHLT dX7ddEcguKI2HJq4ysp3TuioWs9A3NC45lqLrLsyQJAY4rY5rFCX0vJoAr5tW4U+OjK//XVXRC9Eu rMBo6cDbCZ4Onx5RJ8FK9pk0nY3UM3OLtJNEy5d3Lv5RoYFMImukn6unBd0w7SNXs2la0uThpIYh2 /OQg0cvK2QqlW+7lRGp3BGVsi8XDGqsycQA5kkDR0aLze8NonGxDo2p05icLlaImTHNNc+tR4Yd+J 1UXnbnExlI2uMQCwSmA3yqAYvMM1xX0q2jYRH/Y1EYFyauE8xKny4TzzUY8r8tncDWOj0cHqo6JGO nGWy9+Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgPnN-00000005XGA-10Tp; Tue, 20 Aug 2024 14:25:13 +0000 Received: from out-186.mta1.migadu.com ([2001:41d0:203:375::ba]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sgPmU-00000005X2c-0zat for linux-arm-kernel@lists.infradead.org; Tue, 20 Aug 2024 14:24:19 +0000 Message-ID: <7e6caa8b-ae79-4eb0-8ccb-d57471e8a3d5@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1724163855; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oIijWWzfx2wkvf+z8Rr+7gk9fjf1EjLJm1Yyu7y8HBk=; b=JQyh+5//XtwDM6g1Mmzckx2y0JJ0joJEPy2uXUHOrLq0UISdfFTTlhBHjg/5kCPiAtbF6k VTdO8EFbZ+HDZWLuO6zGQ1pcuM4qlm1VF0keJjjZyJ3Md5QQ3j1uO99BYRyG1oqRSdYrjX FDFan5rO8bIgUqlPAk866IuFb3Bp+sU= Date: Tue, 20 Aug 2024 10:24:11 -0400 MIME-Version: 1.0 Subject: Re: [PATCH net-next v2 1/5] net: xilinx: axienet: Always disable promiscuous mode To: Jakub Kicinski Cc: Radhey Shyam Pandey , netdev@vger.kernel.org, "David S . Miller" , Andrew Lunn , linux-arm-kernel@lists.infradead.org, Michal Simek , Daniel Borkmann , linux-kernel@vger.kernel.org, Paolo Abeni , Eric Dumazet , Simon Horman References: <20240815193614.4120810-1-sean.anderson@linux.dev> <20240815193614.4120810-2-sean.anderson@linux.dev> <20240819183041.2b985755@kernel.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240819183041.2b985755@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240820_072418_448639_1C0FDD42 X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/19/24 21:30, Jakub Kicinski wrote: > On Thu, 15 Aug 2024 15:36:10 -0400 Sean Anderson wrote: >> If promiscuous mode is disabled when there are fewer than four multicast >> addresses, then it will to be reflected in the hardware. Fix this by > > it will *not* be reflected? > Something is off with this commit messages, or at least I can't parse > >> always clearing the promiscuous mode flag even when we program multicast >> addresses. >> >> Fixes: 8a3b7a252dca ("drivers/net/ethernet/xilinx: added Xilinx AXI Ethernet driver") > > I think we should ship it as a fix to net? Yes, probably. I put these patches first so they could be easily cherry-picked. --Sean