All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yan Zheng <yzcorp@gmail.com>
To: David Stevens <dlstevens@us.ibm.com>
Cc: Yan Zheng <yanzheng@21cn.com>,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH][MCAST]IPv6: Check packet size when process Multicast Address and Source Specific Query
Date: Tue, 1 Nov 2005 12:20:17 +0800	[thread overview]
Message-ID: <7e77d27c0510312020i435a80v@mail.gmail.com> (raw)
In-Reply-To: <OF1A55BA31.24DA7F68-ON882570AB.006BBA0E-882570AB.006C3CFC@us.ibm.com>

> I think this should be modelled after the equivalent code in IGMPv3.
> See igmp_heard_query() in net/ipv4/igmp.c. For ease of maintenance,
> the code should be structured exactly the same way, except for
> necessary differences, of course.
>
> I haven't seen enough context yet, but  I think you need to check
> for the query header itself, too (as done in IGMPv3).
>
> I'm reviewing your other patches as well.
>
>                                         +-DLS

Yes .  It's  better to drop invalid query earlier.

      reply	other threads:[~2005-11-01  4:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-31  5:20 [PATCH][MCAST]IPv6: Check packet size when process Multicast Address and Source Specific Query Yan Zheng
2005-10-31  5:27 ` YOSHIFUJI Hideaki / 吉藤英明
2005-10-31 12:09   ` Yan Zheng
2005-10-31 12:15     ` YOSHIFUJI Hideaki / 吉藤英明
2005-10-31 19:42 ` David Stevens
2005-11-01  4:20   ` Yan Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e77d27c0510312020i435a80v@mail.gmail.com \
    --to=yzcorp@gmail.com \
    --cc=dlstevens@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yanzheng@21cn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.