From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C955EB64DC for ; Thu, 20 Jul 2023 06:07:56 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E0C3986351; Thu, 20 Jul 2023 08:07:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.b="Q4oOsBPU"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A945E8615A; Thu, 20 Jul 2023 08:07:52 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on20605.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::605]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 20EBC867B2 for ; Thu, 20 Jul 2023 08:07:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=michal.simek@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OqvYxmQVnRWYcK+sHFOJBMV8PeLBbcattYqDuO2nqAFC6zczldFh4ENdyGyXGdS4x55+if/j7uql2nKiufHIAOb3yitOwcAPsHN1wMmTvKl620SHWel/VapzkkefxJm5+8n+xOf1m+Mq+VfbFbBYSqpxYwrLSimRUp0ATrWBzUBkviXcmApAA9y4NkAF/JkTKPLZYR/PsH97NuE/Bib44VG+rPblSlqu1ZvsX4lMOoOkbyNhADDUYtEZ4rjlLISXtH90Cf4n7L9zaceZMJgfEveWa4i4NYdgJ+V0XVPEL1kMSLjCYbesTKiqWTHtcljZIRMH+ECtkDlsWiQ0c7kqfg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gbwa61vmD4EMHaivU8TiqqNwI50mhE2MH1697SU1SPg=; b=WlhQnCrl4M3L/aH5n4jbrDoc4/q+RBVwGk5zVqCcaRnoz77p1DUGolwYJfd2W8/5lQjsbKjHr80pB8mFyNRxKtRT6uu/f13JckvvjFocxSSul0Zyp/ylhWpWXfOHpD9/HzuvSCy6PfZNLMWclNs2Xr3YlFHMQLDWkdtK/nDLRI6jeXuVDud9ilJKSId0xsDbjllT/sFoI7FAYrsF+bmFI0kY7iC0gJruV9hblC29uA2wub0gf5LqID2s3dRzLx+bOlGnE6A3plFkGDp5AcqvQAs2GoeJY8gfHX3yg/qTKQC8mtIcIadTliW8PMlhPOIFDL4j2JokBkyQXsguMO9nvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gbwa61vmD4EMHaivU8TiqqNwI50mhE2MH1697SU1SPg=; b=Q4oOsBPU9LINlYPPXbZDJfL1rSPpNXt0vKi6Lg51lHwXSgWOkBduT7JA6xXlsdt+2ViQs2xUUbLpbMiDoA+AtKbZW8UxdHaJxcm7L7zlMaCdb1jmMENDaslNJyg1wK7HIehOnDIJRcCuYFQ/U2VbIO8/RJC9FkHjXpC03VJirsc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) by DS0PR12MB8813.namprd12.prod.outlook.com (2603:10b6:8:14e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6609.24; Thu, 20 Jul 2023 06:07:45 +0000 Received: from BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::be39:45a4:cd9b:4684]) by BYAPR12MB4758.namprd12.prod.outlook.com ([fe80::be39:45a4:cd9b:4684%3]) with mapi id 15.20.6609.025; Thu, 20 Jul 2023 06:07:45 +0000 Message-ID: <7e87e112-1668-83c7-6faf-b2c4dca24b56@amd.com> Date: Thu, 20 Jul 2023 08:07:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: AKASHI Takahiro , sughosh.ganu@linaro.org, Heinrich Schuchardt , Ilias Apalodimas , u-boot@lists.denx.de, git@xilinx.com References: <9f2b578b-9e10-bf3a-2ce5-229f64b37fd3@amd.com> From: Michal Simek Subject: Re: [PATCH] efi_loader: Allow also empty capsule to be process In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0157.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:99::18) To BYAPR12MB4758.namprd12.prod.outlook.com (2603:10b6:a03:a5::28) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BYAPR12MB4758:EE_|DS0PR12MB8813:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d19be54-7be1-4b97-d742-08db88e7a26a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: wIMrwMMYBrTI2SsxB2eHiC88oOcvV2nypDgMH9faaKLIrT0oc8jz5v0/8wr0NI2FBv3aifH4mNT/UHAFMypX2IBtuhW6ZoNTqD18WCuEXLzdMOfcsDFAGQJ/BSGPuiFfjpuny+WtUyuK25fNNzIhfwgvsXnggP1/6OGfKtvqYiMajtYBnkM3/tgrwodnww5eXD6+WaOlVu0bBAkBFNWhz/KNIf2WAxmlujwfJYS1uZf9lw0YGbsKepy07j8rlZKrix90V8BS+XAXZFjMBwkbADDEmFjBHsNIgkgRj/kftsZvc86R0cISGQ26vYiRN+0RtZrZmuCUbQ63lG4sRf5NMN2Hmy3uS7cWHpd1ZLzhO3HlVv4Pdi92VbKxomvvugQ24XuRz89y9ct0z/AgoD5zFGBDmuo/XY5sZ/oF+6uBwhrTJzKQskvYL9UTl7fHPhh2ucfAf8DCpXenosaCe09BveYgEBTnl5d3Ccv+b1fo8UWSX7uyhchH92bBb2UXsOql0g48AKiwtQ4mLsXPIXenFjKvWL9c7SdeBMPHTMhzpTTTYZ1ZOJOo10sJMO/WU9ibY2+nhLor7J6wBAseLesRXI6oFh8YWrQezuNAolDrjK0g7PelZnNiDUsnl2lXwsM/qkjhf1AcyZf2KlYp9NQFyA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR12MB4758.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(451199021)(83380400001)(2616005)(2906002)(38100700002)(66556008)(66946007)(316002)(66476007)(53546011)(41300700001)(6506007)(26005)(186003)(31686004)(478600001)(6486002)(6512007)(110136005)(31696002)(36756003)(5660300002)(8936002)(44832011)(8676002)(86362001)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dS9EMWVKZDNsZkw3MlFRY0J2NU1kanpBOERGV2dENUh0YW8xanVaM2lMNW5O?= =?utf-8?B?WEFXSjNjdXFaOFVXZnVsSElyUGVYR045Qk5HWEdyem0wOVlobGRmNmc1NHZN?= =?utf-8?B?eHBPTmFpUjNnWmlnSjA1bEhWOWJobUROTURObnYzWDcxcFVFNTZ0anhVc3Jy?= =?utf-8?B?UXZMbDNEeVJwLzl3MDJvNGE2eHFBSjNlSlMzWVRoVFViNmU2elluY2JsZVRP?= =?utf-8?B?UUJoVnpiYTloaGluall5UGltaEFYWlZ1dDhWVHFweURUaWxZdTlFQlVYbGpY?= =?utf-8?B?NHBLZi9oN0hhNXg1dVhmRUZNZzBHRlh0My9XaFZJTzU1c0NLbkkwdm5HbWl1?= =?utf-8?B?RzlSMnNsZ1FJSFhwNFNNWHJRd1ZUL21CM3JldHpJbzNjN1N3ZjVUMVJSbWMx?= =?utf-8?B?MTZkZXdkTU5kb2t6WENiQndUUEVzWExNVDZ1NWF5TnB1YUJ0TjRna0hyUUZV?= =?utf-8?B?TzlvZWRuQk14N2s2akkrUXlZRjhDRDVWS0tKRDFyOXhJcUlyZjRvZnNyN3NW?= =?utf-8?B?d2J6WExNZ212ZzBHTVB5Mk1MRlUzbkFZMld4QzFXUFFKSlJCZmNtbERLMmg3?= =?utf-8?B?akY5eTlQdWZZaFczbm5KdkFvV3psTjJSOC9reE9aSk5rejFHbktNTU5Bb200?= =?utf-8?B?ZVVGZ3lFcHBKc2pHTFlMODVEbzZyd0IvRjlTTGJwVytPZzR5Q294U3ozZTNm?= =?utf-8?B?N3Bmd0QzM3d5dVgzMFNiS216NE8rdXNGYUJaby9YUHhCdDVLUnBnL1o3bnNI?= =?utf-8?B?ZG1ualJSWHVwYnpQZ3FiM2NDOUVtTUo4WHFPY0lIaU5CQ0YydU56a0cwWE8v?= =?utf-8?B?UmFLU214UlQ4S3ROWU5IQ3ZQNDNKUkl0OUlJcFNURjRVMnM1enJ5dk9OMG9l?= =?utf-8?B?VVI2MVJVTlNmK1NRQzg4V1ZLakNMS25nL2JsOVBGem1adkNCOHFoTTdvM2hm?= =?utf-8?B?dDdLcFVQeHpVcEkyMEN6Q1hkSURHTFJ3cVJZb3Y1NDAycmIxbmI3d3lXcW9G?= =?utf-8?B?T0pPSnhnVmNQNEl2MTBtTlZMRTlnZWwxMnUwb2U4Nmo0VWMxN3Zsdm81Zzc0?= =?utf-8?B?eU83MWNOZTNLWUEyVzBSSnRJWHl2WlZ2SlBHcCtBVVNpVXcwc1FQNlVuZXZX?= =?utf-8?B?RXFPRmRtRnJiOG8xNEpQRTU4cS9URlFKOW94cTlSbXYrUDljbDZsbktxZ2l0?= =?utf-8?B?UFdLVXl4eXBxTHE0OGs4d1REOTlNZS93aWJmRGp3Y0NGYmZqMXVFUGg1cGRC?= =?utf-8?B?YnZ2M29DTWlmSlphTXZ5N2xuU0p5WENKYTQ2ZjhkbnNVdVFld3I5VTZpaG8x?= =?utf-8?B?N21wcXltTlg4VU15ZU92VWc0MGhxdnZpbmNDbktqM3l5RGRHcHlIdkgvdmN1?= =?utf-8?B?NXFKOFpEc2YzTFpiVGJWUkV4V0ExREYxSUkxWno4MUQyZXF4Q2U2RHlTOGxK?= =?utf-8?B?WXdhVEZxL2ZaYjVEZUlTQVZXVjlxcmFKS2RWYU9tc1hmR1N1YXdRdUhzMVBa?= =?utf-8?B?RHlLUDhoeGMwMjdoQzhmb29hckZ3VGZzQy9tTHQzbktZcU53VTlINjVEUDZN?= =?utf-8?B?b2dBbTFJcHlGYWJNWlZOQ1R2TzlveTRHbGhRVktTeGRsWElGeHZieEM3cDhL?= =?utf-8?B?dCs4S3pTMkpUVktTUDYwMThmUG8xS2pmdmd2OWxlOHdQK1diNS9xRmd0Qm9w?= =?utf-8?B?UVZqa2xLd2RqY01uTUFVT3lhRHJlK3Qyck1UNkhJUklvbjI0NWVMdXIwbVM2?= =?utf-8?B?TUlYRWlDbm9PMElUZzlJSVF6aFVxZkoyQ3FTRElWS2EwL2c3dUFRRno0aDly?= =?utf-8?B?MjIyL3Y1NWpyS1lqRnVQajh2c3FMQXNmRFA4ZXl0SEQ2S3NUQ2RjZldwbGd5?= =?utf-8?B?cHdISGZDZUkzbksrZGVvVklCZ0RmYzJQVWV0WExVdG1LMWR2MVpqNnV5cGhX?= =?utf-8?B?TlluSnVDQmVaN3lvL0lwbW1OR0dQejJjWjJCQmRoU1pZRGJYRHZvdkx3MitX?= =?utf-8?B?YWttWVczRGdPMWV5Z3BjdVd5cW1ZenBJZzkvVlJqdnNncEFHZUdWalVDb05C?= =?utf-8?B?bzdRRVZPdVZwMnhQM0p1akkxOWppRytLb1VHb2ZIcGt3aTVjTWNZWjcyaG9i?= =?utf-8?Q?9h1XWKFb7SuC51lB1JuMh4ixO?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d19be54-7be1-4b97-d742-08db88e7a26a X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4758.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jul 2023 06:07:45.2170 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vg3EceYr5nSyQRuPT02eAU1HxMBlxUrK1XmJjZvtZBv2OYps3Y7yUU65y6Ko6UWd X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8813 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi, On 7/20/23 07:49, AKASHI Takahiro wrote: > Hi, > > On Wed, Jul 19, 2023 at 08:28:41AM +0200, Michal Simek wrote: >> >> >> On 7/18/23 17:41, Heinrich Schuchardt wrote: >>> On 13.07.23 16:35, Michal Simek wrote: >>>> Empty capsule are also allowed to be process. Without it updated images >>>> can't change their Image Acceptance state from no to yes. >>> >>> Is there any documentation describing the usage of empty capsule to set >>> the image acceptance state? >> >> I actually don't know about documentation. I was talking to Ilias to make >> sure that documentation is up2date because there are missing couple of >> things there. > > Sughosh should have more to say here about A/B update. > >> I am testing A/B update and if you setup oemflags to 0x8000 then capsules >> are not automatically accepted and waiting for acceptance capsule to be >> passed. >> When I tested it I found out that they are not process that's why I created >> this patch. > > The path you tried to modify is only executed by "efidebug capsule update" > or more specifically via the runtime service, UPDATE_CAPSULE. > > But this API is NOT officially supported in the current capsule implementation > (at least, in my initial intention). > The only way to invoke capsule updates is to reboot the system. > If you want to test A/B update, please do the reboot. I realized that to get full flow you need to use capsule update on disk to get all functionalities. But it is very impractical. Actually I would expect via efidebug you should be able to perform all steps as capsule update performs when you do reboot. I would also understand that via efidebug you are not able to apply any capsule but I don't think it is right that you can apply just update capsules but not empty capsules. I would understand none or all but not something in the middle. Thanks, Michal