From: Alexandra Winter <wintera@linux.ibm.com>
To: Joe Damato <jdamato@fastly.com>,
David Miller <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Thorsten Winkler <twinkler@linux.ibm.com>,
Simon Horman <horms@kernel.org>,
Kuniyuki Iwashima <kuniyu@amazon.com>
Subject: Re: [PATCH net] s390/qeth: move netif_napi_add_tx() and napi_enable() from under BH
Date: Thu, 13 Feb 2025 08:37:01 +0100 [thread overview]
Message-ID: <7ea4bc1b-96d8-47a3-8ca2-2baa862d8888@linux.ibm.com> (raw)
In-Reply-To: <Z6z4CMhLo0aj5YEN@LQ3V64L9R2>
On 12.02.25 20:35, Joe Damato wrote:
> On Wed, Feb 12, 2025 at 05:36:59PM +0100, Alexandra Winter wrote:
>> Like other drivers qeth is calling local_bh_enable() after napi_schedule()
>> to kick-start softirqs [0].
>> Since netif_napi_add_tx() and napi_enable() now take the netdev_lock()
>> mutex [1], move them out from under the BH protection. Same solution as in
>> commit a60558644e20 ("wifi: mt76: move napi_enable() from under BH")
>>
>> Fixes: 1b23cdbd2bbc ("net: protect netdev->napi_list with netdev_lock()")
> Hm, I wonder if the fixes should be for commit 413f0271f396 ("net:
> protect NAPI enablement with netdev_lock()") instead ?
I was wondering about that too. netif_napi_add_tx() got the lock in
1b23cdbd2bbc and napi_enable() got the lock in 413f0271f396.
I don't think I can have 2 Fixes tags, can I?
(And I don't think it makes sense to split these few lines up into 2 commits)
I chose 1b23cdbd2bbc because it is the earlier one.
next prev parent reply other threads:[~2025-02-13 7:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 16:36 [PATCH net] s390/qeth: move netif_napi_add_tx() and napi_enable() from under BH Alexandra Winter
2025-02-12 19:35 ` Joe Damato
2025-02-13 7:37 ` Alexandra Winter [this message]
2025-02-13 17:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ea4bc1b-96d8-47a3-8ca2-2baa862d8888@linux.ibm.com \
--to=wintera@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=andrew+netdev@lunn.ch \
--cc=borntraeger@linux.ibm.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=horms@kernel.org \
--cc=jdamato@fastly.com \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=svens@linux.ibm.com \
--cc=twinkler@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.