From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: "Wang, Crag" <Crag.Wang@dell.com>
Cc: "Tudor, Laurentiu" <Laurentiu.Tudor1@dell.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Crag Wang <crag0715@gmail.com>,
"Ksr, Prasanth" <Prasanth.Ksr@dell.com>,
Hans de Goede <hdegoede@redhat.com>,
Dell Client Kernel <Dell.Client.Kernel@dell.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Wang, Berry" <Berry.Wang@dell.com>
Subject: RE: [PATCHv2 1/1] platform/x86: dell-sysman: add support for alienware products
Date: Thu, 3 Oct 2024 14:03:25 +0300 (EEST) [thread overview]
Message-ID: <7ec1d352-4059-e5f8-3ff4-ecc5737d8a6b@linux.intel.com> (raw)
In-Reply-To: <PH0PR19MB49884B9347569041F4EE234BE3682@PH0PR19MB4988.namprd19.prod.outlook.com>
On Tue, 24 Sep 2024, Wang, Crag wrote:
> > Couple of newbie questions: what's the reason for dropping the URL check?
> > Would it make sense to include the reason in the commit msg?
>
> URL in type 11 is subject to change according to OEM ID Module specification, for
> standard Dell and OEM inclusive the string 'Dell System' should be sufficient.
Please add such information into the commit message so it gets properly
recorded. But I'd prefer this to be split into two patches, one adding
the Alienware and another that removes the URL making it easier to revert
only the latter one if the need arises.
--
i.
> Internal Use - Confidential
prev parent reply other threads:[~2024-10-03 11:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 6:36 [PATCH] platform/x86: dell-sysman: add support for alienware products Crag Wang
2024-09-23 13:27 ` Mario Limonciello
2024-09-24 0:45 ` Wang, Crag
2024-10-08 4:31 ` Ksr, Prasanth
2024-09-24 5:02 ` [PATCHv2 1/1] " Crag Wang
2024-09-24 13:24 ` Mario Limonciello
2024-09-24 14:34 ` Tudor, Laurentiu
2024-09-24 14:42 ` Wang, Crag
2024-10-03 11:03 ` Ilpo Järvinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ec1d352-4059-e5f8-3ff4-ecc5737d8a6b@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=Berry.Wang@dell.com \
--cc=Crag.Wang@dell.com \
--cc=Dell.Client.Kernel@dell.com \
--cc=Laurentiu.Tudor1@dell.com \
--cc=Prasanth.Ksr@dell.com \
--cc=crag0715@gmail.com \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.