From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D892244E040 for ; Wed, 19 Aug 2026 10:50:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136637; cv=none; b=SIpTkbKnItZM6qoi2mzdUNPUXpQb0QdeaLF43thjJJ2GTcUxZOIQ47H+pW6Zf93DdA70RVOaJFymcnijjrNXakM/fBGSYIYbdZAcJyMl+AWQq58z+648xEAFKfiQN1UKS0Z1j5eiN6dk4fhFWP+WqK54bnlVuMlHcjJVCKaaGlw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787136637; c=relaxed/simple; bh=pLWeqxVmPvAmK5OgRYY2xNh5uO18zjVWsLOf/nW+/UY=; h=Subject:To:Cc:References:From:Message-ID:Date:MIME-Version: In-Reply-To:Content-Type; b=VSZQjS6fbAE2DEcXVfDknKXYG1T/W9wR1RoKejzCr0DeFkGtKQKz9QPQkC25lD2gVXC26jNf6jf/MX0YUBVeyySCmSIj7nwdbBeG+8/GpjztbWPhvKYC55jCIRbBH+ntNwfzRyJVTR8JJF3Pa8LQvbEj/DdAW9mircPeoiaTZVg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Zk5HBTPK; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Cc1uzKpd; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Zk5HBTPK"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Cc1uzKpd" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67JA8U7o4182218 for ; Wed, 19 Aug 2026 10:50:35 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7ru3BDW+zbBTYwuxf1PK5soAsOVJiRJQNXfeOdOADGQ=; b=Zk5HBTPK2ZbVEjRN ZfTm9FeoFHZ0BGZobeOYfCqFPJN4DA6EOBe1ruQE0uW/aaXSVggyIKxz7Splnb18 i/a2yXb7cPGNNYeiOkXNeDidm/jaz8exsopgs1zZEdxLZZMObkbb5tWhzvaiKLZw ALnYTsH5bbKNVgpQC91FANBmRRU3//NdczZkUf2i1/TNj1fc9LH9hlsI1y1DTH4r aR52jJebZKHcAFgfBdXSURlabCRpTYjafH3T9e2k4kY0Ob6GEldqcedXlGw+7U+s GiDT+Htx+q/JXEhWbKUKwHl4sBFeiPsgixDA2u4k53JESoKZ9yaMcYfaHcqn5kEB YqMZhQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4g4yfkat01-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 19 Aug 2026 10:50:34 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-388cfc4848dso961220a91.3 for ; Wed, 19 Aug 2026 03:50:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787136634; x=1787741434; darn=vger.kernel.org; h=content-transfer-encoding:content-language:content-type:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:from:to:cc:subject:date:message-id:reply-to:content-type; bh=7ru3BDW+zbBTYwuxf1PK5soAsOVJiRJQNXfeOdOADGQ=; b=Cc1uzKpdQjcolXa/N+4qsfmXu0o0LGTUug11lmIW04EalhR+2yxe1/z8UnBKIL4c5Z arVw358Vp0I4+XUtqUSG8n2RVNcxPXGkZFYYjUHvvu3PkbZLxPsSbIJiPm8LOg2LB8WJ LJEbqUX94S1WKtZevYqi6QzbpwK/zlqy9E5E+EFcFLonLj02BVk/D/kr9uNly9F80Avu Db3U1B5/LukOaU2XYGe7izmMPvk+qy/OEToJjutFHuzN/MtUdSNx+Vs6L6eoC62aHsi+ 9qzRq8dju9gTSmSodfbesbzppI8QbGX+pmh0pwAQGVJf3O5mI7Lb7ATUmAwn/LToprFh wk1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787136634; x=1787741434; h=content-transfer-encoding:content-language:content-type:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=7ru3BDW+zbBTYwuxf1PK5soAsOVJiRJQNXfeOdOADGQ=; b=g/COP1ZomV9t1/Zc/MI/EsXvpj/O7XMcovgMEEvwHdvicR/NbDUwGvrtIpHC1uaiPo TvWuxvtOn0WTgxv3s2rbbmnJDIQIozrs5XEqbYx04LWDGGv4Ew+De5Bn8Nr1gGzdc3+2 5n1qMo4tZIsZY3vuNbmUzwntrtIRt1Xe2KwtHd0smvgP/O+g5c1d0AyKRaiuqlaXtefm br0goCBhd8C7pgO2T4KrI/LxdFVlK7B2d4gfl6V651f/lNb1R5KYCCtkk1avfm4aUsc6 FttN54y+KsGB84nwprk7z+Xye/93kc5dGBbuAYWdIxm/Gtrgf3o/SDllP/uNIGXavIwJ fQnQ== X-Forwarded-Encrypted: i=1; AHgh+Rr0DGOA4DibHLAXRRjwEwStlI5bEkQV+ZPuMT0MMJjJLG/0rCfGUc1UrdO6Mxw+vPj3TFnxkrPKYGQ=@vger.kernel.org X-Gm-Message-State: AFuF++n5uJ0efYCdotwSfQ/3en4LP6is1Rox39a/ybuxysxyYvpVj+jW MY4sgp8upFg/2DgnLsu0U9vmdkhzZvGl25p9qYVWDczR9Qf9AnBPOxqnfzpVPR94Tk+z2OToAb1 jPstCS/EO/7A2LK3Mq8xFUpVNzmBgn7NxROie3wkqeCffU9/v0HEhVQLEkV7P4hQ= X-Gm-Gg: AR+sD11q1AuN7cdDN2XnUb9mDVjtxVgY5QB4pAcbTXr1q+UD9MkNcchjMrKAwX9t/6P Z6j6BI2AqyYMpvw48dY7CFTEWWiqNJp6sU5cFxd003+h7VBB2HCk+dxF6kRRO3ya8Jvbx0pAzRs 9LD2zz2NEezGVKv3yJeKow8OoNdAjHJ5fEHAANxoks3bXhs6OJF6GwnCludCdnC4uWAdoE8Upe/ i+3+ILFmKZ3Rj6/bJdRPqWmHHBrOc3os5Fu4vm5XvYQ4EimbjHC8RLkCXa1q11vhOLYlXeX63bT mv47yE8yd+13jSA1SbOEN7KwNoyHIjUe49waMpteM4mjish4VMzHg1AzL/fBgnhzFAplRvqoYaY VdTOLN3GBo8/H+esrSKBGTTajxmo= X-Received: by 2002:a17:90b:1f8f:b0:38d:f5bb:e0f4 with SMTP id 98e67ed59e1d1-39580840520mr7573131a91.1.1787136633750; Wed, 19 Aug 2026 03:50:33 -0700 (PDT) X-Received: by 2002:a17:90b:1f8f:b0:38d:f5bb:e0f4 with SMTP id 98e67ed59e1d1-39580840520mr7573006a91.1.1787136632948; Wed, 19 Aug 2026 03:50:32 -0700 (PDT) Received: from [10.218.4.105] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3957fb7cc17sm2630469a91.9.2026.08.19.03.50.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 19 Aug 2026 03:50:32 -0700 (PDT) Subject: Re: [PATCH v7 2/2] mmc: sdhci-msm: Use pm ops instead of macro to restore crypto keys To: Eric Biggers , Ram Prakash Gupta Cc: ulf.hansson@linaro.org, adrian.hunter@intel.com, quic_dmukhopa@quicinc.com, quic_rampraka@quicinc.com, quic_nitirawa@quicinc.com, quic_sachgupt@quicinc.com, quic_bhaskarv@quicinc.com, quic_gaurkash@quicinc.com, quic_sartgarg@quicinc.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org References: <20260811151759.1258525-1-neeraj.soni@oss.qualcomm.com> <20260811151759.1258525-3-neeraj.soni@oss.qualcomm.com> <20260811190851.GC2895176@google.com> <877c20e3-625c-4ba8-beed-305393b18cfe@oss.qualcomm.com> <20260818171227.GA2249@quark> From: Neeraj Soni Message-ID: <7ed514be-080d-ec2a-0803-9c884c69f4fc@oss.qualcomm.com> Date: Wed, 19 Aug 2026 16:20:26 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 Precedence: bulk X-Mailing-List: linux-mmc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: <20260818171227.GA2249@quark> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: B6SXEsQvcuR7WY2KEDfVhWCAaV0jheXZ X-Proofpoint-ORIG-GUID: B6SXEsQvcuR7WY2KEDfVhWCAaV0jheXZ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODE5MDA4MyBTYWx0ZWRfX94SAzSNBaAeC lQRUiU1yfKGFktb2R3V9H7UilijFMAfpnGEiIjnpwPDBbx3wC2pdNW8exMjWrVSg8KuRygjxnCi RAe4Riir9WfncVORTmscIiI5e3bw2srHKJHan2Om0Fx4jIRdG0LEOMNMS1q1ZSKl4ArYEivVu6I sHQPPdiA+eHFHGK1O3xj6NzNpzbC02DokM+/0PpiMeC3U23Z4P6T6NMvbEmv64xrd2OCxLAVeqV Y9P7zX7h46RVlkSspJOzu6ZKMfWbTa5uATeaBWxnDPCPp6EV7f9PQEo7rAfmd7IbueezKGH0WBM Ftv8G+nSdFi34ql1KCrBjOeBIs2p+7Bb7MZOgkRQt+X5M/akZmaKQHw4Yln/IVaVax7HAuEu9di 2rQAO/HdmQ4IawTfBlxQ/Vb8+0qxFDCPBi5567z0z1iOpb+bqJssib2Ah52vGodLO8tDZPyCo/c zSuiLmxjXrDNY64L3oQ== X-Proofpoint-Spam-Info: AW1haW4tMjYwODE5MDA4MyBTYWx0ZWRfX9l12We0SILxr CdbUXuxqB5TP9M/F+u2iHK9V47UpElSsYfj1lWivKsIIdkK6OnqP2P0JO8sMH8zQOGoSOfNt0QQ eERbKti2xqRI6gOHEwwrdIRmqjZJMbs= X-Authority-Analysis: v=2.4 cv=fvfsol4f c=1 sm=1 tr=0 ts=6a858a7a cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=kxn0zb7G7q0rBOJBbKkA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-19_03,2026-08-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 clxscore=1015 impostorscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 priorityscore=1501 suspectscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608190083 On 8/18/2026 10:42 PM, Eric Biggers wrote: > On Tue, Aug 18, 2026 at 01:00:21PM +0530, Ram Prakash Gupta wrote: >> >> >> On 8/12/2026 12:38 AM, Eric Biggers wrote: >>> On Tue, Aug 11, 2026 at 08:47:59PM +0530, Neeraj Soni wrote: >>>> From: Ram Prakash Gupta >>>> >>>> Inline Crypto Engine (ICE) keys are lost after hibernation entry and this >>>> needs to be restored when hibernation exits. ICE keys are re-programmed >>>> during sdhci_msm_ice_init() but it may not cover cases where the >>>> hibernation image is already restored. >>>> >>>> Unwrap the pm ops and use directly in driver to add the call to restore >>>> Inline Crypto Engine (ICE) keys. This ensures that ICE is brought into >>>> same state as before hibernation. >>>> >>>> Also set MMC_CAP2_CRYPTO_NO_REPROG to indicate that re-programming of ICE >>>> keys is not needed during MMC runtime suspend/resume. >>>> >>>> Signed-off-by: Ram Prakash Gupta >>>> Signed-off-by: Seshu Madhavi Puppala >>>> Co-developed-by: Ram Prakash Gupta >>>> Signed-off-by: Ram Prakash Gupta >>>> Co-developed-by: Sarthak Garg >>>> Signed-off-by: Sarthak Garg >>>> Signed-off-by: Debraj Mukhopadhyay >>>> Signed-off-by: Neeraj Soni >>>> --- >>>> drivers/mmc/host/sdhci-msm.c | 32 +++++++++++++++++++++++++++++++- >>>> 1 file changed, 31 insertions(+), 1 deletion(-) >>> >>> So with this patch, resume from hibernation will be the *only* time that >>> ICE keys are reprogrammed. Are you absolutely sure that is enough on >>> every SoC this driver supports? What about resume from suspend-to-RAM? >>> CQE error recovery? What if the hibernation image fails to be created? >>> >>> - Eric >> >> Hi Eric, >> >> There are two scenarios where key would be required to reprogram, first is when >> rail powering the ICE goes off or SDCC does BCR reset. >> >> now during suspend-to-RAM, rail powering the ice wont go off, so key would not >> be required to reprogram. During CQE recovery, key would be only lost when BCR >> reset is performed but that is not happening right now, to be taken up once its >> fixed as part of recovery flow. And in case hibernation image fails to create >> then device boots from normal flow where there is no need to reprogram the keys. >> > > Okay this patch should be okay then. Seems that the commit message > needs some work though to properly explain this. > Ack. Will update and post v8. > - Eric > Regards, Neeraj