From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-180.mta0.migadu.com (out-180.mta0.migadu.com [91.218.175.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DF894F8A2 for ; Mon, 18 Mar 2024 15:18:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710775136; cv=none; b=e6nJ6ZHYb+gJEp4cUnygi4KWfuvXe0fufFoce9XSdyB9Gqc1jyYA2AFEu2PkEGj+aMi6MFUqvGs5vsEHfJUOIph8r8QVX/tCMtumcxPjC0FRHKAlX23PGibce3pOnfC2sIOvfMCfKMNzYb33SyX3LGo23jvsvEkKTVe0tsOc4Ho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710775136; c=relaxed/simple; bh=AJTNSGdqCb/MYs6kLDwo1nXBehIzhW5FGxiURNhZaxg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rznj2cJyClwSr9Q6TBQN19d3YCjXgv/Wtg7feBdgvO2jEB0OLPsE9IxaWoUBqvMDuuW3v2VC7wloJDNNZ3G9E2zAsUH3nHa31GfUQauPLpqgyPMaoTKhX6GKHKwvQ5UU67nt+3+vSaHSoUvkqoddC88u28hZn/vuok77YPBUW5c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=G44S9rz7; arc=none smtp.client-ip=91.218.175.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="G44S9rz7" Message-ID: <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710775132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U/LBCZpXEzTm4MM2i9sGH7zXGwfRc046vG/VKiVhS10=; b=G44S9rz7aGFTfjXfLqORGfSZ5m5pRsZx1B9adACcubKdxn+wRbMgI57vlp065MuU8Z1lb1 hha7vNWNhJKJG5fSjG7uqRxAhu/dLzv8mASrjSRMgDcsXIH2JJv5W1pLsu1QzxDewzvhX8 R6aOmPygzVJrwqpkH5+y7MJGjucL0Q4= Date: Mon, 18 Mar 2024 11:18:43 -0400 Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in scan_mask Content-Language: en-US To: Jonathan Cameron Cc: "O'Griofa, Conall" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen References: <20240311162800.11074-1-sean.anderson@linux.dev> <20240314154824.37150a54@jic23-huawei> <3b481539-0c9c-4110-ad03-bd252e80efb0@linux.dev> <20240316133627.5d2bf585@jic23-huawei> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240316133627.5d2bf585@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT On 3/16/24 09:36, Jonathan Cameron wrote: > On Fri, 15 Mar 2024 13:47:40 -0400 > Sean Anderson wrote: > >> Hi Conall, >> >> On 3/15/24 09:18, O'Griofa, Conall wrote: >> > [AMD Official Use Only - General] >> > >> > Hi, >> > >> > I think there was a fix for this issue applied to the version that was running on 5.15 that didn't seem to make it into the upstream driver. >> > Please see link for reference https://github.com/Xilinx/linux-xlnx/commit/608426961f16ab149b1b699f1c35f7ad244c0720 >> > >> > I think a similar fix to the above patch is may be beneficial? >> >> These patches look functionally identical to me. > > Because there are no channels with scan index between > 22 * 2 + 16 (that patch) and 22 * 3 (your patch) that is > the effect is indeed the same. But given the issues is the > 64 limit on maximum scan index, 22 * 3 = 66 is an ugly value > to compare with. > > I'm still very against the use of scan_index for anything other > than scan indices (which is why partly how this bug wasn't noticed > in the first palce). So the check should be scan_index != -1 > and uses of those values elsewhere in the driver should be fixed > (which looks simple to do from a quick glance at the code). OK, so how do the sysfs files get named then? --Sean >> >> --Sean >> >> >> -----Original Message----- >> >> From: Sean Anderson >> >> Sent: Thursday, March 14, 2024 5:30 PM >> >> To: Jonathan Cameron >> >> Cc: linux-iio@vger.kernel.org; O'Griofa, Conall ; >> >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Lars-Peter >> >> Clausen >> >> Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in >> >> scan_mask >> >> >> >> Caution: This message originated from an External Source. Use proper caution >> >> when opening attachments, clicking links, or responding. >> >> >> >> >> >> On 3/14/24 11:48, Jonathan Cameron wrote: >> >> > On Mon, 11 Mar 2024 12:28:00 -0400 >> >> > Sean Anderson wrote: >> >> > >> >> >> ams_enable_channel_sequence constructs a "scan_mask" for all the PS >> >> >> and PL channels. This works out fine, since scan_index for these >> >> >> channels is less than 64. However, it also includes the >> >> >> ams_ctrl_channels, where scan_index is greater than 64, triggering >> >> >> undefined behavior. Since we don't need these channels anyway, just >> >> exclude them. >> >> >> >> >> >> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver") >> >> >> Signed-off-by: Sean Anderson >> >> > >> >> > Hi Sean, >> >> > >> >> > I'd ideally like to understand why we have channels with such large >> >> > scan indexes. Those values should only be used for buffered capture. >> >> > It feels like they are being abused here. Can we set them to -1 >> >> > instead and check based on that? >> >> > For a channel, a scan index of -1 means it can't be captured via the >> >> > buffered interfaces but only accessed via sysfs reads. >> >> > I think that's what we have here? >> >> >> >> From what I can tell, none of the channels support buffered reads. And we can't >> >> naïvely convert the scan_index to -1, since that causes sysfs naming conflicts >> >> (not to mention the compatibility break). >> >> >> >> > >> >> > I just feel like if we leave these as things stand, we will get bitten >> >> > by similar bugs in the future. At least with -1 it should be obvious why! >> >> >> >> There are just as likely to be bugs confusing the PL/PS subdevices... >> >> >> >> FWIW I had no trouble identifying the channels involved with this bug. >> >> >> >> --Sean >> >> >> >> > Jonathan >> >> > >> >> > >> >> >> --- >> >> >> >> >> >> drivers/iio/adc/xilinx-ams.c | 8 ++++++-- >> >> >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> >> >> >> >> diff --git a/drivers/iio/adc/xilinx-ams.c >> >> >> b/drivers/iio/adc/xilinx-ams.c index a55396c1f8b2..4de7ce598e4d >> >> >> 100644 >> >> >> --- a/drivers/iio/adc/xilinx-ams.c >> >> >> +++ b/drivers/iio/adc/xilinx-ams.c >> >> >> @@ -414,8 +414,12 @@ static void ams_enable_channel_sequence(struct >> >> >> iio_dev *indio_dev) >> >> >> >> >> >> /* Run calibration of PS & PL as part of the sequence */ >> >> >> scan_mask = BIT(0) | BIT(AMS_PS_SEQ_MAX); >> >> >> - for (i = 0; i < indio_dev->num_channels; i++) >> >> >> - scan_mask |= BIT_ULL(indio_dev->channels[i].scan_index); >> >> >> + for (i = 0; i < indio_dev->num_channels; i++) { >> >> >> + const struct iio_chan_spec *chan = >> >> >> + &indio_dev->channels[i]; >> >> >> + >> >> >> + if (chan->scan_index < AMS_CTRL_SEQ_BASE) >> >> >> + scan_mask |= BIT_ULL(chan->scan_index); >> >> >> + } >> >> >> >> >> >> if (ams->ps_base) { >> >> >> /* put sysmon in a soft reset to change the sequence */ >> >> > >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CB43C54E5D for ; Mon, 18 Mar 2024 15:19:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=taJpN/v288reGt4RzREGJ67j3dmHHxcytE5wy04guJ8=; b=xguRxxsRHKchQs wnLk7hoEzuZuD9BQf7NjPS67dgXIIJgB0YTnt+HVG8vX0NbrERwu7Cu/9/LYIpD9zsld5WDB3vzef 55KXUeyS0CkCSOI372cfwvGw2IMT0+iOnEEigDPhpsjQTLg5TcEU7B9SE5aNYxCP5GO2Gildatzi+ Wp6QOz+R0xahGDo25zeD0kBPLhqvQvb8B/RTZuOK/dP15Vy4JWeSReiIlmpv2gKTeuDXp7wsI79Bj KAZEBJ5APUcZb+tEPycVJeZ9SZWVNkqIm9vdOXncxovCaoVXaCa5J0RoJ/dBonvAH8KkYR0Jx5wMu 69DDao0deMR+Kvmt+9Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmElQ-0000000909q-09Bg; Mon, 18 Mar 2024 15:19:00 +0000 Received: from out-177.mta0.migadu.com ([2001:41d0:1004:224b::b1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rmElM-0000000908N-0ci1 for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2024 15:18:58 +0000 Message-ID: <7ee83f15-88fc-4530-84b7-b8ee31663dbc@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1710775132; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U/LBCZpXEzTm4MM2i9sGH7zXGwfRc046vG/VKiVhS10=; b=G44S9rz7aGFTfjXfLqORGfSZ5m5pRsZx1B9adACcubKdxn+wRbMgI57vlp065MuU8Z1lb1 hha7vNWNhJKJG5fSjG7uqRxAhu/dLzv8mASrjSRMgDcsXIH2JJv5W1pLsu1QzxDewzvhX8 R6aOmPygzVJrwqpkH5+y7MJGjucL0Q4= Date: Mon, 18 Mar 2024 11:18:43 -0400 MIME-Version: 1.0 Subject: Re: [PATCH] iio: xilinx-ams: Don't include ams_ctrl_channels in scan_mask Content-Language: en-US To: Jonathan Cameron Cc: "O'Griofa, Conall" , "linux-iio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Lars-Peter Clausen References: <20240311162800.11074-1-sean.anderson@linux.dev> <20240314154824.37150a54@jic23-huawei> <3b481539-0c9c-4110-ad03-bd252e80efb0@linux.dev> <20240316133627.5d2bf585@jic23-huawei> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sean Anderson In-Reply-To: <20240316133627.5d2bf585@jic23-huawei> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240318_081856_594627_04C15585 X-CRM114-Status: GOOD ( 37.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMy8xNi8yNCAwOTozNiwgSm9uYXRoYW4gQ2FtZXJvbiB3cm90ZToKPiBPbiBGcmksIDE1IE1h ciAyMDI0IDEzOjQ3OjQwIC0wNDAwCj4gU2VhbiBBbmRlcnNvbiA8c2Vhbi5hbmRlcnNvbkBsaW51 eC5kZXY+IHdyb3RlOgo+IAo+PiBIaSBDb25hbGwsCj4+IAo+PiBPbiAzLzE1LzI0IDA5OjE4LCBP J0dyaW9mYSwgQ29uYWxsIHdyb3RlOgo+PiA+IFtBTUQgT2ZmaWNpYWwgVXNlIE9ubHkgLSBHZW5l cmFsXQo+PiA+IAo+PiA+IEhpLAo+PiA+IAo+PiA+IEkgdGhpbmsgdGhlcmUgd2FzIGEgZml4IGZv ciB0aGlzIGlzc3VlIGFwcGxpZWQgdG8gdGhlIHZlcnNpb24gdGhhdCB3YXMgcnVubmluZyBvbiA1 LjE1IHRoYXQgZGlkbid0IHNlZW0gdG8gbWFrZSBpdCBpbnRvIHRoZSB1cHN0cmVhbSBkcml2ZXIu Cj4+ID4gUGxlYXNlIHNlZSBsaW5rIGZvciByZWZlcmVuY2UgaHR0cHM6Ly9naXRodWIuY29tL1hp bGlueC9saW51eC14bG54L2NvbW1pdC82MDg0MjY5NjFmMTZhYjE0OWIxYjY5OWYxYzM1ZjdhZDI0 NGMwNzIwCj4+ID4gCj4+ID4gSSB0aGluayBhIHNpbWlsYXIgZml4IHRvIHRoZSBhYm92ZSBwYXRj aCBpcyBtYXkgYmUgYmVuZWZpY2lhbD8gIAo+PiAKPj4gVGhlc2UgcGF0Y2hlcyBsb29rIGZ1bmN0 aW9uYWxseSBpZGVudGljYWwgdG8gbWUuCj4gCj4gQmVjYXVzZSB0aGVyZSBhcmUgbm8gY2hhbm5l bHMgd2l0aCBzY2FuIGluZGV4IGJldHdlZW4KPiAyMiAqIDIgKyAxNiAodGhhdCBwYXRjaCkgYW5k IDIyICogMyAoeW91ciBwYXRjaCkgdGhhdCBpcwo+IHRoZSBlZmZlY3QgaXMgaW5kZWVkIHRoZSBz YW1lLiBCdXQgZ2l2ZW4gdGhlIGlzc3VlcyBpcyB0aGUKPiA2NCBsaW1pdCBvbiBtYXhpbXVtIHNj YW4gaW5kZXgsIDIyICogMyA9IDY2IGlzIGFuIHVnbHkgdmFsdWUKPiB0byBjb21wYXJlIHdpdGgu Cj4gCj4gSSdtIHN0aWxsIHZlcnkgYWdhaW5zdCB0aGUgdXNlIG9mIHNjYW5faW5kZXggZm9yIGFu eXRoaW5nIG90aGVyCj4gdGhhbiBzY2FuIGluZGljZXMgKHdoaWNoIGlzIHdoeSBwYXJ0bHkgaG93 IHRoaXMgYnVnIHdhc24ndCBub3RpY2VkCj4gaW4gdGhlIGZpcnN0IHBhbGNlKS4gU28gdGhlIGNo ZWNrIHNob3VsZCBiZSBzY2FuX2luZGV4ICE9IC0xCj4gYW5kIHVzZXMgb2YgdGhvc2UgdmFsdWVz IGVsc2V3aGVyZSBpbiB0aGUgZHJpdmVyIHNob3VsZCBiZSBmaXhlZAo+ICh3aGljaCBsb29rcyBz aW1wbGUgdG8gZG8gZnJvbSBhIHF1aWNrIGdsYW5jZSBhdCB0aGUgY29kZSkuCgpPSywgc28gaG93 IGRvIHRoZSBzeXNmcyBmaWxlcyBnZXQgbmFtZWQgdGhlbj8KCi0tU2VhbgoKPj4gCj4+IC0tU2Vh bgo+PiAKPj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4gPj4gRnJvbTogU2VhbiBB bmRlcnNvbiA8c2Vhbi5hbmRlcnNvbkBsaW51eC5kZXY+Cj4+ID4+IFNlbnQ6IFRodXJzZGF5LCBN YXJjaCAxNCwgMjAyNCA1OjMwIFBNCj4+ID4+IFRvOiBKb25hdGhhbiBDYW1lcm9uIDxqaWMyM0Br ZXJuZWwub3JnPgo+PiA+PiBDYzogbGludXgtaWlvQHZnZXIua2VybmVsLm9yZzsgTydHcmlvZmEs IENvbmFsbCA8Y29uYWxsLm9ncmlvZmFAYW1kLmNvbT47Cj4+ID4+IGxpbnV4LWFybS1rZXJuZWxA bGlzdHMuaW5mcmFkZWFkLm9yZzsgbGludXgta2VybmVsQHZnZXIua2VybmVsLm9yZzsgTGFycy1Q ZXRlcgo+PiA+PiBDbGF1c2VuIDxsYXJzQG1ldGFmb28uZGU+Cj4+ID4+IFN1YmplY3Q6IFJlOiBb UEFUQ0hdIGlpbzogeGlsaW54LWFtczogRG9uJ3QgaW5jbHVkZSBhbXNfY3RybF9jaGFubmVscyBp bgo+PiA+PiBzY2FuX21hc2sKPj4gPj4KPj4gPj4gQ2F1dGlvbjogVGhpcyBtZXNzYWdlIG9yaWdp bmF0ZWQgZnJvbSBhbiBFeHRlcm5hbCBTb3VyY2UuIFVzZSBwcm9wZXIgY2F1dGlvbgo+PiA+PiB3 aGVuIG9wZW5pbmcgYXR0YWNobWVudHMsIGNsaWNraW5nIGxpbmtzLCBvciByZXNwb25kaW5nLgo+ PiA+Pgo+PiA+Pgo+PiA+PiBPbiAzLzE0LzI0IDExOjQ4LCBKb25hdGhhbiBDYW1lcm9uIHdyb3Rl OiAgCj4+ID4+ID4gT24gTW9uLCAxMSBNYXIgMjAyNCAxMjoyODowMCAtMDQwMAo+PiA+PiA+IFNl YW4gQW5kZXJzb24gPHNlYW4uYW5kZXJzb25AbGludXguZGV2PiB3cm90ZToKPj4gPj4gPiAgCj4+ ID4+ID4+IGFtc19lbmFibGVfY2hhbm5lbF9zZXF1ZW5jZSBjb25zdHJ1Y3RzIGEgInNjYW5fbWFz ayIgZm9yIGFsbCB0aGUgUFMKPj4gPj4gPj4gYW5kIFBMIGNoYW5uZWxzLiBUaGlzIHdvcmtzIG91 dCBmaW5lLCBzaW5jZSBzY2FuX2luZGV4IGZvciB0aGVzZQo+PiA+PiA+PiBjaGFubmVscyBpcyBs ZXNzIHRoYW4gNjQuIEhvd2V2ZXIsIGl0IGFsc28gaW5jbHVkZXMgdGhlCj4+ID4+ID4+IGFtc19j dHJsX2NoYW5uZWxzLCB3aGVyZSBzY2FuX2luZGV4IGlzIGdyZWF0ZXIgdGhhbiA2NCwgdHJpZ2dl cmluZwo+PiA+PiA+PiB1bmRlZmluZWQgYmVoYXZpb3IuIFNpbmNlIHdlIGRvbid0IG5lZWQgdGhl c2UgY2hhbm5lbHMgYW55d2F5LCBqdXN0ICAKPj4gPj4gZXhjbHVkZSB0aGVtLiAgCj4+ID4+ID4+ Cj4+ID4+ID4+IEZpeGVzOiBkNWM3MDYyN2E3OTQgKCJpaW86IGFkYzogQWRkIFhpbGlueCBBTVMg ZHJpdmVyIikKPj4gPj4gPj4gU2lnbmVkLW9mZi1ieTogU2VhbiBBbmRlcnNvbiA8c2Vhbi5hbmRl cnNvbkBsaW51eC5kZXY+ICAKPj4gPj4gPgo+PiA+PiA+IEhpIFNlYW4sCj4+ID4+ID4KPj4gPj4g PiBJJ2QgaWRlYWxseSBsaWtlIHRvIHVuZGVyc3RhbmQgd2h5IHdlIGhhdmUgY2hhbm5lbHMgd2l0 aCBzdWNoIGxhcmdlCj4+ID4+ID4gc2NhbiBpbmRleGVzLiAgVGhvc2UgdmFsdWVzIHNob3VsZCBv bmx5IGJlIHVzZWQgZm9yIGJ1ZmZlcmVkIGNhcHR1cmUuCj4+ID4+ID4gSXQgZmVlbHMgbGlrZSB0 aGV5IGFyZSBiZWluZyBhYnVzZWQgaGVyZS4gIENhbiB3ZSBzZXQgdGhlbSB0byAtMQo+PiA+PiA+ IGluc3RlYWQgYW5kIGNoZWNrIGJhc2VkIG9uIHRoYXQ/Cj4+ID4+ID4gRm9yIGEgY2hhbm5lbCwg YSBzY2FuIGluZGV4IG9mIC0xIG1lYW5zIGl0IGNhbid0IGJlIGNhcHR1cmVkIHZpYSB0aGUKPj4g Pj4gPiBidWZmZXJlZCBpbnRlcmZhY2VzIGJ1dCBvbmx5IGFjY2Vzc2VkIHZpYSBzeXNmcyByZWFk cy4KPj4gPj4gPiBJIHRoaW5rIHRoYXQncyB3aGF0IHdlIGhhdmUgaGVyZT8gIAo+PiA+Pgo+PiA+ PiBGcm9tIHdoYXQgSSBjYW4gdGVsbCwgbm9uZSBvZiB0aGUgY2hhbm5lbHMgc3VwcG9ydCBidWZm ZXJlZCByZWFkcy4gQW5kIHdlIGNhbid0Cj4+ID4+IG5hacyIdmVseSBjb252ZXJ0IHRoZSBzY2Fu X2luZGV4IHRvIC0xLCBzaW5jZSB0aGF0IGNhdXNlcyBzeXNmcyBuYW1pbmcgY29uZmxpY3RzCj4+ ID4+IChub3QgdG8gbWVudGlvbiB0aGUgY29tcGF0aWJpbGl0eSBicmVhaykuCj4+ID4+ICAKPj4g Pj4gPgo+PiA+PiA+IEkganVzdCBmZWVsIGxpa2UgaWYgd2UgbGVhdmUgdGhlc2UgYXMgdGhpbmdz IHN0YW5kLCB3ZSB3aWxsIGdldCBiaXR0ZW4KPj4gPj4gPiBieSBzaW1pbGFyIGJ1Z3MgaW4gdGhl IGZ1dHVyZS4gIEF0IGxlYXN0IHdpdGggLTEgaXQgc2hvdWxkIGJlIG9idmlvdXMgd2h5ISAgCj4+ ID4+Cj4+ID4+IFRoZXJlIGFyZSBqdXN0IGFzIGxpa2VseSB0byBiZSBidWdzIGNvbmZ1c2luZyB0 aGUgUEwvUFMgc3ViZGV2aWNlcy4uLgo+PiA+Pgo+PiA+PiBGV0lXIEkgaGFkIG5vIHRyb3VibGUg aWRlbnRpZnlpbmcgdGhlIGNoYW5uZWxzIGludm9sdmVkIHdpdGggdGhpcyBidWcuCj4+ID4+Cj4+ ID4+IC0tU2Vhbgo+PiA+PiAgCj4+ID4+ID4gSm9uYXRoYW4KPj4gPj4gPgo+PiA+PiA+ICAKPj4g Pj4gPj4gLS0tCj4+ID4+ID4+Cj4+ID4+ID4+ICBkcml2ZXJzL2lpby9hZGMveGlsaW54LWFtcy5j IHwgOCArKysrKystLQo+PiA+PiA+PiAgMSBmaWxlIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKPj4gPj4gPj4KPj4gPj4gPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaWlv L2FkYy94aWxpbngtYW1zLmMKPj4gPj4gPj4gYi9kcml2ZXJzL2lpby9hZGMveGlsaW54LWFtcy5j IGluZGV4IGE1NTM5NmMxZjhiMi4uNGRlN2NlNTk4ZTRkCj4+ID4+ID4+IDEwMDY0NAo+PiA+PiA+ PiAtLS0gYS9kcml2ZXJzL2lpby9hZGMveGlsaW54LWFtcy5jCj4+ID4+ID4+ICsrKyBiL2RyaXZl cnMvaWlvL2FkYy94aWxpbngtYW1zLmMKPj4gPj4gPj4gQEAgLTQxNCw4ICs0MTQsMTIgQEAgc3Rh dGljIHZvaWQgYW1zX2VuYWJsZV9jaGFubmVsX3NlcXVlbmNlKHN0cnVjdAo+PiA+PiA+PiBpaW9f ZGV2ICppbmRpb19kZXYpCj4+ID4+ID4+Cj4+ID4+ID4+ICAgICAgLyogUnVuIGNhbGlicmF0aW9u IG9mIFBTICYgUEwgYXMgcGFydCBvZiB0aGUgc2VxdWVuY2UgKi8KPj4gPj4gPj4gICAgICBzY2Fu X21hc2sgPSBCSVQoMCkgfCBCSVQoQU1TX1BTX1NFUV9NQVgpOwo+PiA+PiA+PiAtICAgIGZvciAo aSA9IDA7IGkgPCBpbmRpb19kZXYtPm51bV9jaGFubmVsczsgaSsrKQo+PiA+PiA+PiAtICAgICAg ICAgICAgc2Nhbl9tYXNrIHw9IEJJVF9VTEwoaW5kaW9fZGV2LT5jaGFubmVsc1tpXS5zY2FuX2lu ZGV4KTsKPj4gPj4gPj4gKyAgICBmb3IgKGkgPSAwOyBpIDwgaW5kaW9fZGV2LT5udW1fY2hhbm5l bHM7IGkrKykgewo+PiA+PiA+PiArICAgICAgICAgICAgY29uc3Qgc3RydWN0IGlpb19jaGFuX3Nw ZWMgKmNoYW4gPQo+PiA+PiA+PiArICZpbmRpb19kZXYtPmNoYW5uZWxzW2ldOwo+PiA+PiA+PiAr Cj4+ID4+ID4+ICsgICAgICAgICAgICBpZiAoY2hhbi0+c2Nhbl9pbmRleCA8IEFNU19DVFJMX1NF UV9CQVNFKQo+PiA+PiA+PiArICAgICAgICAgICAgICAgICAgICBzY2FuX21hc2sgfD0gQklUX1VM TChjaGFuLT5zY2FuX2luZGV4KTsKPj4gPj4gPj4gKyAgICB9Cj4+ID4+ID4+Cj4+ID4+ID4+ICAg ICAgaWYgKGFtcy0+cHNfYmFzZSkgewo+PiA+PiA+PiAgICAgICAgICAgICAgLyogcHV0IHN5c21v biBpbiBhIHNvZnQgcmVzZXQgdG8gY2hhbmdlIHRoZSBzZXF1ZW5jZSAqLyAgCj4+ID4+ID4gIAo+ PiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg==