From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F9F0C63697 for ; Mon, 23 Nov 2020 21:14:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1E7A206D4 for ; Mon, 23 Nov 2020 21:14:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="Nsp456aR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729639AbgKWVOI (ORCPT ); Mon, 23 Nov 2020 16:14:08 -0500 Received: from z5.mailgun.us ([104.130.96.5]:29451 "EHLO z5.mailgun.us" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728986AbgKWVOI (ORCPT ); Mon, 23 Nov 2020 16:14:08 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606166048; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=fF8sJczCEwJml8nM5LK6JByhLs7eGPmrcAGqvBAOQEg=; b=Nsp456aR1ycq+1An5wuL9prkYvH1h35vLi0P0kAW2nBbHcZAHibXVVskpdrLR+xq7Y4RsoxC yeyHhzOayugSw543PIjfSwovi2F4foxpUCJjO6Wug9IKyrgVwCVLWkv3yB4GeI62AFYkqqR1 lZXGJNwBqZ3Tpo+MLqWTpKJ5mvU= X-Mailgun-Sending-Ip: 104.130.96.5 X-Mailgun-Sid: WyI1MzIzYiIsICJsaW51eC1hcm0tbXNtQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n09.prod.us-east-1.postgun.com with SMTP id 5fbc261fe9b7088622c40ac3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 23 Nov 2020 21:14:07 GMT Sender: abhinavk=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E4D36C43464; Mon, 23 Nov 2020 21:14:06 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 26EE8C43460; Mon, 23 Nov 2020 21:14:06 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Mon, 23 Nov 2020 13:14:06 -0800 From: abhinavk@codeaurora.org To: Lee Jones Cc: freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Clark , Daniel Vetter , Sean Paul Subject: Re: [Freedreno] [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static In-Reply-To: <20201123111919.233376-39-lee.jones@linaro.org> References: <20201123111919.233376-1-lee.jones@linaro.org> <20201123111919.233376-39-lee.jones@linaro.org> Message-ID: <7efa1e1dfd1e415d5614a0f8d266b144@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2020-11-23 03:19, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/msm/msm_drv.c:124:15: warning: no previous prototype > for ‘_msm_ioremap’ [-Wmissing-prototypes] > > Cc: Rob Clark > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Signed-off-by: Lee Jones Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/msm_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/msm/msm_drv.c > b/drivers/gpu/drm/msm/msm_drv.c > index 4d58668b80853..edc99e3b0eca7 100644 > --- a/drivers/gpu/drm/msm/msm_drv.c > +++ b/drivers/gpu/drm/msm/msm_drv.c > @@ -121,8 +121,8 @@ struct clk *msm_clk_get(struct platform_device > *pdev, const char *name) > return clk; > } > > -void __iomem *_msm_ioremap(struct platform_device *pdev, const char > *name, > - const char *dbgname, bool quiet) > +static void __iomem *_msm_ioremap(struct platform_device *pdev, const > char *name, > + const char *dbgname, bool quiet) > { > struct resource *res; > unsigned long size; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DABE0C6379D for ; Mon, 23 Nov 2020 21:14:10 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 88020206D4 for ; Mon, 23 Nov 2020 21:14:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="LYpa/nTM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88020206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D7636E0DA; Mon, 23 Nov 2020 21:14:09 +0000 (UTC) Received: from m42-4.mailgun.net (m42-4.mailgun.net [69.72.42.4]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48B8D89612 for ; Mon, 23 Nov 2020 21:14:07 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606166047; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=fF8sJczCEwJml8nM5LK6JByhLs7eGPmrcAGqvBAOQEg=; b=LYpa/nTMhxo0UCDQ1r5sePVa+x0nFcBbutzwURsPhDtl0EfINygJTMyIervw89ivlbpfh84d PaiIj6FHZBqoquJ8wGLdJsG4737HmHlF/1wMGDn7CoZcohvO8lA2QgxgPxp4++YGg2mG3xpT MTEOOErZqs2gBOVXu3g9aBbfKA0= X-Mailgun-Sending-Ip: 69.72.42.4 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 5fbc261e1dba509aaeb69269 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 23 Nov 2020 21:14:06 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id D71F6C433C6; Mon, 23 Nov 2020 21:14:06 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 26EE8C43460; Mon, 23 Nov 2020 21:14:06 +0000 (UTC) MIME-Version: 1.0 Date: Mon, 23 Nov 2020 13:14:06 -0800 From: abhinavk@codeaurora.org To: Lee Jones Subject: Re: [Freedreno] [PATCH 38/40] drm/msm/msm_drv: Make '_msm_ioremap()' static In-Reply-To: <20201123111919.233376-39-lee.jones@linaro.org> References: <20201123111919.233376-1-lee.jones@linaro.org> <20201123111919.233376-39-lee.jones@linaro.org> Message-ID: <7efa1e1dfd1e415d5614a0f8d266b144@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sean Paul , David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gMjAyMC0xMS0yMyAwMzoxOSwgTGVlIEpvbmVzIHdyb3RlOgo+IEZpeGVzIHRoZSBmb2xsb3dp bmcgVz0xIGtlcm5lbCBidWlsZCB3YXJuaW5nKHMpOgo+IAo+ICBkcml2ZXJzL2dwdS9kcm0vbXNt L21zbV9kcnYuYzoxMjQ6MTU6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZQo+IGZvciDi gJhfbXNtX2lvcmVtYXDigJkgWy1XbWlzc2luZy1wcm90b3R5cGVzXQo+IAo+IENjOiBSb2IgQ2xh cmsgPHJvYmRjbGFya0BnbWFpbC5jb20+Cj4gQ2M6IFNlYW4gUGF1bCA8c2VhbkBwb29ybHkucnVu Pgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0 ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBDYzogbGludXgtYXJtLW1zbUB2Z2VyLmtlcm5lbC5vcmcK PiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IENjOiBmcmVlZHJlbm9AbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gU2lnbmVkLW9mZi1ieTogTGVlIEpvbmVzIDxsZWUuam9uZXNA bGluYXJvLm9yZz4KUmV2aWV3ZWQtYnk6IEFiaGluYXYgS3VtYXIgPGFiaGluYXZrQGNvZGVhdXJv cmEub3JnPgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuYyB8IDQgKystLQo+ ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuYyAKPiBiL2RyaXZlcnMvZ3B1 L2RybS9tc20vbXNtX2Rydi5jCj4gaW5kZXggNGQ1ODY2OGI4MDg1My4uZWRjOTllM2IwZWNhNyAx MDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vbXNtL21zbV9kcnYuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9tc20vbXNtX2Rydi5jCj4gQEAgLTEyMSw4ICsxMjEsOCBAQCBzdHJ1Y3QgY2xr ICptc21fY2xrX2dldChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlCj4gKnBkZXYsIGNvbnN0IGNoYXIg Km5hbWUpCj4gIAlyZXR1cm4gY2xrOwo+ICB9Cj4gCj4gLXZvaWQgX19pb21lbSAqX21zbV9pb3Jl bWFwKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYsIGNvbnN0IGNoYXIgCj4gKm5hbWUsCj4g LQkJCSAgIGNvbnN0IGNoYXIgKmRiZ25hbWUsIGJvb2wgcXVpZXQpCj4gK3N0YXRpYyB2b2lkIF9f aW9tZW0gKl9tc21faW9yZW1hcChzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2LCBjb25zdAo+ IGNoYXIgKm5hbWUsCj4gKwkJCQkgIGNvbnN0IGNoYXIgKmRiZ25hbWUsIGJvb2wgcXVpZXQpCj4g IHsKPiAgCXN0cnVjdCByZXNvdXJjZSAqcmVzOwo+ICAJdW5zaWduZWQgbG9uZyBzaXplOwpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK