From: Ammar Faizi <ammarfaizi2@gnuweeb.org>
To: Pavel Begunkov <asml.silence@gmail.com>, io-uring@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH liburing v2 2/5] liburing: add zc send and notif helpers
Date: Mon, 25 Jul 2022 19:35:37 +0700 [thread overview]
Message-ID: <7efb353d-46ab-47ce-e85e-43ccfb6c8fc0@gnuweeb.org> (raw)
In-Reply-To: <b17478e75fc676260acf618b60cf31a85d8c3b06.1658748624.git.asml.silence@gmail.com>
On 7/25/22 6:33 PM, Pavel Begunkov wrote:
> Add helpers for notification registration and preparing zerocopy send
> requests.
>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
> src/include/liburing.h | 42 ++++++++++++++++++++++++++++++++++++++++++
> src/liburing.map | 2 ++
> src/register.c | 20 ++++++++++++++++++++
> 3 files changed, 64 insertions(+)
[...]
> +static inline void io_uring_prep_notif_update(struct io_uring_sqe *sqe,
> + __u64 new_tag, /* 0 to ignore */
> + unsigned offset, unsigned nr)
> +{
> + io_uring_prep_rw(IORING_OP_FILES_UPDATE, sqe, -1, 0, nr,
> + (__u64)offset);
> + sqe->addr = new_tag;
> + sqe->ioprio = IORING_RSRC_UPDATE_NOTIF;
> +}
The same nit on there. But overall it looks good.
Reviewed-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
--
Ammar Faizi
next prev parent reply other threads:[~2022-07-25 12:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 11:33 [PATCH liburing v2 0/5] zerocopy send headers and tests Pavel Begunkov
2022-07-25 11:33 ` [PATCH liburing v2 1/5] io_uring.h: sync with kernel for zc send and notifiers Pavel Begunkov
2022-07-25 11:33 ` [PATCH liburing v2 2/5] liburing: add zc send and notif helpers Pavel Begunkov
2022-07-25 12:35 ` Ammar Faizi [this message]
2022-07-25 11:33 ` [PATCH liburing v2 3/5] tests: add tests for zerocopy send and notifications Pavel Begunkov
2022-07-25 11:33 ` [PATCH liburing v2 4/5] examples: add a zerocopy send example Pavel Begunkov
2022-07-25 11:33 ` [PATCH liburing v2 5/5] liburing: improve fallocate typecasting Pavel Begunkov
2022-07-25 12:21 ` Ammar Faizi
2022-07-25 12:17 ` [PATCH liburing v2 0/5] zerocopy send headers and tests Ammar Faizi
2022-07-25 15:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7efb353d-46ab-47ce-e85e-43ccfb6c8fc0@gnuweeb.org \
--to=ammarfaizi2@gnuweeb.org \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=io-uring@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.