Re: [PATCH mptcp-next v4 0/4] add netns helpers

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 06/11/2024 04:52, Geliang Tang wrote:
> Hi Matt,
> 
> On Wed, 2024-10-30 at 18:34 +0100, Matthieu Baerts wrote:
>> Hi Geliang,
>>
>> On 30/10/2024 05:03, Geliang Tang wrote:
>>> From: Geliang Tang <tanggeliang@kylinos.cn>
>>>
>>> v4:
>>>  - Use netns_new/netns_free instead of create_netns/cleanup_netns
>>> as
>>> Martin suggested.
>>>
>>> The commit 1e115a58be0ff ("selftests/bpf: netns_new() and
>>> netns_free()
>>> helpers.") now in bpf-next makes v2 of this set useless. v3 only
>>> uses
>>> these new helpers in mptcp selftests and drops other patches.
>>
>> Thank you for the modifications! The new version looks good to me:
>>
>> Reviewed-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
>>
>> If that's OK, I will wait for a review from the BPF maintainers
>> before
>> applying these patches in our repo, not to do too many manipulations
>> just in case an (unexpected) new version is required.
> 
> Patch 1 has been merged into bpf-next/net by Martin today. Please apply
> this set in our repo too. After this, the "add mptcp_subflow bpf_iter"
> series in our repo is ready to be sent to upstream.

Thanks!

New patches for t/upstream:
- c786bfbfa13f: selftests/bpf: Drop netns helpers in mptcp
- Results: b4f136198f02..ac39b3f1d92b (export)

- de2a335efeba: "squashed" patch 2/4 in "selftests/bpf: Add
mptcp_subflow bpf_iter subtest"
- ea4672e6e042: "squashed" (with conflicts) patch 3/4 in "selftests/bpf:
Add bpf scheduler test"
- 8c6acd6502af: "squashed" patch 4/4 in "selftests/bpf: Add bpf_first
scheduler & test"
- Results: ac39b3f1d92b..370ec37a4049 (export)

Tests are now in progress:

- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/3fd30039804ef2d1b62fd95d7cadd5a61dd7f542/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.