Re: [PATCH mptcp-net v4 0/2] mptcp: support MP_PRIO signals with userspace PMs

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Wed, 29 Jun 2022, Paolo Abeni wrote:

> On Tue, 2022-06-28 at 20:37 -0700, Mat Martineau wrote:
>> On Tue, 28 Jun 2022, Kishen Maloor wrote:
>>
>>> This patch series updates MPTCP_PM_CMD_SET_FLAGS to allow userspace PMs
>>> to issue MP_PRIO signals over a selected (by local and remote address+port)
>>> subflow in a MPTCP connection. It also adds self tests for this
>>> change.
>>>
>>> This patch series has been rebased to the series (in review) titled
>>> "Locking fixes for subflow flag changes".
>>>
>>> v2:
>>> -userspace_pm.sh: added a sleep after issuing the MP_PRIO signal.
>>>
>>> v3:
>>> -use local and remote address+port (instead of address ID) alongwith the
>>> connection token to select a subflow.
>>>
>>> v4:
>>> -fixed bug during rebase in v3.
>>
>> Thanks Kishen. v4 looks good to me, and the builds look good (I pushed
>> equivalent commits to github to trigger a build):
>>
>> https://cirrus-ci.com/build/6289402744799232
>> https://github.com/multipath-tcp/mptcp_net-next/runs/7103422638
>>
>> Looks like the github action got a little confused by the exact version of
>> the patches not being in patchwork.
>>
>>
>> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
>>
>> At the meeting last week Paolo said he was planning to take a look as
>> well.
>
> LGTM, too.
>
> Acked-by: Paolo Abeni <pabeni@redhat.com>
>

Thanks for the ack.

As Kishen noted above, this series depends on "Locking fixes for subflow 
flag changes" - have you had a chance to look at that one? Like I 
mentioned in the other thread, it's almost a match for your locking 
changes in the RFC MPC MP_PRIO series.

--
Mat Martineau
Intel