Re: [PATCH for-next] RDMA/efa: Add AH usage counter with sysfs exposure

[Gal Pressman <gal.pressman@linux.dev>]

On 11/02/2026 15:10, Tom Sela wrote:
> +static int efa_add_ah(struct efa_dev *dev, u16 ah)
> +{
> +	unsigned long refcount;
> +	void *entry;
> +	int err;
> +
> +	xa_lock(&dev->ahs_xa);
> +	entry = xa_load(&dev->ahs_xa, ah);
> +	refcount = entry ? xa_to_value(entry) : 0;
> +	if (refcount == 0)
> +		atomic64_inc(&dev->ah_count);

What happens to this increment if the store fails?

> +
> +	err = xa_err(__xa_store(&dev->ahs_xa, ah, xa_mk_value(refcount + 1), GFP_ATOMIC));
> +	xa_unlock(&dev->ahs_xa);
> +
> +	return err;
> +}